Only add response headers once

This commit is contained in:
Dave Syer
2015-12-31 12:35:06 +00:00
parent 6a8f23e185
commit 75a5ba25fd

View File

@@ -143,15 +143,6 @@ public class TraceFilter extends OncePerRequestFilter
request.setAttribute(TRACE_REQUEST_ATTR, trace);
}
// Send new trace id back to the caller
addToResponseIfNotPresent(response, Trace.TRACE_ID_NAME,
trace.getSpan().getTraceId());
addToResponseIfNotPresent(response, Trace.SPAN_ID_NAME,
trace.getSpan().getSpanId());
if (skip) {
addToResponseIfNotPresent(response, Trace.NOT_SAMPLED_NAME, "");
}
try {
addRequestAnnotations(request);
@@ -163,6 +154,9 @@ public class TraceFilter extends OncePerRequestFilter
// TODO: how to deal with response annotations and async?
return;
}
if (skip) {
addToResponseIfNotPresent(response, Trace.NOT_SAMPLED_NAME, "");
}
if (trace != null) {
addResponseHeaders(response, trace.getSpan());
addResponseAnnotations(response);