Commit Graph

717 Commits

Author SHA1 Message Date
Marcin Grzejszczak
06ad66faf1 Bumping into openfeign 2016-07-29 23:48:57 +02:00
Marcin Grzejszczak
11e520c70d Updating the duration setting (#360)
* Updating the duration setting

fixes #349
2016-07-29 23:29:31 +02:00
Marcin Grzejszczak
f74dafbda6 Updated the docs with a newer image 2016-07-29 16:10:56 +02:00
Marcin Grzejszczak
b26ae5da86 Updated the docs to include the new poller mechanism 2016-07-29 15:48:19 +02:00
Steve Oakey
32be48963c Added PollerMetadata for StreamSpanReporter (#343)
Added configurable PollerMetadata bean to be used with the Inbound
Channel Adapter in the StreamSpanReporter. Fixed delay and max messages
per poll are configurable via configuration properties. Implementors can
provide a bean of type PollerMetadata and name
StreamSpanReporter.POLLER to take full control of the poller.

Fixes: gh-338
2016-07-29 15:40:46 +02:00
Marcin Grzejszczak
47606bc9e3 Adding tags for Hystrix spans
with this change if a span hasnt set any Hystrix related spans then we're setting the tags even if the span gets continued (which is the case when you're using Javanica

fixes #352
2016-07-29 15:07:17 +02:00
Marcin Grzejszczak
56e16a25e2 Updated zipkin trace screenshot 2016-07-29 14:22:06 +02:00
Marcin Grzejszczak
11a7c5f2ac Updated docs
fixes #345
2016-07-29 14:06:29 +02:00
Marcin Grzejszczak
7ec9a96764 Adding info about messaging and executors
fixes #351
2016-07-29 12:54:21 +02:00
Marcin Grzejszczak
ea57bb3088 Unified tag names
with this change the tags related to method and class name will not be hyphen delimited.

fixes #359
2016-07-29 12:44:07 +02:00
Víctor Felipe Godoy Hernández
46d18e83a7 Fixing config properties for Zipkin Consumer (#358)
Using the e.g properties from Zipkin Consumer gives the following error when loading the zipkin-server ui:

ERROR: cannot load service names: zipkin/storage/mysql/internal/generated/tables/ZipkinAnnotations
ERROR: cannot load span names: zipkin/storage/mysql/internal/generated/tables/ZipkinSpans

So to fix it you have to explicitly add username and password for the mysql storage.
2016-07-29 12:19:02 +02:00
Adrian Cole
c6bd6f9926 Updates to Zipkin 1.5 (#353)
This is particularly important for the mysql backend, as the bundled
schema now allows dependency aggregation.

See https://github.com/openzipkin/zipkin/releases/tag/1.5.0
2016-07-28 10:03:18 -07:00
Marcin Grzejszczak
637cac60bb Updated CircleCI 2016-07-28 11:14:36 +02:00
Marcin Grzejszczak
f3cbfd93e1 Returning a copy instead of a view (#356)
* Returning a copy instead of a view
* Making logs and tags thread-safe

fixed #355

* Changes following code review
2016-07-28 11:04:28 +02:00
Marcin Grzejszczak
3707c84043 Playing with ghpages 2016-07-27 13:15:15 +02:00
Marcin Grzejszczak
e8a7dfc6eb Updated wrong link in docs 2016-07-27 13:00:02 +02:00
Marcin Grzejszczak
8dbb6e36e4 Fixed missing default Feign.Builder
with this fix if someone is not using Feign he gets the default traced Feign.Builder. Thanks to this no more exceptions should be seen in terms of closing the wrong span.

fixes #350
2016-07-22 18:40:30 +02:00
Marcin Grzejszczak
e28ddc0e72 Migrated to new SpringBootTest
fixes #328
2016-07-19 23:35:30 +02:00
Marcin Grzejszczak
8de8f60c2f Disabling Hystrix for a Feign test 2016-07-19 10:19:32 +02:00
Premanand Chandrasekaran
ee80b301e8 Fix for inability to provide custom implementation of AsyncClientHttpRequestFactory (#342) 2016-07-19 10:13:18 +02:00
Marcin Grzejszczak
4a6a556af0 Added tests and fix docs for AsyncRestTemplate
fixes #334
2016-07-15 16:26:21 +02:00
Marcin Grzejszczak
00b1852efe Changed arraylist to linkedlist 2016-07-15 15:43:13 +02:00
Marcin Grzejszczak
1ffa54f4fc Updated docs 2016-07-15 09:13:14 +02:00
Marcin Grzejszczak
d2c3f63ac8 Added exlipict links to videos 2016-07-15 09:06:16 +02:00
Marcin Grzejszczak
e5da08a0fa Added videos to the docs
fixes #336
2016-07-15 09:02:50 +02:00
Marcin Grzejszczak
deb04e300a Updated docs 2016-07-15 09:00:48 +02:00
Marcin Grzejszczak
48efc5980a Updated docs 2016-07-15 08:23:04 +02:00
Steve Oakey
bf3780536b Added patterns to @GlobalChannelInterceptor (#337)
Makes use of property place holders to set the patterns attribute of the
@GlobalChannelInterceptor annotation used for the
TraceChannelInterceptor. As supported by the annotation, only simple
patterns are supported.

Added the Spring configuration metadata for spring.sleuth.integration
properties.

Fixes gh-323
2016-07-15 08:21:03 +02:00
Marcin Grzejszczak
8d87ed4ceb Fixed the port 2016-07-14 23:45:02 +02:00
Marcin Grzejszczak
1b092c8ca5 Updated readme 2016-07-14 13:51:31 +02:00
Marcin Grzejszczak
a6dd902231 Added additional javadoc information for #332 2016-07-14 13:49:11 +02:00
Marcin Grzejszczak
5caddfa1aa Added Codecov integration 2016-07-14 13:48:51 +02:00
Marcin Grzejszczak
9d3ecca72b Fixed missing wrapping of ExecutorService
with this change the missing methods in ExecutorService are wrapped with LocalComponentTraceCallable. We are wrapping only those callables that have not already been wrapped. Kudos to @PranayPS for finding the issue and proposing a solution.

Fixes #333
2016-07-14 12:59:52 +02:00
Marcin Grzejszczak
3ac3d41bad Fix headers in messaging (#335)
* Fix headers in messaging

with this change the span related headers are changed to be compatible with messaging specs. The change is backwards compatible so we accept the old ones as input, and as output we're producing both new and old headers.

fixes #332
2016-07-14 12:06:39 +02:00
Marcin Grzejszczak
795b7c8e81 Randomized port for a test 2016-07-12 14:20:54 +02:00
Marcin Grzejszczak
4ed747d380 Fixed missing ; in circle scrpit 2016-07-11 15:33:47 +02:00
Marcin Grzejszczak
df3276bafb Fixed a typo in docs 2016-07-11 15:17:27 +02:00
Marcin Grzejszczak
f199321878 Added circle.ci integration
- also limited to 5 seconds awaits
2016-07-11 15:14:21 +02:00
Marcin Grzejszczak
81f70ff071 Removed sending the tracing information back in the response (#329)
fixes #327
2016-07-11 13:21:31 +02:00
Adrian Cole
a7aca7562a Updates to Zipkin 1.3 and rounds up Span duration to one when < 1μ (#326)
Duration of 0 is confusing to plot and can be misinterpreted as null.

See https://github.com/openzipkin/zipkin/issues/1174
See https://github.com/openzipkin/zipkin/releases/tag/1.3.0
2016-07-10 12:08:36 +08:00
Marcin Grzejszczak
777a6299c7 Updating travis script 2016-07-07 11:31:10 +02:00
Marcin Grzejszczak
bfce279d52 Re-added missing server side span (#322)
* Re-added missing server side span

with this change

- HandlerInterceptor is responsible for wrapping requests in spans
- added Sring Data REST instrumentation
- added Zuul instrumentation
- it will not wrap error controller related requests with spans
- tests have been changed to ensure that ALWAYS there is at least one span on the server side (that way it will show up in Zipkin)
- "fallback" mechanism has been added that if a HandlerInterceptor hasn't been used then we are forcing creation of a Span at the server side

fixes #321
(cherry picked from commit 4f1ef52e6c)
2016-07-07 11:03:33 +02:00
Dave Syer
9d296a47b6 Add small sample app to README 2016-07-05 09:57:51 +01:00
Spencer Gibb
384b78b86c Upgrade to s-c-build 1.2.0 2016-07-01 16:39:24 -06:00
Marcin Grzejszczak
48d46b07bb Added RibbonCommand instrumentation (#318)
with this change RibbonRequestCustomizers are created for
- Netflix HttpClient
- OkHttp client
- Apache HttpClient

those customizers know how to inject span into the given context. Also a wrapper over a RibbonCommandFactory bean gets created that injects http trace keys to the given span

fixes #313
2016-06-30 13:02:31 +02:00
Marcin Grzejszczak
61e70deff5 Fixed the hacks for Feign 2016-06-30 11:48:54 +02:00
Marcin Grzejszczak
6bc4a9862b Fixed not clearing spans on messaging exception
with this change we're closing spans on afterSendCompletion and not afterPost thus even if an exception is thrown we will close the span

    fixes #319
2016-06-30 11:21:27 +02:00
Marcin Grzejszczak
6b5fa63553 Exposes getAccumulatedMicros for more precise Span duration (#317)
Formerly, `Span.getAccumulatedMillis()` worked, but could returns
    imprecise measurements, particularly local spans. This changes the
    internals of Span to keep track of a start tick. Using this, it can
    return a more precise `Span.getAccumulatedMicros()`.

    To ensure this precision isn't lost in serialization, this adds a
    json field `durationMicros`, which is only set when the span is stopped.
    This is set instead of start tick because `System.nanoTime()` is JVM
    specific and so cannot be used across the network. `durationMicros` uses
    null instead of zero comparisons because nano time can be negative.

    Fixes #312

    Fixed integration tests to use ZipkinRule
    Introduce assertj assertions (#315)

    * Introduce assertJ assertions in some tests
    * Fix code formatting to be inline with Spring rules
2016-06-29 10:44:00 +02:00
Marcin Grzejszczak
9641d4ef98 Possibility to customize HTTP Client for Zipkin calls
* Added RestTemplate for Zipkin
* Added ZipkinRestTemplateCustomizer to allow possibility to customize RestTemplate
* Addded DefaultZipkinRestTemplateCustomizer with GZip compression interceptor
2016-06-28 12:11:40 +02:00
Spencer Gibb
43a8bcfe2e Pass empty collections rather than null. 2016-06-27 14:46:27 -06:00