SpringCloud/spring-cloud-sleuth
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,445 Commits 14 Branches 0 Tags
7f73677bc839794e5f4e698881bee4538ac8b286
Commit Graph

690 Commits

Author SHA1 Message Date
Marcin Grzejszczak
7f73677bc8 Spel security fix; fixes gh-917 2018-04-06 17:06:47 +02:00
Marcin Grzejszczak
449db63f81 Removed the check for null payload 2018-02-19 12:17:08 +01:00
Marcin Grzejszczak
a8587b68e3 Added a check for null message / message payload 
fixes gh-861
 2018-02-19 11:59:03 +01:00
Marcin Grzejszczak
aa8edc9e7d Wrapping a DestinationResolver in an aspect that adds an interceptor if it's not there already 
fixes gh-838
 2018-02-16 12:22:34 +01:00
Marcin Grzejszczak
e50005e5f6 Fixed the build 2018-02-15 17:51:06 +01:00
Marcin Grzejszczak
64b5cb6072 Added additional check for standard 4xx errors; fixes gh-859 2018-02-15 16:53:18 +01:00
Marcin Grzejszczak
0a5fa8bdad Not closing a span if exception happened and error controller is present; fixes gh-859 2018-02-15 13:24:17 +01:00
Marcin Grzejszczak
20891321a3 Fixes DirectChannel support (#860) 
without this change for DirectChannel `beforeHandle` and `afterHandle` were not called at all
with this change we're removing any hacks and we're executing those methods

fixes gh-821
 2018-02-14 23:07:51 +01:00
Marcin Grzejszczak
68dc29a0ed wrapping all rest templates via BPP; fixes gh-846 2018-02-14 17:58:54 +01:00
Marcin Grzejszczak
91d1bf89aa Stopped setting CS in pre zuul filter; fixes gh-849 2018-02-14 14:33:18 +01:00
Marcin Grzejszczak
1c1aca667a ZipkinExtractor uses SkipPatternProvider; fixes gh-851 2018-02-13 15:55:00 +01:00
Marcin Grzejszczak
48ac636b8c Not closing a span if it got already closed; fixes gh-842 2018-02-13 15:34:22 +01:00
Marcin Grzejszczak
33fda4e700 Added an example with custom rest template builder 2018-02-12 13:30:50 +01:00
Marcin Grzejszczak
d62756e3b1 Updated tests 2018-02-12 11:19:41 +01:00
Marcin Grzejszczak
e1088f5700 Lazy rest template interceptor injection 
without this change there was a ciruclar dependency between rest template, rest template builder creation and instrumentation
with this change, in the post construct phase we're setting values for rest template lazilly

fixes gh-852
 2018-02-12 11:07:22 +01:00
Marcin Grzejszczak
33dd940fd7 RestTemplate: register Trace interceptor *first* in the chain; fixes #822 2018-01-20 17:48:32 +01:00
Marcin Grzejszczak
2bd669cb2c Should detach span from trace filter for async; fixes #728 2018-01-20 16:58:03 +01:00
Marcin Grzejszczak
89176772bc Added a test for a pollable channel 2018-01-11 11:17:49 +01:00
Marcin Grzejszczak
c1f0951b7d Merge branch '1.2.x' into 1.3.x 2017-12-18 18:56:01 +01:00
Marcin Grzejszczak
09ab94b59d Fixed invalid reading from 'key' attribute of SpanTag; fixes #800 2017-12-18 18:54:47 +01:00
Marcin Grzejszczak
4520268303 Made tests less brittle 2017-11-22 10:30:01 +01:00
Marcin Grzejszczak
82cff6e9e9 Merge branch '1.2.x' 2017-11-22 10:17:39 +01:00
Marcin Grzejszczak
2d53a38c14 Wrapping the feign object in a different way 2017-11-22 10:07:40 +01:00
Marcin Grzejszczak
b4ecb6f957 Ensure we're not tracing the traced feign clients 
fixes #791
 2017-11-21 19:22:44 +01:00
Marcin Grzejszczak
8e9fa7125c Ensure we're not tracing the traced feign clients 
fixes #791
 2017-11-21 19:07:06 +01:00
Marcin Grzejszczak
2ecd77d151 Fighting flakey tests 2017-11-17 12:02:05 +01:00
Marcin Grzejszczak
08b5d04133 Removed @EnableAsync from configuration; fixes #780 2017-11-14 18:03:03 +01:00
Marcin Grzejszczak
e2c11b592c Added RestTemplateBuilder support 
fixes #777
 2017-11-14 14:57:27 +01:00
Marcin Grzejszczak
360f7ed187 Removed type target from New/ContinueSpan; fixes #772 2017-11-14 11:32:25 +01:00
Marcin Grzejszczak
4203566d87 Exceptions that escape SpringMVC DispatcherServlet should be logged with trace & span IDs 
without this change any exception that is not caught by a filter, get caught and logged by server's internals (e.g. Tomcat's Valve). To make the Valve log the exception together with the tracing information we would have to allow the tracing context remain in the thread after TraceFilter gets executed. That is problematic cause we're polluting the ThreadLocal and would have to assume that some component will eventually clear the context.

with this change we're trying to solve the issue from a different angle. Whenever an uncaught exception is thrown, we are already catching it in the `catch(...) {}` clause. It's enough to just log it at the error level and that way, regardless of the underlying server implementation (Tomcat, Undertow) we will log the uncaught exception and rethrow it.

fixes #714
 2017-11-03 22:41:50 +01:00
Marcin Grzejszczak
f1a6a7f687 Merge branch '1.2.x' 2017-11-02 05:55:53 +01:00
Marcin Grzejszczak
dadb46731e Sleuth no longer corrupts Error Message Channel Headers (#765) 
fixes #761
 2017-11-01 14:21:41 +01:00
Marcin Grzejszczak
c4241413a0 Merge branch '1.2.x' 2017-10-23 20:40:33 +02:00
Marcin Grzejszczak
3c2c43adff Fixed the invalid closing of spans; fixes #759 2017-10-23 19:39:08 +02:00
Marcin Grzejszczak
5fff2e03a2 Merge branch '1.2.x' 2017-10-20 12:48:11 +02:00
Marcin Grzejszczak
6f85526096 Setting headers instead of adding them for Zuul; fixes #755 2017-10-20 12:47:15 +02:00
Marcin Grzejszczak
5bdc64ab6c Merged 1.2.x to master 2017-10-19 13:49:29 +02:00
Dave Syer
70821f4dc3 Test executor channel interceptor 2017-10-18 10:13:57 +01:00
Dave Syer
00e9a1f5dc Add tests for native headers in message interceptor 2017-10-18 10:13:57 +01:00
Dave Syer
c21a1e6dda Test for intercepting broker channel 2017-10-18 10:13:57 +01:00
Dave Syer
85d8151592 Ensure native headers get added to STOMP messages 
Also changed some of the span creation logic in the messaging
interceptor. Seems to make sense. Need more tests.
 2017-10-18 10:13:47 +01:00
Adrian Cole
8221068581 Encodes epoch seconds into first 32bits of a 128-bit trace ID (#724) 
Amazon will throw out trace IDs that aren't associated with a recent
timestamp. This encodes the current epoch seconds into the first 32
of a 128-bit trace ID to support conversion to an Amazon Root ID.
 2017-10-17 14:55:45 +08:00
Marcin Grzejszczak
86a6f7a6d7 Merge branch '1.2.x' 2017-10-16 09:29:41 +02:00
Marcin Grzejszczak
5ec3ca53bf Fixing recreation of a random; fixes #728 2017-10-16 09:28:32 +02:00
Anton Kislitsyn
8c7a20b07c Filter values having Zipkin compatible keys (#740) 
Optimization linked with necessity to exclude unrequired values from the temporary carrier of header values
 2017-10-16 08:14:35 +02:00
Marcin Grzejszczak
ab656f09b6 Merge branch '1.2.x' 2017-10-16 08:10:40 +02:00
Robert Hafner
d7cebccf0c Non-ASCII characters included in X-SPAN-NAME header. (#735) 2017-10-16 08:05:16 +02:00
Marcin Grzejszczak
29335363c5 Merge branch '1.2.x' 2017-10-10 14:10:51 +02:00
Marcin Grzejszczak
d2672f832a Added missing delegates to ThreadPoolTaskExecutor; fixes #722 2017-10-10 13:56:42 +02:00
Adrian Cole
522087ac25 Adds spring.sleuth.supports-join to disable span ID sharing (#725) 
This adds the ability to opt out of span sharing between the client and
server side of an RPC. This is important when reporting to systems that
do not share span IDs, such as Google Stackdriver and Amazon X-Ray.
 2017-10-06 14:18:02 +08:00