Commit Graph

682 Commits

Author SHA1 Message Date
Marcin Grzejszczak
c951dc88fd Improvements of customizing the TraceFilter
without this change you have to add a `@Primary` annotation around your custom `TraceFilter` bean to alter the behaviour of the current `TraceFilter` implementation
with this change we're marking the `TraceFilter` as conditional on missing bean; also we're ensuring that the registered `SkipPatternProvider` will be reused when no explicit pattern was set.

also documentation is added

fixes #633
2017-08-24 14:14:01 +02:00
Marcin Grzejszczak
77c1de386f Fixed class not being static 2017-08-23 18:19:36 +02:00
Marcin Grzejszczak
6d25738ec4 Adding the default Trace representation of UserInfoRestTemplateCustomizer 2017-08-23 18:15:48 +02:00
Marcin Grzejszczak
58f3d0fce0 Added fallback approach to try to create a JDK proxy when CGLIB one fails
without this change when a CGLIB proxy fails to be created an exception is thrown
with this change we're trying to save the situation by trying to create a JDK proxy. If that also won't work then we're throwing an exception.

fixes #684
2017-08-22 12:52:35 +02:00
Marcin Grzejszczak
17df781524 Bumping versions to 1.2.5.BUILD-SNAPSHOT after release 2017-08-21 10:06:48 +02:00
Marcin Grzejszczak
cbddd5568c Going back to snapshots 2017-08-21 10:06:47 +02:00
Marcin Grzejszczak
5eba47d891 Update SNAPSHOT to 1.2.4.RELEASE 2017-08-21 10:01:14 +02:00
Marcin Grzejszczak
02a0c864e8 Bumping versions to 1.2.4.BUILD-SNAPSHOT after release 2017-08-18 18:46:50 +02:00
Marcin Grzejszczak
73211f673b Going back to snapshots 2017-08-18 18:46:49 +02:00
Marcin Grzejszczak
47612da5cc Update SNAPSHOT to 1.2.3.RELEASE 2017-08-18 18:36:51 +02:00
Marcin Grzejszczak
59f5a99c24 TraceFilter skipPattern and extra span when X-B3-Flags header is present
without this change if there's a debug flag we set traceid & spanid for the first request inside the zipkin http extractor. we don't set the parent span flag so an additional span is created.
with this change we set the trace and span id ONLY when the debug flag is set AND the request is malformed. That means - only when the span id is set and there is no trace id.

fixes #665
2017-08-18 16:24:28 +02:00
Marcin Grzejszczak
e9211e8bd0 Polish 2017-08-18 03:32:24 +02:00
Marcin Grzejszczak
c268d55656 Added debug logs for TraceChannelInterceptor 2017-08-18 03:31:35 +02:00
Marcin Grzejszczak
acfbb3b8f7 Added missing profile 2017-08-18 02:50:27 +02:00
Marcin Grzejszczak
c3d198053f Enable spring-data only on demand for tests 2017-08-17 13:40:27 +02:00
Marcin Grzejszczak
253b34b1cf Fixed missing interceptor injection in OAuth2RestTemplate
fixes #581
2017-08-14 10:10:38 -04:00
Canaan Stafford
7dffabd91a Expand type check in TraceChannelInterceptor (#673)
The type check in the method 'getMessage' was only for a sub-class of
MessagingException. The check was expanded to the base class.
2017-08-05 22:10:54 +02:00
Marcin Grzejszczak
48227e7793 Returns proper message; fixes #669 2017-08-04 11:52:31 +02:00
Marcin Grzejszczak
aadf0a8334 Added support for failed messages
without this change when messages arrive at a error channel a new traceid is set
with this change we continue the trace

fixes #667
2017-08-03 17:50:47 +02:00
Marcin Grzejszczak
e8d30be75e Going back to snapshots 2017-07-21 12:58:54 +02:00
Marcin Grzejszczak
932f8e74d3 Update SNAPSHOT to 1.2.2.RELEASE 2017-07-21 12:30:53 +02:00
Marcin Grzejszczak
87411d760c Ensured lower case of baggage keys
fixes #641
2017-07-15 10:14:39 +02:00
Marcin Grzejszczak
aaf191e4c6 Logs are no longer altered when sleuth is disabled
fixes #638
2017-07-14 12:33:57 +02:00
Marcin Grzejszczak
be81264398 Added missing span continuation in AsyncRestTemplate
fixes #636
2017-07-12 18:50:56 +02:00
Marcin Grzejszczak
feac9980da Fixed not clearing trace attribute on closed span
due to this Zuul spans have been improperly closed and the span remained in the main thread. After sending enough requests the traces started to be reused by the worker threads.

fixes #634
2017-07-12 18:08:43 +02:00
Marcin Grzejszczak
050dfe9bdf Added missing error setting on the span in zuul pre filters
without this change when an exception is thrown in a filter we're not setting the error message as a tag.

fixes #616
2017-07-06 12:23:49 +02:00
Marcin Grzejszczak
a977e4ae0e Added missing methods to override in SleuthHystrixConcurrencyStrategy
according to issue #612:
> When 2 or more customized HystrixConcurrencyStrategy are registered (e.g SleuthHystrixConcurrencyStrategy and SecurityContextConcurrencyStrategy) depending on the order of registration the overrides from SecurityContextConcurrencyStrategy might get ignored.
I think the override and delegation should be made all methods of HystrixConcurrencyStrategy otherwise the delegation will possibly be incomplete.

fixes #612
2017-07-06 11:54:21 +02:00
Marcin Grzejszczak
2a09be747d Making Hystrix + Feign opt in
without this change we allways force Feign to use Hystrix
with this change you need to pass the `feign.hystrix.enabled=true` flag to turn it on

fixes #627
2017-07-03 08:00:40 +02:00
Marcin Grzejszczak
c3e90e4e21 Fixed NPE for error parser 2017-06-30 11:29:53 +02:00
Suttichort Sarathum
c902680244 Add missing implementation of shutdown method 2017-06-27 13:50:54 +02:00
Marcin Grzejszczak
cc00e3ae80 Making baggage keys case insensitive
fixes #605
2017-06-07 10:40:57 +02:00
Marcin Grzejszczak
f834e5222b Added the ErrorParser interface
without this change there's no way to alter the exception message that gets attached as a tag to the span
    with this change you can register your own ErrorParser bean to alter that behaviour

    fixes #576
2017-06-06 08:05:27 +02:00
Marcin Grzejszczak
6a0a57ef7f Fixed percentage value in percentage based sampler
fixes #608
2017-06-06 07:54:17 +02:00
Marcin Grzejszczak
95e14c0a68 Polish 2017-06-01 13:03:50 +02:00
svenz
e783df88a0 Cleanup test case based on review comments 2017-05-30 19:19:27 -07:00
svenz
6948088085 https://github.com/spring-cloud/spring-cloud-sleuth/issues/597
Fix Http headers as tags
2017-05-29 13:49:55 -07:00
Marcin Grzejszczak
419ec7232a Fixed the Duplicate Trace Header Propagation for Zuul Proxy Applications
without this change we're always setting values for headers regardless of the fact whether they have already been set.
with this change we're only setting headers if there was no any previous value of the header

fixes #586
2017-05-27 02:58:58 +02:00
Marcin Grzejszczak
802fbb63a6 Added a NPE check for trace web aspect
without this change if there's no tracing an NPE is thrown in TraceWebAspect

fixes #596
2017-05-26 19:31:37 +02:00
Kamil Szymański
63c79033db Tracer#detach(Span) docs fix (#580) 2017-05-26 18:42:55 +02:00
Marcin Grzejszczak
91a8e51599 Bumping versions to 1.2.2.BUILD-SNAPSHOT after release 2017-05-23 00:13:03 +02:00
Marcin Grzejszczak
23f9c58116 Going back to snapshots 2017-05-23 00:13:02 +02:00
Marcin Grzejszczak
4f2139e6d6 Update SNAPSHOT to 1.2.1.RELEASE 2017-05-23 00:10:34 +02:00
Marcin Grzejszczak
61897b6965 Changed a single adjuster to a list of them
with this change we're injecting a list of adjusters instead of a single one. That way you don't have to create a composite version
of adjusters.

fixes #595
2017-05-22 17:38:42 +02:00
Marcin Grzejszczak
a5a898a06b Trying to fix flickering tests 2017-05-12 18:52:52 +02:00
Marcin Grzejszczak
ccbc2fa111 Merge branch '1.1.x' 2017-05-08 11:26:18 +02:00
Marcin Grzejszczak
9d84812de8 Added javadocs for SpanAccessor, fixes #587 2017-05-08 11:26:10 +02:00
Marcin Grzejszczak
4d6d2ebcc7 Merge branch '1.1.x' 2017-05-08 11:05:09 +02:00
Marcin Grzejszczak
11f8cd7f14 Fixed invalid constructor 2017-05-08 10:57:20 +02:00
Marcin Grzejszczak
5230626c5b Merge branch '1.1.x' 2017-05-08 10:51:43 +02:00
Marcin Grzejszczak
e7b192575c Added aspects around exception resolvers
without this change any update on a span in custom exception resolver where ignored cause the span got detached in TraceFilter instead of it getting closed
    with this change we're adding an error tag if it was missing and we're also marking the span for closure by TraceFilter

    fixes #585
2017-05-08 10:48:22 +02:00