Commit Graph

499 Commits

Author SHA1 Message Date
Marcin Grzejszczak
e7b192575c Added aspects around exception resolvers
without this change any update on a span in custom exception resolver where ignored cause the span got detached in TraceFilter instead of it getting closed
    with this change we're adding an error tag if it was missing and we're also marking the span for closure by TraceFilter

    fixes #585
2017-05-08 10:48:22 +02:00
Marcin Grzejszczak
2336355315 Bumping versions to 1.1.5.BUILD-SNAPSHOT after release 2017-05-05 12:50:01 +02:00
Marcin Grzejszczak
46130c4bb3 Going back to snapshots 2017-05-05 12:50:00 +02:00
Marcin Grzejszczak
be44013620 Update SNAPSHOT to 1.1.4.RELEASE 2017-05-05 12:47:18 +02:00
Marcin Grzejszczak
b95ecd5f7e Adds documentation and javadocs about SpanAdjuster and SpanReporter
fixes #570
2017-04-24 15:17:59 +02:00
Marcin Grzejszczak
115ace8bcc Made TraceFilter.ORDER public
fixes #569
2017-04-20 09:33:34 +02:00
Marcin Grzejszczak
165a6ac1ba Making post zuul filter close the span (#568)
without this change when dealing with Zuul, it's TraceFilter that is closing a span on an error
with this change, we're allowing the PostZuulFilter to close that span and TraceFilter doesn't interfere

fixes #563
2017-04-19 13:37:59 +02:00
Marcin Grzejszczak
64791deabd Span Adjuster (#567)
with this change, we're adding a possibility to fully customize the span before it gets reported to e.g. Zipkin

fixes #553
2017-04-19 10:35:48 +02:00
Marcin Grzejszczak
a879dc9e30 Added docs for customization executors 2017-04-18 16:20:24 +02:00
Marcin Grzejszczak
9dc626a873 Added docs for custom async rest template (#566)
fixes #564
2017-04-18 14:48:58 +02:00
Marcin Grzejszczak
46257ea370 Moved an executor aspect to a bean post processor
without this change when an executor implementation was a final class or had a final method - the application wouldn't start or would produce NPE at startup.
    with this change we have a custom bean post processor that wraps an aspect manualy either via a JDK Proxy when a class is final or a method is final or creates a CGLIB proxy if that's possible.

    fixes #550
2017-04-12 12:02:39 +02:00
Marcin Grzejszczak
cce5b18dec Wrapping callbacks in trace representation
without this change when user adds a callback then it's not wrapped in a trace representation, thus when executed in a separate thread, it's then missing all the tracing information
    with this change we're wrapping the future in our representation that passes the tracing information around

    fixes #546
2017-04-11 14:16:25 +02:00
Marcin Grzejszczak
e316e8bc3d Stopped producing warnings if the current span is null
fixes #552
2017-04-10 16:48:50 +02:00
Denis Stepanov
327ce80c38 Use HystrixFeign only if it's present on classpath (#544) 2017-03-22 10:43:56 +01:00
Marcin Grzejszczak
93afed967c Bumping versions after release 2017-03-10 11:18:18 +01:00
Marcin Grzejszczak
dde7d3b313 Going back to snapshots 2017-03-10 11:16:09 +01:00
Marcin Grzejszczak
1cab456015 Bumping versions before release 2017-03-10 11:10:23 +01:00
Marcin Grzejszczak
90713eba34 Added support for Feign + OkHttpClient + Sleuth
without this change we get exceptions related to not being able to extend a final class
with this change we're not wrapping any final types and we have a custom bean post processor for okhttp

fixes #513
2017-02-24 16:58:27 +01:00
Marcin Grzejszczak
e773ef4524 Limiting the span name size to 50 chars
without this exceptions can occur when the span name is big
with this we're truncating the name to 50 chars

fixes #530
2017-02-24 11:53:09 +01:00
Marcin Grzejszczak
c202f53a85 Showing a workaround to make message serializable
this issue is there in core of Spring Framework  (https://jira.spring.io/browse/SPR-15262) but this tests shows how to apply a workaround to get ridd of that problem until we bump up version of SF.

related to https://github.com/spring-cloud/spring-cloud-sleuth/issues/520 and https://github.com/spring-cloud/spring-cloud-sleuth/issues/523
SO - http://stackoverflow.com/questions/42277170/messagedeliveryexception-thrown-when-using-amqp-backed-channel-with-brixton-sr7

fixes #520
2017-02-23 15:56:29 +01:00
Marcin Grzejszczak
f8e6b00f35 Updated the version of the deprecated headers
fixes #519
2017-02-15 21:26:02 +01:00
Marcin Grzejszczak
694b929db3 Caches the result of getting error controller bean
related to #512
2017-02-13 11:24:44 +01:00
Marcin Grzejszczak
7f6dda7179 Lack of ErrorController will not result in blowing up the application
without this change when someone has a missing ErrorController bean then TraceHandlerInterceptor blows up
with this change that problem gets fixed

fixes #512
2017-02-13 10:45:59 +01:00
Marcin Grzejszczak
5930e15a9e Removing colour from the logging pattern\n\nwithout this change due to the presence of colours in the logging pattern, the logs could be corrupt in some cases\nwith this change we're removing the colour\n\nfixes #510 2017-02-07 17:34:45 +01:00
Marcin Grzejszczak
8f11bbe9f0 Going back to snapshots 2017-02-03 13:39:59 +01:00
Marcin Grzejszczak
ac0c209f94 Bumping versions before release 2017-02-03 13:30:35 +01:00
Arthur Gavlyukovskiy
3179637eb8 Display overriden service name in logs (addition to #487) (#507)
Use `spring.zipkin.service.name` if present.
2017-02-02 09:12:06 +01:00
Marcin Grzejszczak
abefcaa354 Removed duplicated dependency
fixes #504
2017-02-01 11:19:51 +01:00
Marcin Grzejszczak
4060c0b805 Fixing the moment when SS is set
without this change there's a problem with the time when the SS is set on a span. Currently it's done in TraceFilter's finally block. The problem is that this code is executed after the response has been sent back to the client. Thus CR sometimes was set faster than SS (it doesn't make any sense from the logical point of view).

with this change we're introducing wrappers over the HttpServletResponse where we annotate the span with SS just after the response gets sent to the recipient.

fixes #492 #431
2017-02-01 10:31:50 +01:00
Marcin Grzejszczak
5c117534aa Revert "Fixing the moment when SS is set (#505)"
This reverts commit 92bcae68f3.
2017-01-31 16:20:31 +01:00
Marcin Grzejszczak
92bcae68f3 Fixing the moment when SS is set (#505)
without this change there's a problem with the time when the SS is set on a span. Currently it's done in TraceFilter's finally block. The problem is that this code is executed after the response has been sent back to the client. Thus CR sometimes was set faster than SS (it doesn't make any sense from the logical point of view).

with this change we're introducing wrappers over the HttpServletResponse where we annotate the span with SS just after the response gets sent to the recipient.

fixes #492 #431
2017-01-31 15:57:22 +01:00
Marcin Grzejszczak
7151a9cdb3 Giving an option to reuse a custom feign client
without this change you couldn't register your own client (for example to set your ssl config) for Sleuth to reuse it
with this change we're reusing a registered feign client bean or creating a default one if necessary

fixes #502
2017-01-26 18:47:43 +01:00
Marcin Grzejszczak
e027d4cfb5 Making the branch 1.5.0 boot compatible
fixes #499
2017-01-23 12:37:55 +01:00
Marcin Grzejszczak
49e92443fb Going back to snapshots 2017-01-12 13:03:16 +01:00
Marcin Grzejszczak
7dd5a26802 Bumped versions before release 2017-01-12 12:28:53 +01:00
Marcin Grzejszczak
33173ebd05 Merge branch '1.0.x' into 1.1.x 2017-01-11 11:21:55 +01:00
Ryan Baxter
e2427b6a7e Merge pull request #446 from ryanjbaxter/disable-retry
Disable Feign Retry
2017-01-10 11:23:40 -05:00
Marcin Grzejszczak
863ba87f5f Going back to snapshots 2017-01-09 17:02:20 +01:00
Marcin Grzejszczak
e4546afd49 Bumping versions before release 2017-01-09 16:22:49 +01:00
Marcin Grzejszczak
2097acb486 Adding the spring.instance_id tag
without this tag it's impossible to discern from which server was the given span originated
    with this change we're adding a tag in which we're passing the instance id value. The value can be taken either from Cloud Foundry or from a concatanation of some local properties like instance_id / application name / application port etc.

    fixes #369
2017-01-03 14:21:32 +01:00
Marcin Grzejszczak
9d8b2a279f Adding the spring.instance_id tag
without this tag it's impossible to discern from which server was the given span originated
    with this change we're adding a tag in which we're passing the instance id value. The value can be taken either from Cloud Foundry or from a concatanation of some local properties like instance_id / application name / application port etc.

    fixes #369
2017-01-03 14:20:56 +01:00
Marcin Grzejszczak
9d60602115 Added test for non web apps, fixed the autoconfig in that case
without this change the non web apps can't start
    with this change the missing bean gets registered

    also in terms of non boot apps if there is no port or address set we're providing some default values. In terms of the service name one can always use the override via the spring.zipkin.service.name property

    fixes #32
2017-01-02 14:44:54 +01:00
Marcin Grzejszczak
f085aae3b6 Added test for non web apps, fixed the autoconfig in that case
without this change the non web apps can't start
    with this change the missing bean gets registered

    also in terms of non boot apps if there is no port or address set we're providing some default values. In terms of the service name one can always use the override via the spring.zipkin.service.name property

    fixes #32
2017-01-02 14:39:26 +01:00
Arthur Gavlyukovskiy
2a06734106 Created @ConfigurationProperties classes and updated additional metadata (#486)
* Created @ConfigurationProperties classes and updated additional metadata
2016-12-30 12:36:18 +01:00
Arthur Gavlyukovskiy
6aa7328cd9 Created @ConfigurationProperties classes and updated additional metadata (#486)
* Created @ConfigurationProperties classes and updated additional metadata
2016-12-30 12:35:46 +01:00
Marcin Grzejszczak
ab77e8ee74 Added checks to close / detach only if tracing
without this change during asynchronous communication some components are trying to detach or close spans that were aready detached. This leads to exceptions utils warnings and spans were not closed.
    with this change we're adding additional checks to ensure that we're tracing

    fixes #447
2016-12-30 11:36:16 +01:00
Marcin Grzejszczak
31531f4c84 Added checks to close / detach only if tracing
without this change during asynchronous communication some components are trying to detach or close spans that were aready detached. This leads to exceptions utils warnings and spans were not closed.
    with this change we're adding additional checks to ensure that we're tracing

    fixes #447
2016-12-30 11:35:55 +01:00
Marcin Grzejszczak
a88731fd9b Adding parent id to MDC
without this change we couldn't reference parent id in the logs
    with this change we add the parent id to MDC context

    fixes #480
2016-12-20 18:14:23 +01:00
Marcin Grzejszczak
b0533f7a60 Adding parent id to MDC
without this change we couldn't reference parent id in the logs
    with this change we add the parent id to MDC context

    fixes #480
2016-12-20 18:13:57 +01:00
Marcin Grzejszczak
bbc246bb53 Added a check for tracing in Trace Filter 2016-12-20 15:56:57 +01:00