SpringCloud/spring-cloud-stream
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Start/Stop lifecycle components after bind/unbinding

Browse Source 
- Explicit call is needed to start/stop the non-smart lifecycle components after bind/unbinding

Avoid recursive calls to applicationContext.start()
This commit is contained in:
Ilayaperumal Gopinathan
2015-09-03 13:01:22 -07:00
committed by Marius Bogoevici
parent b8ffa630f7
commit 28a23c90a0
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binding/ChannelBindingLifecycle.java
View File

@@ -17,6 +17,7 @@
package org.springframework.cloud.stream.binding;
import java.util.Map;
import java.util.concurrent.atomic.AtomicBoolean;
import org.springframework.beans.BeansException;
import org.springframework.context.ApplicationContext;
@@ -34,10 +35,10 @@ public class ChannelBindingLifecycle implements SmartLifecycle, ApplicationConte
private volatile boolean running = false;
private final Object lifecycleMonitor = new Object();
private ConfigurableApplicationContext applicationContext;
private final AtomicBoolean active = new AtomicBoolean(false);
@Override
public void setApplicationContext(ApplicationContext applicationContext)
throws BeansException {
@@ -47,8 +48,8 @@ public class ChannelBindingLifecycle implements SmartLifecycle, ApplicationConte
@Override
public void start() {
if (!running) {
synchronized (lifecycleMonitor) {
if (!running) {
if (!this.active.get()) {
if (this.active.compareAndSet(false, true)) {
// retrieve the ChannelBindingService lazily, avoiding early initialization
try {
ChannelBindingService channelBindingService = this.applicationContext.getBean(ChannelBindingService.class);
@@ -59,10 +60,13 @@ public class ChannelBindingLifecycle implements SmartLifecycle, ApplicationConte
for (Bindable bindable : bindables.values()) {
bindable.bindInputs(channelBindingService);
}
} catch (BeansException e) {
throw new IllegalStateException("Cannot perform binding, no proper implementation found",e);
}
catch (BeansException e) {
throw new IllegalStateException("Cannot perform binding, no proper implementation found", e);
}
this.running = true;
this.applicationContext.start();
this.active.set(false);
}
}
}
@@ -71,8 +75,8 @@ public class ChannelBindingLifecycle implements SmartLifecycle, ApplicationConte
@Override
public void stop() {
if (running) {
synchronized (lifecycleMonitor) {
if (running) {
if (!this.active.get()) {
if (this.active.compareAndSet(false, true)) {
try {
// retrieve the ChannelBindingService lazily, avoiding early initialization
ChannelBindingService channelBindingService = this.applicationContext.getBean(ChannelBindingService.class);
@@ -83,9 +87,12 @@ public class ChannelBindingLifecycle implements SmartLifecycle, ApplicationConte
for (Bindable bindable : bindables.values()) {
bindable.unbindOutputs(channelBindingService);
}
} catch (BeansException e) {
throw new IllegalStateException("Cannot perform binding, no proper implementation found",e);
}
catch (BeansException e) {
throw new IllegalStateException("Cannot perform binding, no proper implementation found", e);
}
this.applicationContext.stop();
this.active.set(false);
this.running = false;
}
}