SpringCloud/spring-cloud-stream
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-2355 Add tests for KafkaNull batching suport

Browse Source 
This commit also has some checksyle fixes due to s-c-build changes
Inspired by suggestion from https://github.com/spring-cloud/spring-cloud-stream/pull/2422 by @sbernardo

Resolves #2355
This commit is contained in:
Oleg Zhurakousky
2022-06-08 20:06:06 +02:00
parent 806a6500b5
commit 723eadb67f
4 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/spring-cloud-stream/src/test/java/org/springframework/cloud/stream/binder/test/FunctionBindingTestUtils.java
View File

@@ -42,7 +42,11 @@ import org.springframework.messaging.MessageChannel;
* @since 3.0.2
*
*/
public class FunctionBindingTestUtils {
public final class FunctionBindingTestUtils {
private FunctionBindingTestUtils() {
}
@SuppressWarnings("rawtypes")
public static void bind(ConfigurableApplicationContext applicationContext, Object function) {

3
core/spring-cloud-stream/src/test/java/org/springframework/cloud/stream/binder/test/TestChannelBinderConfiguration.java
View File

@@ -48,6 +48,9 @@ import org.springframework.integration.config.EnableIntegration;
@EnableIntegration
public class TestChannelBinderConfiguration<T> {
/**
* The name of the test binder.
*/
public static final String NAME = "integration";
/**

15
core/spring-cloud-stream/src/test/java/org/springframework/cloud/stream/function/FunctionBatchingTests.java
View File

@@ -29,6 +29,7 @@ import org.springframework.cloud.stream.binder.test.OutputDestination;
import org.springframework.cloud.stream.binder.test.TestChannelBinderConfiguration;
import org.springframework.context.annotation.Bean;
import org.springframework.integration.support.MessageBuilder;
import org.springframework.kafka.support.KafkaNull;
import org.springframework.messaging.Message;
import static org.assertj.core.api.Assertions.assertThat;
@@ -44,7 +45,7 @@ import static org.assertj.core.api.Assertions.assertThat;
public class FunctionBatchingTests {
@Test
void testMessageBatchConfiguration() {
void testMessageBatchConfigurationWithKafkaNull() {
TestChannelBinderConfiguration.applicationContextRunner(MessageBatchConfiguration.class)
.withPropertyValues("spring.jmx.enabled=false",
"spring.cloud.stream.function.definition=func",
@@ -54,10 +55,12 @@ public class FunctionBatchingTests {
OutputDestination outputDestination = context
.getBean(OutputDestination.class);
List<byte[]> list = new ArrayList<>();
List<Object> list = new ArrayList<>();
list.add("{\"name\":\"bob\"}".getBytes());
list.add("{\"name\":\"jill\"}".getBytes());
Message<List<byte[]>> inputMessage = MessageBuilder
list.add(KafkaNull.INSTANCE);
list.add("{\"name\":\"steve\"}".getBytes());
Message<List<Object>> inputMessage = MessageBuilder
.withPayload(list)
.build();
inputDestination.send(inputMessage);
@@ -282,7 +285,11 @@ public class FunctionBatchingTests {
@Bean
public Function<Message<List<Person>>, Person> func() {
return x -> x.getPayload().get(0);
return x -> {
Object o = x.getPayload().get(2);
assertThat(o).isInstanceOf(KafkaNull.class);
return (Person) x.getPayload().get(0);
};
}
public static class Person {

1
core/spring-cloud-stream/src/test/java/org/springframework/cloud/stream/function/ImplicitFunctionBindingTests.java
View File

@@ -1428,7 +1428,6 @@ public class ImplicitFunctionBindingTests {
@Bean
public Function<Message<List<Map<String, String>>>, Message<List<Map<String, String>>>> funcB() {
return v -> {
System.out.println(v);
return v;
};
}