SpringCloud/spring-cloud-stream
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix RabbitExchangeQueueProvisioner Inner Classes

Browse Source 
- make destination inner classes `static` since they have no dependence on the outer class
- make ctors package-protected - private ctors for inner classes cause the compiler to
  generate a synthetic ctor with an additional synthetic parameter
This commit is contained in:
Gary Russell
2017-02-17 21:07:06 -05:00
parent 18e33ea58d
commit b259cb380f
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spring-cloud-stream-binder-rabbit-core/src/main/java/org/springframework/cloud/stream/binder/rabbit/provisioning/RabbitExchangeQueueProvisioner.java
View File

@@ -53,6 +53,7 @@ import org.springframework.util.StringUtils;
* AMQP implementation for {@link ProvisioningProvider}
*
* @author Soby Chacko
* @author Gary Russell
*/
public class RabbitExchangeQueueProvisioner implements ProvisioningProvider<ExtendedConsumerProperties<RabbitConsumerProperties>,
ExtendedProducerProperties<RabbitProducerProperties>> {
@@ -453,12 +454,13 @@ public class RabbitExchangeQueueProvisioner implements ProvisioningProvider<Exte
}
}
private final class RabbitProducerDestination implements ProducerDestination {
private static final class RabbitProducerDestination implements ProducerDestination {
private final Exchange exchange;
private final Binding binding;
private RabbitProducerDestination(Exchange exchange, Binding binding) {
RabbitProducerDestination(Exchange exchange, Binding binding) {
Assert.notNull(exchange, "exchange must not be null");
this.exchange = exchange;
this.binding = binding;
@@ -483,12 +485,12 @@ public class RabbitExchangeQueueProvisioner implements ProvisioningProvider<Exte
}
}
private final class RabbitConsumerDestination implements ConsumerDestination {
private static final class RabbitConsumerDestination implements ConsumerDestination {
private final Queue queue;
private final Binding binding;
private RabbitConsumerDestination(Queue queue, Binding binding) {
RabbitConsumerDestination(Queue queue, Binding binding) {
Assert.notNull(queue, "queue must not be null");
this.queue = queue;
this.binding = binding;
@@ -507,4 +509,5 @@ public class RabbitExchangeQueueProvisioner implements ProvisioningProvider<Exte
return this.queue.getName();
}
}
}