Commit Graph

3536 Commits

Author SHA1 Message Date
Sean Doyle
862b2003ab StreamBridge resolveDestination considers binderName in cache hit 2022-06-07 15:01:28 +02:00
Soby Chacko
6dd6774280 Producer config customization and DLQ issues
When DLQ is enabled on a consumer binding, the internal producer properties
used by the DLQ mechanism to send to the topic is not populated with the
correct binding name. In the previous version, it was working fine since
we were relying on a ThreadLocal. This is revamped recently to properly
introduce a binding name as a top level property in ProducerProperties.
However, this was not set on the internal producer properties used by the
DLQ. This PR addresses this issue.

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2417
Resolves #2418
2022-06-07 14:29:46 +02:00
Oleg Zhurakousky
cc19c9f31c Fix ErrorBindingTests 2022-06-07 13:17:34 +02:00
Oleg Zhurakousky
1e141336a8 Fix ErrorBindingTests 2022-06-07 12:23:49 +02:00
Soby Chacko
ce6a03ee59 Kafk Streams binder message conversion issues
When native decoding is disabled and message conversion
is used  in Kafka Streams binder, it doesn't currently
carry the original headers forward. Fixing this issue.

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2411
2022-06-06 19:19:14 -04:00
ferblaca
ae0332b7d4 add the topic name information to the binder exception if a problem occurs in the provisioning phase 2022-06-06 10:46:03 -04:00
Oleg Zhurakousky
cf0dd1bfa3 GH-2374 Add initial support for function-based error handling
Resolves #2374
2022-06-02 15:04:20 +02:00
Tomek Szmytka
0bf50cbf85 Clean up resources on close. Allow cleanly terminating application process on context shutdown
Prevent IDE from using star imports

Update authors

Checkstyle fixes
2022-06-01 17:12:48 -04:00
amseager
90e5d5ee8d add missing backoff multiplier 2022-05-31 15:24:19 -04:00
Soby Chacko
605a1b1eda Update kafka client versions
3.2.0
2022-05-31 15:12:03 -04:00
Chris Bono
9f8dc3eded Fix compile error in LocalstackContainerTest
* Improve docker reuse in `LocalstackContainerTest`
2022-05-24 12:05:17 -04:00
Chris Bono
317db6094a Migrate stream-bridge-avro sample app 2022-05-19 10:46:31 -04:00
Soby Chacko
231d62ee46 Merge branch 'main' of github.com:spring-cloud/spring-cloud-stream into main 2022-05-17 16:43:24 -04:00
Soby Chacko
20f738b1e9 StreamBridge binder name related changes
An internal helper method used by StreamBridge for resolving the
binder target type to attach the target binder protocol, does not
take into account the binder name when resolving the binder configuration.
Fixing this issue.

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2379
Resolves #2401
2022-05-17 19:27:22 +02:00
Soby Chacko
562e1b27ba StreamBridge binder name related changes
An internal helper method used by StreamBridge for resolving the
binder target type to attach the target binder protocol, does not
take into account the binder name when resolving the binder configuration.
Fixing this issue.

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2379
2022-05-16 15:47:46 -04:00
Chris Bono
b8a5c1d3af Make confluent-schema-registry-integration sample poms consistent (#2398)
* Make confluent-schema-registry-integration sample poms consistent

* Update <description> w/ "Confluent" prefix

* Put spring-cloud-dependencies back to 2022.0.0-SNAPSHOT (I got confused w 2021 for a minute)

* Pull deps up to base pom.xml
2022-05-16 14:56:24 -04:00
Chris Bono
424774c647 Polish kafka-native-serialization sample 2022-05-16 10:11:21 -04:00
Soby Chacko
ecc1b60b14 Migrating Kafka native serialization sample 2022-05-16 10:11:21 -04:00
Gary Russell
fd3ef3e849 GH-2297: Polish Concurrency Test 2022-05-16 09:23:10 -04:00
Chris Bono
cc05160cc0 Cleanup SerdeResolverUtils
* Refactor SerdeResolverUtils logic
* Add more tests in SerdeResolverUtilsTests
* Fixed some random test warnings

Fixes #2370

Code review feedback: remove FQ ref to inner method

Fix checkstyles
2022-05-13 15:20:47 -04:00
Gary Russell
bf810fbd53 GH-2297: Concurrency in Reactor Kafka Binder (#2396)
* GH-2297: Concurrency in Reactor Kafka Binder

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2297

* Remove unnecessary local var.

* Remove subscription cancellation; already handled by the super class.
2022-05-12 16:00:44 -04:00
Gary Russell
e522450f8e GH-2298: Refactor Common Binder Code to Core
Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2298

Polishing per review comments; javadocs.
2022-05-12 12:14:47 -04:00
Soby Chacko
7657f7b7a3 Refactoring Confluent Schema Registry sample 2022-05-11 16:03:20 -04:00
Soby Chacko
dae959999a Binding name as a consumer/producer property
Make binding names available through Consumer/Producer properties.
Currently, the binders use a ThreadLocal to store the binding name for internal use.
These changes introduce the binding name as a property for both producer/consumer bindings.

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2380
2022-05-10 17:22:51 -04:00
Soby Chacko
112a93c5f0 Address KafkaHeader constant name changes 2022-05-09 17:04:32 -04:00
Chris Bono
6731f681b4 Merge pull request #2378 from onobc/gh2376-avro-samples-cleanup
Fixes #2376
2022-05-06 14:04:13 -05:00
Chris Bono
807b71d726 Cleanup Confluent schema registry sample code
* Use best practices
* Use SL4J
* Tidy formatting
2022-05-06 14:02:31 -05:00
Chris Bono
835d70b4a7 Cleanup Confluent schema registry sample docs/pom
* Update README (it does what it says it does)
* Restructure pom hierarchy and factor out commonality
2022-05-06 14:02:31 -05:00
Chris Bono
d8f499f4d9 Add docker compose for Kafka cluster 2022-05-06 10:02:47 -04:00
Soby Chacko
4089c46fff Migrating samples (#2375)
* Migrating samples

Confluent Schema Registry integration sample

* Addressing PR review comments
2022-05-05 15:24:26 -04:00
Soby Chacko
190b5f1fc4 Kafka binder docs cleanup
SeekToCurrentBatchErrorHandler is deprecated.
Removing docs references for this with the new DefaultErrorHandler.

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2369
2022-05-04 10:56:13 -04:00
Artem Bilan
d8fd4c2aab GH-2359: Enable other KCL initial offsets
Fixes https://github.com/spring-cloud/spring-cloud-stream/issues/2359

The KCL mode does not apply at the moment `AT_TIMESTAMP` and `TRIM_HORIZON` initial offsets

Resolves #2365
* Change the `KinesisMessageChannelBinder` binder logic to create an explicit
`KinesisClientLibConfiguration` based on the provided properties including
custom stream iterator type
* Adjust `KinesisTestBinder` to be able to create a KCL/KPL based bindings
2022-05-04 15:34:16 +02:00
Chris Bono
210eb7e9f5 Consider generics when resolving Serdes for KafkaStreams binder
Fixes #2318
2022-05-03 11:45:20 -04:00
Chris Bono
37abca427d Remove Kafka binder dependence on KafkaAutoConfiguration
Fixes #2349

Use single instance of EmbeddedKafka for KafkaBinderBootstrapTest
2022-05-03 10:45:51 -04:00
Artem Bilan
3b32bea133 Fix Poller Config for ambiguity
Related to https://stackoverflow.com/questions/72023445/spring-cloud-stream-mutually-exclusive-property-issue

The `PollerConfigEnvironmentPostProcessor` has a flaw not checking user-provided properties
and does not check for mutually exclusive before setting default

* Fix `PollerConfigEnvironmentPostProcessor` to check for other mutual poller
properties before setting default for `fixed-delay`
* Same for `max-messages-per-poll`
* Verify that fix is working in the `PollableSourceTests` where poller
options make sense in the Spring Cloud Stream scenario

* Fix `PollerConfigEnvironmentPostProcessor` for redundant check
* Add more tests into `PollableSourceTests` to verify different
poller properties and their exclusive mutuality
2022-05-02 16:02:56 -04:00
Artem Bilan
53e6e1a85c Migrate Kinesis binder docs to the common place 2022-05-02 15:36:02 -04:00
Oleg Zhurakousky
818553179a fixing docs
polish
2022-05-02 20:20:49 +02:00
buildmaster
4bfab90f61 Bumping versions 2022-04-27 17:37:53 +00:00
Oleg Zhurakousky
77ee8ef1d3 GH-SCF_856 Fix propper Cloud Event header prefix in StreamBridge 2022-04-26 09:27:18 +02:00
Oleg Zhurakousky
c22651a3b0 GH-2360 Fix trimmimg in multiple function definition
remove leftovers from spring.cloud.streamfunction.definition

Resolves #2360
2022-04-22 15:32:28 +02:00
Oleg Zhurakousky
51cdcc7c37 GH-2340 Fix CCE in extended properties
Upgrade jackson core

Resolves #2340
2022-04-22 15:11:22 +02:00
dependabot[bot]
f272c47e93 Bump jackson-databind from 2.10.0 to 2.12.6.1
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.0 to 2.12.6.1.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-22 12:16:16 +02:00
Chris Bono
3de0ed44e2 Use testcontainers for Rabbit binder integration tests
Fixes #2341

Resolves #2358
2022-04-22 12:15:10 +02:00
Lars Bilger
7d3a846590 KafkaBinderMetrics Improvements
- Calculate Kafka lag metric correctly even if there are no committed offsets for the group
 - Update authors and copyright years
 - Checkstyle fixes
2022-04-20 11:16:18 -04:00
buildmaster
53604e703a Bumping versions 2022-04-16 17:25:40 +00:00
ben-enfuse-io
e983366b8b Change compression level to Integer and only set if not null.
Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2328
2022-04-14 10:53:55 -04:00
ben-enfuse-io
a3b9c2f68d Change initialQuorumSize to initialGroupSize in docs.
Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2329
2022-04-13 18:07:57 -04:00
matthieu.dupuy
8682417af4 Add setter for Container Customizer
Add setter for Container Customizer on AbstractMessageChannelBinder.

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2345
2022-04-08 10:00:21 -04:00
Sid Sam
ad89acf62d Update documentation for ListenerContainerWithDlqAndRetryCustomizer
Based on suggestions in https://github.com/spring-cloud/spring-cloud-stream/issues/2313. Hope the edit helps.
2022-04-04 10:14:43 -04:00
buildmaster
5408935158 Bumping versions 2022-04-02 17:31:25 +00:00