SpringCloud/spring-cloud-task
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Closed an observation left open in TaskListener task

Browse Source 
This caused observation tests to fail after test reshuffling.
This commit is contained in:
Glenn Renfro
2023-07-05 15:05:22 -04:00
parent e72c730cbc
commit 05b553dbde
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-cloud-task-core/src/test/java/org/springframework/cloud/task/listener/TaskLifecycleListenerTests.java
View File

@@ -24,6 +24,9 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
import io.micrometer.observation.Observation;
import io.micrometer.observation.ObservationRegistry;
import io.micrometer.observation.tck.TestObservationRegistry;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
@@ -86,6 +89,12 @@ public class TaskLifecycleListenerTests {
if (this.context != null && this.context.isActive()) {
this.context.close();
}
ObservationRegistry observationRegistry = TestObservationRegistry.create();
if (observationRegistry.getCurrentObservationScope() != null) {
Observation.Scope scope = observationRegistry.getCurrentObservationScope();
scope.close();
scope.getCurrentObservation().stop();
}
}
@Test
@@ -183,6 +192,7 @@ public class TaskLifecycleListenerTests {
@Test
public void testRestartExistingTask(CapturedOutput capturedOutput) {
this.context.refresh();
TaskLifecycleListener taskLifecycleListener = this.context.getBean(TaskLifecycleListener.class);
taskLifecycleListener.start();
String output = capturedOutput.toString();