Use Locale.ROOT for Strings upper and lower case instead of default

This commit is contained in:
Glenn Renfro
2024-10-17 07:28:31 -04:00
parent e82a8024a6
commit cb903ec501
4 changed files with 9 additions and 4 deletions

View File

@@ -26,6 +26,7 @@ import java.util.Collections;
import java.util.HashSet;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Set;
import java.util.TreeSet;
@@ -527,7 +528,7 @@ public class JdbcTaskExecutionDao implements TaskExecutionDao {
if (sort != null) {
for (Sort.Order sortOrder : sort) {
if (validSortColumns.contains(sortOrder.getProperty().toUpperCase())) {
if (validSortColumns.contains(sortOrder.getProperty().toUpperCase(Locale.ROOT))) {
sortOrderMap.put(sortOrder.getProperty(),
sortOrder.isAscending() ? Order.ASCENDING : Order.DESCENDING);
}

View File

@@ -19,6 +19,7 @@ package org.springframework.cloud.task.repository.database.support;
import java.util.ArrayList;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import javax.sql.DataSource;
@@ -157,7 +158,7 @@ public abstract class AbstractSqlPagingQueryProvider implements PagingQueryProvi
private String removeKeyWord(String keyWord, String clause) {
String temp = clause.trim();
String keyWordString = keyWord + " ";
if (temp.toLowerCase().startsWith(keyWordString) && temp.length() > keyWordString.length()) {
if (temp.toLowerCase(Locale.ROOT).startsWith(keyWordString) && temp.length() > keyWordString.length()) {
return temp.substring(keyWordString.length());
}
else {

View File

@@ -17,6 +17,7 @@
package org.springframework.cloud.task.repository.database.support;
import java.util.HashMap;
import java.util.Locale;
import java.util.Map;
import javax.sql.DataSource;
@@ -135,7 +136,7 @@ public class SqlPagingQueryProviderFactoryBean implements FactoryBean<PagingQuer
DatabaseType type;
try {
type = this.databaseType != null ? DatabaseType.valueOf(this.databaseType.toUpperCase())
type = this.databaseType != null ? DatabaseType.valueOf(this.databaseType.toUpperCase(Locale.ROOT))
: DatabaseType.fromMetaData(this.dataSource);
}
catch (MetaDataAccessException e) {

View File

@@ -17,6 +17,7 @@
package org.springframework.cloud.task.repository.support;
import java.sql.SQLException;
import java.util.Locale;
import javax.sql.DataSource;
@@ -84,7 +85,8 @@ public final class TaskRepositoryInitializer implements InitializingBean {
private String getDatabaseType(DataSource dataSource) {
try {
return JdbcUtils.commonDatabaseName(DatabaseType.fromMetaData(dataSource).toString()).toLowerCase();
return JdbcUtils.commonDatabaseName(DatabaseType.fromMetaData(dataSource).toString())
.toLowerCase(Locale.ROOT);
}
catch (MetaDataAccessException ex) {
throw new IllegalStateException("Unable to detect database type", ex);