SpringCloud/stream-applications
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Apps Plugin] Allow bad enum constants (take 2) (#546)

Browse Source 
Improving on the previous commit, this adds a set of expected
problematic enum classes and only continues processing when an enum
is unable to load if the enum is in the list.
This commit is contained in:
Chris Bono
2024-06-02 19:56:59 -05:00
committed by GitHub
parent e7ece244a4
commit 5ef97cc996
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spring-cloud-dataflow-apps-plugin/spring-cloud-dataflow-apps-metadata-plugin/src/main/java/org/springframework/cloud/dataflow/app/plugin/MetadataAggregationMojo.java
View File

@@ -34,10 +34,12 @@ import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Properties;
import java.util.Set;
import java.util.jar.JarOutputStream;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;
@@ -108,6 +110,11 @@ public class MetadataAggregationMojo extends AbstractMojo {
static final String SPRING_CLOUD_DATAFLOW_OPTION_GROUPS_PROPERTIES = "dataflow-configuration-option-groups.properties";
private static final Set<String> KNOWN_PROBLEMATIC_ENUMS = new HashSet<>();
static {
KNOWN_PROBLEMATIC_ENUMS.add("org.springframework.boot.autoconfigure.data.jdbc.JdbcDatabaseDialect");
}
@Parameter(defaultValue = "${project}")
private MavenProject mavenProject;
@@ -527,8 +534,13 @@ public class MetadataAggregationMojo extends AbstractMojo {
enumConstants = clazz.getEnumConstants();
}
catch (NoClassDefFoundError ex) {
getLog().error("Failed to resolve enum constants for property = " + property + " and class = " + clazz, ex);
continue;
String enumClass = clazz.getName();
if (KNOWN_PROBLEMATIC_ENUMS.contains(enumClass)) {
getLog().info("[EXPECTED] Failed to resolve enum constants for property = " + property + " and class = " + clazz);
continue;
}
getLog().error("[UNEXPECTED] Failed to resolve enum constants for property = " + property + " and class = " + clazz, ex);
throw ex;
}
for (Object enumConstant : enumConstants) {
valueHints.add(new ValueHint(enumConstant, null));