Commit 076a384c authored by Andy Wilkinson's avatar Andy Wilkinson

Merge branch '2.2.x'

Closes gh-21112
parents d5b94414 29dc236b
...@@ -17,8 +17,12 @@ ...@@ -17,8 +17,12 @@
package org.springframework.boot.gradle.tasks.bundling; package org.springframework.boot.gradle.tasks.bundling;
import java.io.File; import java.io.File;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashSet;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
import java.util.Map; import java.util.Map;
import java.util.Set;
import org.gradle.api.artifacts.ArtifactCollection; import org.gradle.api.artifacts.ArtifactCollection;
import org.gradle.api.artifacts.Configuration; import org.gradle.api.artifacts.Configuration;
...@@ -92,6 +96,10 @@ class LayerResolver { ...@@ -92,6 +96,10 @@ class LayerResolver {
*/ */
private static class ResolvedDependencies { private static class ResolvedDependencies {
private static final Set<String> DEPRECATED_FOR_RESOLUTION_CONFIGURATIONS = Collections
.unmodifiableSet(new HashSet<>(Arrays.asList("archives", "compile", "compileOnly", "default", "runtime",
"testCompile", "testCompileOnly", "testRuntime")));
private final Map<Configuration, ResolvedConfigurationDependencies> configurationDependencies = new LinkedHashMap<>(); private final Map<Configuration, ResolvedConfigurationDependencies> configurationDependencies = new LinkedHashMap<>();
ResolvedDependencies(Iterable<Configuration> configurations) { ResolvedDependencies(Iterable<Configuration> configurations) {
...@@ -99,7 +107,8 @@ class LayerResolver { ...@@ -99,7 +107,8 @@ class LayerResolver {
} }
private void processConfiguration(Configuration configuration) { private void processConfiguration(Configuration configuration) {
if (configuration.isCanBeResolved()) { if (configuration.isCanBeResolved()
&& !DEPRECATED_FOR_RESOLUTION_CONFIGURATIONS.contains(configuration.getName())) {
this.configurationDependencies.put(configuration, this.configurationDependencies.put(configuration,
new ResolvedConfigurationDependencies(configuration.getIncoming().getArtifacts())); new ResolvedConfigurationDependencies(configuration.getIncoming().getArtifacts()));
} }
......
...@@ -39,8 +39,9 @@ class PublishingDocumentationTests { ...@@ -39,8 +39,9 @@ class PublishingDocumentationTests {
@TestTemplate @TestTemplate
void mavenUpload() throws IOException { void mavenUpload() throws IOException {
assertThat(this.gradleBuild.script("src/docs/gradle/publishing/maven").build("deployerRepository").getOutput()) assertThat(this.gradleBuild.expectDeprecationWarningsWithAtLeastVersion("5.6")
.contains("https://repo.example.com"); .script("src/docs/gradle/publishing/maven").build("deployerRepository").getOutput())
.contains("https://repo.example.com");
} }
@TestTemplate @TestTemplate
......
...@@ -89,7 +89,7 @@ public class GradleBuild { ...@@ -89,7 +89,7 @@ public class GradleBuild {
} }
void after() { void after() {
GradleBuild.this.script = null; this.script = null;
FileSystemUtils.deleteRecursively(this.projectDir); FileSystemUtils.deleteRecursively(this.projectDir);
} }
...@@ -127,8 +127,8 @@ public class GradleBuild { ...@@ -127,8 +127,8 @@ public class GradleBuild {
public BuildResult build(String... arguments) { public BuildResult build(String... arguments) {
try { try {
BuildResult result = prepareRunner(arguments).build(); BuildResult result = prepareRunner(arguments).build();
if (this.gradleVersion != null && this.expectDeprecationWarnings != null if (this.expectDeprecationWarnings == null || (this.gradleVersion != null
&& this.expectDeprecationWarnings.compareTo(GradleVersion.version(this.gradleVersion)) > 0) { && this.expectDeprecationWarnings.compareTo(GradleVersion.version(this.gradleVersion)) > 0)) {
assertThat(result.getOutput()).doesNotContain("Deprecated").doesNotContain("deprecated"); assertThat(result.getOutput()).doesNotContain("Deprecated").doesNotContain("deprecated");
} }
return result; return result;
...@@ -167,6 +167,8 @@ public class GradleBuild { ...@@ -167,6 +167,8 @@ public class GradleBuild {
allArguments.add("-PbootVersion=" + getBootVersion()); allArguments.add("-PbootVersion=" + getBootVersion());
allArguments.add("--stacktrace"); allArguments.add("--stacktrace");
allArguments.addAll(Arrays.asList(arguments)); allArguments.addAll(Arrays.asList(arguments));
allArguments.add("--warning-mode");
allArguments.add("all");
return gradleRunner.withArguments(allArguments); return gradleRunner.withArguments(allArguments);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment