Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
08b9d1da
Commit
08b9d1da
authored
Nov 11, 2020
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Polish "Ensure that MeterRegistry bean is defined before SI looks for it"
See gh-24095
parent
7d712aaa
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
19 deletions
+9
-19
IntegrationMetricsAutoConfiguration.java
...rics/integration/IntegrationMetricsAutoConfiguration.java
+1
-2
spring.factories
...utoconfigure/src/main/resources/META-INF/spring.factories
+1
-1
IntegrationMetricsAutoConfigurationTests.java
...integration/IntegrationMetricsAutoConfigurationTests.java
+7
-16
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/integration/IntegrationMetricsAutoConfiguration.java
View file @
08b9d1da
...
...
@@ -33,11 +33,10 @@ import org.springframework.context.annotation.Configuration;
* for it.
*
* @author Andy Wilkinson
* @since 2.3.6
*/
@AutoConfigureAfter
({
MetricsAutoConfiguration
.
class
,
CompositeMeterRegistryAutoConfiguration
.
class
})
@AutoConfigureBefore
(
IntegrationAutoConfiguration
.
class
)
@Configuration
(
proxyBeanMethods
=
false
)
public
class
IntegrationMetricsAutoConfiguration
{
class
IntegrationMetricsAutoConfiguration
{
}
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/resources/META-INF/spring.factories
View file @
08b9d1da
...
...
@@ -65,8 +65,8 @@ org.springframework.boot.actuate.autoconfigure.metrics.export.signalfx.SignalFxM
org.springframework.boot.actuate.autoconfigure.metrics.export.simple.SimpleMetricsExportAutoConfiguration,\
org.springframework.boot.actuate.autoconfigure.metrics.export.statsd.StatsdMetricsExportAutoConfiguration,\
org.springframework.boot.actuate.autoconfigure.metrics.export.wavefront.WavefrontMetricsExportAutoConfiguration,\
org.springframework.boot.actuate.autoconfigure.metrics.jdbc.DataSourcePoolMetricsAutoConfiguration,\
org.springframework.boot.actuate.autoconfigure.metrics.integration.IntegrationMetricsAutoConfiguration,\
org.springframework.boot.actuate.autoconfigure.metrics.jdbc.DataSourcePoolMetricsAutoConfiguration,\
org.springframework.boot.actuate.autoconfigure.metrics.jersey.JerseyServerMetricsAutoConfiguration,\
org.springframework.boot.actuate.autoconfigure.metrics.orm.jpa.HibernateMetricsAutoConfiguration,\
org.springframework.boot.actuate.autoconfigure.metrics.web.client.HttpClientMetricsAutoConfiguration,\
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/integration/IntegrationMetricsAutoConfigurationTests.java
View file @
08b9d1da
...
...
@@ -16,7 +16,8 @@
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
.
metrics
.
integration
;
import
io.micrometer.core.instrument.Gauge
;
import
io.micrometer.core.instrument.MeterRegistry
;
import
org.junit.jupiter.api.Test
;
import
org.springframework.boot.actuate.autoconfigure.integration.IntegrationGraphEndpointAutoConfiguration
;
...
...
@@ -26,35 +27,25 @@ import org.springframework.boot.autoconfigure.AutoConfigurations;
import
org.springframework.boot.autoconfigure.integration.IntegrationAutoConfiguration
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
io.micrometer.core.instrument.Gauge
;
import
io.micrometer.core.instrument.MeterRegistry
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
/**
* Tests for {@link RabbitMetricsAutoConfiguration}.
*
* @author Artem Bilan
* @since 2.3.6
*/
class
IntegrationMetricsAutoConfigurationTests
{
private
final
ApplicationContextRunner
contextRunner
=
new
ApplicationContextRunner
()
.
withConfiguration
(
AutoConfigurations
.
of
(
IntegrationAutoConfiguration
.
class
,
IntegrationGraphEndpointAutoConfiguration
.
class
))
.
with
(
MetricsRun
.
simple
())
.
withPropertyValues
(
"management.metrics.tags.someTag=someValue"
);
private
final
ApplicationContextRunner
contextRunner
=
new
ApplicationContextRunner
()
.
withConfiguration
(
AutoConfigurations
.
of
(
IntegrationAutoConfiguration
.
class
,
IntegrationGraphEndpointAutoConfiguration
.
class
,
IntegrationMetricsAutoConfiguration
.
class
))
.
with
(
MetricsRun
.
simple
()).
withPropertyValues
(
"management.metrics.tags.someTag=someValue"
);
@Test
void
integrationMetersAreInstrumented
()
{
this
.
contextRunner
.
run
((
context
)
->
{
MeterRegistry
registry
=
context
.
getBean
(
MeterRegistry
.
class
);
Gauge
gauge
=
registry
.
get
(
"spring.integration.channels"
)
.
tag
(
"someTag"
,
"someValue"
)
.
gauge
();
Gauge
gauge
=
registry
.
get
(
"spring.integration.channels"
).
tag
(
"someTag"
,
"someValue"
).
gauge
();
assertThat
(
gauge
).
isNotNull
().
extracting
(
Gauge:
:
value
).
isEqualTo
(
2.0
);
});
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment