Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
0aa3b00f
Commit
0aa3b00f
authored
Feb 20, 2014
by
Dave Syer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Ensure shutdown endpoint is disabled by default
Fixes gh-377
parent
c5d8150f
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
76 additions
and
1 deletion
+76
-1
EndpointMvcAdapter.java
...amework/boot/actuate/endpoint/mvc/EndpointMvcAdapter.java
+14
-0
MvcEndpoints.java
...ringframework/boot/actuate/endpoint/mvc/MvcEndpoints.java
+1
-1
ShutdownMvcEndpoint.java
...mework/boot/actuate/endpoint/mvc/ShutdownMvcEndpoint.java
+9
-0
ShutdownMvcEndpointTests.java
...k/boot/actuate/endpoint/mvc/ShutdownMvcEndpointTests.java
+52
-0
No files found.
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/mvc/EndpointMvcAdapter.java
View file @
0aa3b00f
...
...
@@ -16,7 +16,12 @@
package
org
.
springframework
.
boot
.
actuate
.
endpoint
.
mvc
;
import
java.util.Collections
;
import
java.util.Map
;
import
org.springframework.boot.actuate.endpoint.Endpoint
;
import
org.springframework.http.HttpStatus
;
import
org.springframework.http.ResponseEntity
;
import
org.springframework.util.Assert
;
import
org.springframework.web.bind.annotation.RequestMapping
;
import
org.springframework.web.bind.annotation.RequestMethod
;
...
...
@@ -43,9 +48,18 @@ public class EndpointMvcAdapter implements MvcEndpoint {
@RequestMapping
(
method
=
RequestMethod
.
GET
)
@ResponseBody
public
Object
invoke
()
{
if
(!
this
.
delegate
.
isEnabled
())
{
// Shouldn't happen
return
new
ResponseEntity
<
Map
<
String
,
String
>>(
Collections
.
singletonMap
(
"message"
,
"This endpoint is disabled"
),
HttpStatus
.
NOT_FOUND
);
}
return
this
.
delegate
.
invoke
();
}
public
Endpoint
<?>
getDelegate
()
{
return
this
.
delegate
;
}
@Override
public
String
getPath
()
{
return
"/"
+
this
.
delegate
.
getId
();
...
...
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/mvc/MvcEndpoints.java
View file @
0aa3b00f
...
...
@@ -60,7 +60,7 @@ public class MvcEndpoints implements ApplicationContextAware, InitializingBean {
Collection
<
Endpoint
>
delegates
=
BeanFactoryUtils
.
beansOfTypeIncludingAncestors
(
this
.
applicationContext
,
Endpoint
.
class
).
values
();
for
(
Endpoint
<?>
endpoint
:
delegates
)
{
if
(
isGenericEndpoint
(
endpoint
.
getClass
()))
{
if
(
isGenericEndpoint
(
endpoint
.
getClass
())
&&
endpoint
.
isEnabled
()
)
{
this
.
endpoints
.
add
(
new
EndpointMvcAdapter
(
endpoint
));
}
}
...
...
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/mvc/ShutdownMvcEndpoint.java
View file @
0aa3b00f
...
...
@@ -16,7 +16,12 @@
package
org
.
springframework
.
boot
.
actuate
.
endpoint
.
mvc
;
import
java.util.Collections
;
import
java.util.Map
;
import
org.springframework.boot.actuate.endpoint.ShutdownEndpoint
;
import
org.springframework.http.HttpStatus
;
import
org.springframework.http.ResponseEntity
;
import
org.springframework.web.bind.annotation.RequestMapping
;
import
org.springframework.web.bind.annotation.RequestMethod
;
import
org.springframework.web.bind.annotation.ResponseBody
;
...
...
@@ -36,6 +41,10 @@ public class ShutdownMvcEndpoint extends EndpointMvcAdapter {
@ResponseBody
@Override
public
Object
invoke
()
{
if
(!
getDelegate
().
isEnabled
())
{
return
new
ResponseEntity
<
Map
<
String
,
String
>>(
Collections
.
singletonMap
(
"message"
,
"This endpoint is disabled"
),
HttpStatus
.
NOT_FOUND
);
}
return
super
.
invoke
();
}
}
spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/mvc/ShutdownMvcEndpointTests.java
0 → 100644
View file @
0aa3b00f
/*
* Copyright 2012-2013 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package
org
.
springframework
.
boot
.
actuate
.
endpoint
.
mvc
;
import
java.util.Map
;
import
org.junit.Before
;
import
org.junit.Test
;
import
org.springframework.boot.actuate.endpoint.ShutdownEndpoint
;
import
org.springframework.http.HttpStatus
;
import
org.springframework.http.ResponseEntity
;
import
static
org
.
junit
.
Assert
.
assertEquals
;
import
static
org
.
mockito
.
Mockito
.
mock
;
import
static
org
.
mockito
.
Mockito
.
when
;
/**
* @author Dave Syer
*/
public
class
ShutdownMvcEndpointTests
{
private
ShutdownEndpoint
endpoint
=
mock
(
ShutdownEndpoint
.
class
);
private
ShutdownMvcEndpoint
mvc
=
new
ShutdownMvcEndpoint
(
this
.
endpoint
);
@Before
public
void
init
()
{
when
(
this
.
endpoint
.
isEnabled
()).
thenReturn
(
false
);
}
@Test
public
void
disabled
()
{
@SuppressWarnings
(
"unchecked"
)
ResponseEntity
<
Map
<
String
,
String
>>
response
=
(
ResponseEntity
<
Map
<
String
,
String
>>)
this
.
mvc
.
invoke
();
assertEquals
(
HttpStatus
.
NOT_FOUND
,
response
.
getStatusCode
());
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment