Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
0e7ab884
Commit
0e7ab884
authored
Oct 12, 2020
by
Scott Frederick
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Polish "Update default builder image"
See gh-23628
parent
461dc23c
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
17 additions
and
21 deletions
+17
-21
BuildRequestTests.java
...work/boot/buildpack/platform/build/BuildRequestTests.java
+2
-2
BootBuildImageIntegrationTests.java
...gradle/tasks/bundling/BootBuildImageIntegrationTests.java
+7
-8
BootBuildImageTests.java
...ework/boot/gradle/tasks/bundling/BootBuildImageTests.java
+1
-1
BootBuildImageIntegrationTests-buildsImageWithCustomBuilderAndRunImage.gradle
...ationTests-buildsImageWithCustomBuilderAndRunImage.gradle
+2
-2
BuildImageTests.java
.../java/org/springframework/boot/maven/BuildImageTests.java
+5
-8
No files found.
spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildRequestTests.java
View file @
0e7ab884
...
...
@@ -55,7 +55,7 @@ public class BuildRequestTests {
writeTestJarFile
(
jarFile
);
BuildRequest
request
=
BuildRequest
.
forJarFile
(
jarFile
);
assertThat
(
request
.
getName
().
toString
()).
isEqualTo
(
"docker.io/library/my-app:0.0.1"
);
assertThat
(
request
.
getBuilder
().
toString
()).
isEqualTo
(
BuildRequest
.
DEFAULT_BUILDER_IMAGE_NAME
);
assertThat
(
request
.
getBuilder
().
toString
()).
isEqualTo
(
"docker.io/"
+
BuildRequest
.
DEFAULT_BUILDER_IMAGE_NAME
);
assertThat
(
request
.
getApplicationContent
(
Owner
.
ROOT
)).
satisfies
(
this
::
hasExpectedJarContent
);
assertThat
(
request
.
getEnv
()).
isEmpty
();
}
...
...
@@ -66,7 +66,7 @@ public class BuildRequestTests {
writeTestJarFile
(
jarFile
);
BuildRequest
request
=
BuildRequest
.
forJarFile
(
ImageReference
.
of
(
"test-app"
),
jarFile
);
assertThat
(
request
.
getName
().
toString
()).
isEqualTo
(
"docker.io/library/test-app:latest"
);
assertThat
(
request
.
getBuilder
().
toString
()).
isEqualTo
(
BuildRequest
.
DEFAULT_BUILDER_IMAGE_NAME
);
assertThat
(
request
.
getBuilder
().
toString
()).
isEqualTo
(
"docker.io/"
+
BuildRequest
.
DEFAULT_BUILDER_IMAGE_NAME
);
assertThat
(
request
.
getApplicationContent
(
Owner
.
ROOT
)).
satisfies
(
this
::
hasExpectedJarContent
);
assertThat
(
request
.
getEnv
()).
isEmpty
();
}
...
...
spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageIntegrationTests.java
View file @
0e7ab884
...
...
@@ -60,7 +60,7 @@ class BootBuildImageIntegrationTests {
String
projectName
=
this
.
gradleBuild
.
getProjectDir
().
getName
();
assertThat
(
result
.
task
(
":bootBuildImage"
).
getOutcome
()).
isEqualTo
(
TaskOutcome
.
SUCCESS
);
assertThat
(
result
.
getOutput
()).
contains
(
"docker.io/library/"
+
projectName
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
-
buildpacks/builder"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketobuildpacks/builder"
);
ImageReference
imageReference
=
ImageReference
.
of
(
ImageName
.
of
(
projectName
));
try
(
GenericContainer
<?>
container
=
new
GenericContainer
<>(
imageReference
.
toString
()))
{
container
.
waitingFor
(
Wait
.
forLogMessage
(
"Launched\\n"
,
1
)).
start
();
...
...
@@ -77,7 +77,7 @@ class BootBuildImageIntegrationTests {
BuildResult
result
=
this
.
gradleBuild
.
build
(
"bootBuildImage"
);
assertThat
(
result
.
task
(
":bootBuildImage"
).
getOutcome
()).
isEqualTo
(
TaskOutcome
.
SUCCESS
);
assertThat
(
result
.
getOutput
()).
contains
(
"example/test-image-name"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
-
buildpacks/builder"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketobuildpacks/builder"
);
ImageReference
imageReference
=
ImageReference
.
of
(
ImageName
.
of
(
"example/test-image-name"
));
try
(
GenericContainer
<?>
container
=
new
GenericContainer
<>(
imageReference
.
toString
()))
{
container
.
waitingFor
(
Wait
.
forLogMessage
(
"Launched\\n"
,
1
)).
start
();
...
...
@@ -94,8 +94,8 @@ class BootBuildImageIntegrationTests {
BuildResult
result
=
this
.
gradleBuild
.
build
(
"bootBuildImage"
);
assertThat
(
result
.
task
(
":bootBuildImage"
).
getOutcome
()).
isEqualTo
(
TaskOutcome
.
SUCCESS
);
assertThat
(
result
.
getOutput
()).
contains
(
"example/test-image-custom"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
-buildpacks/builder:full-cf-platform-api-0.3
"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
-buildpacks/run:full-cnb-cf
"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
buildpacks/builder:full
"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
buildpacks/run:full
"
);
ImageReference
imageReference
=
ImageReference
.
of
(
ImageName
.
of
(
"example/test-image-custom"
));
try
(
GenericContainer
<?>
container
=
new
GenericContainer
<>(
imageReference
.
toString
()))
{
container
.
waitingFor
(
Wait
.
forLogMessage
(
"Launched\\n"
,
1
)).
start
();
...
...
@@ -110,12 +110,11 @@ class BootBuildImageIntegrationTests {
writeMainClass
();
writeLongNameResource
();
BuildResult
result
=
this
.
gradleBuild
.
build
(
"bootBuildImage"
,
"--imageName=example/test-image-cmd"
,
"--builder=gcr.io/paketo-buildpacks/builder:full-cf-platform-api-0.3"
,
"--runImage=gcr.io/paketo-buildpacks/run:full-cnb-cf"
);
"--builder=paketobuildpacks/builder:full"
,
"--runImage=paketobuildpacks/run:full-cnb"
);
assertThat
(
result
.
task
(
":bootBuildImage"
).
getOutcome
()).
isEqualTo
(
TaskOutcome
.
SUCCESS
);
assertThat
(
result
.
getOutput
()).
contains
(
"example/test-image-cmd"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
-buildpacks/builder:full-cf-platform-api-0.3
"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
-buildpacks/run:full-cnb-cf
"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
buildpacks/builder:full
"
);
assertThat
(
result
.
getOutput
()).
contains
(
"paketo
buildpacks/run:full
"
);
ImageReference
imageReference
=
ImageReference
.
of
(
ImageName
.
of
(
"example/test-image-cmd"
));
try
(
GenericContainer
<?>
container
=
new
GenericContainer
<>(
imageReference
.
toString
()))
{
container
.
waitingFor
(
Wait
.
forLogMessage
(
"Launched\\n"
,
1
)).
start
();
...
...
spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageTests.java
View file @
0e7ab884
...
...
@@ -190,7 +190,7 @@ class BootBuildImageTests {
@Test
void
whenNoBuilderIsConfiguredThenRequestHasDefaultBuilder
()
{
assertThat
(
this
.
buildImage
.
createRequest
().
getBuilder
().
getName
()).
isEqualTo
(
"paketo
-
buildpacks/builder"
);
assertThat
(
this
.
buildImage
.
createRequest
().
getBuilder
().
getName
()).
isEqualTo
(
"paketobuildpacks/builder"
);
}
@Test
...
...
spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/tasks/bundling/BootBuildImageIntegrationTests-buildsImageWithCustomBuilderAndRunImage.gradle
View file @
0e7ab884
...
...
@@ -8,6 +8,6 @@ targetCompatibility = '1.8'
bootBuildImage
{
imageName
=
"example/test-image-custom"
builder
=
"
gcr.io/paketo-buildpacks/builder:full-cf-platform-api-0.3
"
runImage
=
"
gcr.io/paketo-buildpacks/run:full-cnb-cf
"
builder
=
"
paketobuildpacks/builder:full
"
runImage
=
"
paketobuildpacks/run:full-cnb
"
}
spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/BuildImageTests.java
View file @
0e7ab884
...
...
@@ -93,14 +93,12 @@ public class BuildImageTests extends AbstractArchiveIntegrationTests {
void
whenBuildImageIsInvokedWithCommandLineParameters
(
MavenBuild
mavenBuild
)
{
mavenBuild
.
project
(
"build-image"
).
goals
(
"package"
)
.
systemProperty
(
"spring-boot.build-image.imageName"
,
"example.com/test/cmd-property-name:v1"
)
.
systemProperty
(
"spring-boot.build-image.builder"
,
"paketobuildpacks/builder:full"
)
.
systemProperty
(
"spring-boot.build-image.builder"
,
"paketobuildpacks/builder:full"
)
.
systemProperty
(
"spring-boot.build-image.runImage"
,
"paketobuildpacks/run:full-cnb"
)
.
execute
((
project
)
->
{
assertThat
(
buildLog
(
project
)).
contains
(
"Building image"
)
.
contains
(
"example.com/test/cmd-property-name:v1"
)
.
contains
(
"paketobuildpacks/builder:full"
)
.
contains
(
"paketobuildpacks/run:full-cnb"
).
contains
(
"Successfully built image"
);
.
contains
(
"example.com/test/cmd-property-name:v1"
).
contains
(
"paketobuildpacks/builder:full"
)
.
contains
(
"paketobuildpacks/run:full"
).
contains
(
"Successfully built image"
);
ImageReference
imageReference
=
ImageReference
.
of
(
"example.com/test/cmd-property-name:v1"
);
try
(
GenericContainer
<?>
container
=
new
GenericContainer
<>(
imageReference
.
toString
()))
{
container
.
waitingFor
(
Wait
.
forLogMessage
(
"Launched\\n"
,
1
)).
start
();
...
...
@@ -114,9 +112,8 @@ public class BuildImageTests extends AbstractArchiveIntegrationTests {
@TestTemplate
void
whenBuildImageIsInvokedWithCustomBuilderImageAndRunImage
(
MavenBuild
mavenBuild
)
{
mavenBuild
.
project
(
"build-image-custom-builder"
).
goals
(
"package"
).
execute
((
project
)
->
{
assertThat
(
buildLog
(
project
)).
contains
(
"Building image"
)
.
contains
(
"paketobuildpacks/builder:full"
)
.
contains
(
"paketobuildpacks/run:full-cnb"
)
assertThat
(
buildLog
(
project
)).
contains
(
"Building image"
).
contains
(
"paketobuildpacks/builder:full"
)
.
contains
(
"paketobuildpacks/run:full"
)
.
contains
(
"docker.io/library/build-image-v2-builder:0.0.1.BUILD-SNAPSHOT"
)
.
contains
(
"Successfully built image"
);
ImageReference
imageReference
=
ImageReference
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment