Commit 143e4f02 authored by Stephane Nicoll's avatar Stephane Nicoll

Merge branch '2.0.x'

parents 8367c57d 9de3d33e
...@@ -230,7 +230,9 @@ abstract class ArchiveCommand extends OptionParsingCommand { ...@@ -230,7 +230,9 @@ abstract class ArchiveCommand extends OptionParsingCommand {
private String commaDelimitedClassNames(Class<?>[] classes) { private String commaDelimitedClassNames(Class<?>[] classes) {
StringBuilder builder = new StringBuilder(); StringBuilder builder = new StringBuilder();
for (int i = 0; i < classes.length; i++) { for (int i = 0; i < classes.length; i++) {
builder.append((i != 0) ? "," : ""); if (i != 0) {
builder.append(',');
}
builder.append(classes[i].getName()); builder.append(classes[i].getName());
} }
return builder.toString(); return builder.toString();
......
...@@ -115,8 +115,10 @@ class PropertyMappingContextCustomizer implements ContextCustomizer { ...@@ -115,8 +115,10 @@ class PropertyMappingContextCustomizer implements ContextCustomizer {
private String getAnnotationsDescription(Set<Class<?>> annotations) { private String getAnnotationsDescription(Set<Class<?>> annotations) {
StringBuilder result = new StringBuilder(); StringBuilder result = new StringBuilder();
for (Class<?> annotation : annotations) { for (Class<?> annotation : annotations) {
result.append((result.length() != 0) ? ", " : ""); if (result.length() != 0) {
result.append("@" + ClassUtils.getShortName(annotation)); result.append(", ");
}
result.append('@').append(ClassUtils.getShortName(annotation));
} }
result.insert(0, (annotations.size() != 1) ? "annotations " : "annotation "); result.insert(0, (annotations.size() != 1) ? "annotations " : "annotation ");
return result.toString(); return result.toString();
......
...@@ -63,9 +63,11 @@ public final class ItemMetadata implements Comparable<ItemMetadata> { ...@@ -63,9 +63,11 @@ public final class ItemMetadata implements Comparable<ItemMetadata> {
} }
StringBuilder fullName = new StringBuilder((prefix != null) ? prefix : ""); StringBuilder fullName = new StringBuilder((prefix != null) ? prefix : "");
if (fullName.length() > 0 && name != null) { if (fullName.length() > 0 && name != null) {
fullName.append("."); fullName.append('.');
}
if (name != null) {
fullName.append(ConfigurationMetadata.toDashedCase(name));
} }
fullName.append((name != null) ? ConfigurationMetadata.toDashedCase(name) : "");
return fullName.toString(); return fullName.toString();
} }
......
...@@ -391,9 +391,10 @@ public abstract class AbstractRunMojo extends AbstractDependencyFilterMojo { ...@@ -391,9 +391,10 @@ public abstract class AbstractRunMojo extends AbstractDependencyFilterMojo {
try { try {
StringBuilder classpath = new StringBuilder(); StringBuilder classpath = new StringBuilder();
for (URL ele : getClassPathUrls()) { for (URL ele : getClassPathUrls()) {
classpath = classpath if (classpath.length() > 0) {
.append(((classpath.length() > 0) ? File.pathSeparator : "") classpath.append(File.pathSeparator);
+ new File(ele.toURI())); }
classpath.append(new File(ele.toURI()));
} }
if (getLog().isDebugEnabled()) { if (getLog().isDebugEnabled()) {
getLog().debug("Classpath for forked process: " + classpath); getLog().debug("Classpath for forked process: " + classpath);
......
...@@ -214,7 +214,9 @@ class MapBinder extends AggregateBinder<Map<Object, Object>> { ...@@ -214,7 +214,9 @@ class MapBinder extends AggregateBinder<Map<Object, Object>> {
StringBuilder result = new StringBuilder(); StringBuilder result = new StringBuilder();
for (int i = this.root.getNumberOfElements(); i < name for (int i = this.root.getNumberOfElements(); i < name
.getNumberOfElements(); i++) { .getNumberOfElements(); i++) {
result.append((result.length() != 0) ? "." : ""); if (result.length() != 0) {
result.append('.');
}
result.append(name.getElement(i, Form.ORIGINAL)); result.append(name.getElement(i, Form.ORIGINAL));
} }
return result.toString(); return result.toString();
......
...@@ -394,7 +394,7 @@ public final class ConfigurationPropertyName ...@@ -394,7 +394,7 @@ public final class ConfigurationPropertyName
for (CharSequence element : elements) { for (CharSequence element : elements) {
boolean indexed = isIndexed(element); boolean indexed = isIndexed(element);
if (result.length() > 0 && !indexed) { if (result.length() > 0 && !indexed) {
result.append("."); result.append('.');
} }
if (indexed) { if (indexed) {
result.append(element); result.append(element);
...@@ -402,7 +402,9 @@ public final class ConfigurationPropertyName ...@@ -402,7 +402,9 @@ public final class ConfigurationPropertyName
else { else {
for (int i = 0; i < element.length(); i++) { for (int i = 0; i < element.length(); i++) {
char ch = Character.toLowerCase(element.charAt(i)); char ch = Character.toLowerCase(element.charAt(i));
result.append((ch != '_') ? ch : ""); if (ch != '_') {
result.append(ch);
}
} }
} }
} }
......
...@@ -172,8 +172,10 @@ public class JettyWebServer implements WebServer { ...@@ -172,8 +172,10 @@ public class JettyWebServer implements WebServer {
private String getActualPortsDescription() { private String getActualPortsDescription() {
StringBuilder ports = new StringBuilder(); StringBuilder ports = new StringBuilder();
for (Connector connector : this.server.getConnectors()) { for (Connector connector : this.server.getConnectors()) {
ports.append((ports.length() != 0) ? ", " : ""); if (ports.length() != 0) {
ports.append(getLocalPort(connector) + getProtocols(connector)); ports.append(", ");
}
ports.append(getLocalPort(connector)).append(getProtocols(connector));
} }
return ports.toString(); return ports.toString();
} }
......
...@@ -319,9 +319,11 @@ public class TomcatWebServer implements WebServer { ...@@ -319,9 +319,11 @@ public class TomcatWebServer implements WebServer {
private String getPortsDescription(boolean localPort) { private String getPortsDescription(boolean localPort) {
StringBuilder ports = new StringBuilder(); StringBuilder ports = new StringBuilder();
for (Connector connector : this.tomcat.getService().findConnectors()) { for (Connector connector : this.tomcat.getService().findConnectors()) {
ports.append((ports.length() != 0) ? " " : ""); if (ports.length() != 0) {
ports.append(' ');
}
int port = localPort ? connector.getLocalPort() : connector.getPort(); int port = localPort ? connector.getLocalPort() : connector.getPort();
ports.append(port + " (" + connector.getScheme() + ")"); ports.append(port).append(" (").append(connector.getScheme()).append(')');
} }
return ports.toString(); return ports.toString();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment