Commit 1709e79c authored by Stephane Nicoll's avatar Stephane Nicoll

Merge pull request #1763 from sdeleuze/whitelabel-typo

* whitelabel-typo:
  Fix a typo in error.whitelabel.enabled
parents 741d1f72 7546f10a
...@@ -97,7 +97,7 @@ public class ErrorMvcAutoConfiguration implements EmbeddedServletContainerCustom ...@@ -97,7 +97,7 @@ public class ErrorMvcAutoConfiguration implements EmbeddedServletContainerCustom
} }
@Configuration @Configuration
@ConditionalOnProperty(prefix = "error.whitelable", name = "enabled", matchIfMissing = true) @ConditionalOnProperty(prefix = "error.whitelabel", name = "enabled", matchIfMissing = true)
@Conditional(ErrorTemplateMissingCondition.class) @Conditional(ErrorTemplateMissingCondition.class)
protected static class WhitelabelErrorViewConfiguration { protected static class WhitelabelErrorViewConfiguration {
......
...@@ -22,8 +22,13 @@ import java.lang.annotation.Retention; ...@@ -22,8 +22,13 @@ import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy; import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target; import java.lang.annotation.Target;
import javax.servlet.ServletException;
import org.junit.After; import org.junit.After;
import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.springframework.boot.SpringApplication; import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.PropertyPlaceholderAutoConfiguration; import org.springframework.boot.autoconfigure.PropertyPlaceholderAutoConfiguration;
import org.springframework.boot.builder.SpringApplicationBuilder; import org.springframework.boot.builder.SpringApplicationBuilder;
...@@ -47,9 +52,13 @@ import static org.springframework.test.web.servlet.result.MockMvcResultMatchers. ...@@ -47,9 +52,13 @@ import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.
* {@link SpringJUnit4ClassRunner}. * {@link SpringJUnit4ClassRunner}.
* *
* @author Dave Syer * @author Dave Syer
* @author Sebastien Deleuze
*/ */
public class BasicErrorControllerDirectMockMvcTests { public class BasicErrorControllerDirectMockMvcTests {
@Rule
public final ExpectedException thrown = ExpectedException.none();
private ConfigurableWebApplicationContext wac; private ConfigurableWebApplicationContext wac;
private MockMvc mockMvc; private MockMvc mockMvc;
...@@ -87,6 +96,15 @@ public class BasicErrorControllerDirectMockMvcTests { ...@@ -87,6 +96,15 @@ public class BasicErrorControllerDirectMockMvcTests {
assertTrue("Wrong content: " + content, content.contains("status=999")); assertTrue("Wrong content: " + content, content.contains("status=999"));
} }
@Test
public void errorPageNotAvailableWithWhitelabelDisabled() throws Exception {
setup((ConfigurableWebApplicationContext) new SpringApplication(
WebMvcIncludedConfiguration.class).run("--server.port=0", "--error.whitelabel.enabled=false"));
thrown.expect(ServletException.class);
this.mockMvc.perform(get("/error").accept(MediaType.TEXT_HTML));
}
@Target(ElementType.TYPE) @Target(ElementType.TYPE)
@Retention(RetentionPolicy.RUNTIME) @Retention(RetentionPolicy.RUNTIME)
@Documented @Documented
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment