Polish Undertow contribution

Closes gh-1779

.gitignore

@@ -28,5 +28,4 @@ overridedb.*
 *.ipr
 *.iws
 .idea
-*.jar
-.DS_Store
+*.jar
\ No newline at end of file

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/EmbeddedServletContainerAutoConfiguration.java

@@ -54,6 +54,7 @@ import org.springframework.util.ObjectUtils;
  *
  * @author Phillip Webb
  * @author Dave Syer
+ * @author Ivan Sopov
  */
 @Order(Ordered.HIGHEST_PRECEDENCE)
 @Configuration
@@ -90,7 +91,7 @@ public class EmbeddedServletContainerAutoConfiguration {
 		}
 
 	}
-	
+
 	/**
 	 * Nested configuration if Undertow is being used.
 	 */
@@ -105,7 +106,6 @@ public class EmbeddedServletContainerAutoConfiguration {
 		}
 
 	}
-	
 
 	/**
 	 * Registers a {@link EmbeddedServletContainerCustomizerBeanPostProcessor}. Registered

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java

@@ -53,6 +53,7 @@ import org.springframework.util.StringUtils;
  * @author Dave Syer
  * @author Stephane Nicoll
  * @author Andy Wilkinson
+ * @author Ivan Sopov
  */
 @ConfigurationProperties(prefix = "server", ignoreUnknownFields = false)
 public class ServerProperties implements EmbeddedServletContainerCustomizer {
@@ -72,7 +73,7 @@ public class ServerProperties implements EmbeddedServletContainerCustomizer {
 	private String servletPath = "/";
 
 	private final Tomcat tomcat = new Tomcat();
-	
+
 	private final Undertow undertow = new Undertow();
 
 	private final Map<String, String> contextParameters = new HashMap<String, String>();
@@ -220,62 +221,6 @@ public class ServerProperties implements EmbeddedServletContainerCustomizer {
 		return prefix + path;
 	}
 
-	public static class Undertow {
-		private Integer bufferSize;
-		private Integer buffersPerRegion;
-		private Integer ioThreads;
-		private Integer workerThreads;
-		private Boolean directBuffers;
-
-		public Integer getBufferSize() {
-			return this.bufferSize;
-		}
-
-		public void setBufferSize(Integer bufferSize) {
-			this.bufferSize = bufferSize;
-		}
-
-		public Integer getBuffersPerRegion() {
-			return this.buffersPerRegion;
-		}
-
-		public void setBuffersPerRegion(Integer buffersPerRegion) {
-			this.buffersPerRegion = buffersPerRegion;
-		}
-
-		public Integer getIoThreads() {
-			return this.ioThreads;
-		}
-
-		public void setIoThreads(Integer ioThreads) {
-			this.ioThreads = ioThreads;
-		}
-
-		public Integer getWorkerThreads() {
-			return this.workerThreads;
-		}
-
-		public void setWorkerThreads(Integer workerThreads) {
-			this.workerThreads = workerThreads;
-		}
-
-		public Boolean getDirectBuffers() {
-			return this.directBuffers;
-		}
-
-		public void setDirectBuffers(Boolean directBuffers) {
-			this.directBuffers = directBuffers;
-		}
-
-		void customizeUndertow(UndertowEmbeddedServletContainerFactory factory) {
-			factory.setBufferSize(bufferSize);
-			factory.setBuffersPerRegion(buffersPerRegion);
-			factory.setIoThreads(ioThreads);
-			factory.setWorkerThreads(workerThreads);
-			factory.setDirectBuffers(directBuffers);
-		}
-	}
-
 	public static class Tomcat {
 
 		private String accessLogPattern;
@@ -462,4 +407,66 @@ public class ServerProperties implements EmbeddedServletContainerCustomizer {
 
 	}
 
+	public static class Undertow {
+
+		private Integer bufferSize;
+
+		private Integer buffersPerRegion;
+
+		private Integer ioThreads;
+
+		private Integer workerThreads;
+
+		private Boolean directBuffers;
+
+		public Integer getBufferSize() {
+			return this.bufferSize;
+		}
+
+		public void setBufferSize(Integer bufferSize) {
+			this.bufferSize = bufferSize;
+		}
+
+		public Integer getBuffersPerRegion() {
+			return this.buffersPerRegion;
+		}
+
+		public void setBuffersPerRegion(Integer buffersPerRegion) {
+			this.buffersPerRegion = buffersPerRegion;
+		}
+
+		public Integer getIoThreads() {
+			return this.ioThreads;
+		}
+
+		public void setIoThreads(Integer ioThreads) {
+			this.ioThreads = ioThreads;
+		}
+
+		public Integer getWorkerThreads() {
+			return this.workerThreads;
+		}
+
+		public void setWorkerThreads(Integer workerThreads) {
+			this.workerThreads = workerThreads;
+		}
+
+		public Boolean getDirectBuffers() {
+			return this.directBuffers;
+		}
+
+		public void setDirectBuffers(Boolean directBuffers) {
+			this.directBuffers = directBuffers;
+		}
+
+		void customizeUndertow(UndertowEmbeddedServletContainerFactory factory) {
+			factory.setBufferSize(this.bufferSize);
+			factory.setBuffersPerRegion(this.buffersPerRegion);
+			factory.setIoThreads(this.ioThreads);
+			factory.setWorkerThreads(this.workerThreads);
+			factory.setDirectBuffers(this.directBuffers);
+		}
+
+	}
+
 }

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/MultipartAutoConfigurationTests.java

@@ -16,9 +16,7 @@
 
 package org.springframework.boot.autoconfigure.web;
 
-import java.io.IOException;
 import java.net.URI;
-import java.net.URISyntaxException;
 
 import javax.servlet.MultipartConfigElement;
 
@@ -65,6 +63,7 @@ import static org.mockito.Mockito.mock;
  * @author Greg Turnquist
  * @author Dave Syer
  * @author Josh Long
+ * @author Ivan Sopov
  */
 public class MultipartAutoConfigurationTests {
 

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesAutoConfigurationTests.java

@@ -47,6 +47,7 @@ import static org.mockito.Mockito.verify;
  * Tests for {@link ServerPropertiesAutoConfiguration}.
  *
  * @author Dave Syer
+ * @author Ivan Sopov
  */
 public class ServerPropertiesAutoConfigurationTests {
 
@@ -112,8 +113,7 @@ public class ServerPropertiesAutoConfigurationTests {
 		// factory should take precedence...
 		assertEquals(3000, containerFactory.getPort());
 	}
-	
-	
+
 	@Test
 	public void customizeWithUndertowContainerFactory() throws Exception {
 		this.context = new AnnotationConfigEmbeddedWebApplicationContext();
@@ -127,7 +127,6 @@ public class ServerPropertiesAutoConfigurationTests {
 		assertNotNull(server);
 		assertEquals(3000, containerFactory.getPort());
 	}
-	
 
 	@Test
 	public void customizeTomcatWithCustomizer() throws Exception {
@@ -186,7 +185,7 @@ public class ServerPropertiesAutoConfigurationTests {
 		}
 
 	}
-	
+
 	@Configuration
 	protected static class CustomUndertowContainerConfig {
 
@@ -203,9 +202,6 @@ public class ServerPropertiesAutoConfigurationTests {
 		}
 
 	}
-	
-	
-	
 
 	@Configuration
 	protected static class CustomizeConfig {

spring-boot-dependencies/pom.xml

@@ -127,10 +127,10 @@
 		<thymeleaf-layout-dialect.version>1.2.7</thymeleaf-layout-dialect.version>
 		<thymeleaf-extras-data-attribute.version>1.3</thymeleaf-extras-data-attribute.version>
 		<tomcat.version>8.0.15</tomcat.version>
+		<undertow.version>1.1.0.Final</undertow.version>
 		<velocity.version>1.7</velocity.version>
 		<velocity-tools.version>2.0</velocity-tools.version>
 		<wsdl4j.version>1.6.3</wsdl4j.version>
-        	<undertow.version>1.1.0.Final</undertow.version>
 	</properties>
 	<prerequisites>
 		<maven>3.0.2</maven>
@@ -540,6 +540,16 @@
 				<artifactId>metrics-servlets</artifactId>
 				<version>${dropwizard-metrics.version}</version>
 			</dependency>
+			<dependency>
+				<groupId>io.undertow</groupId>
+				<artifactId>undertow-core</artifactId>
+				<version>${undertow.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>io.undertow</groupId>
+				<artifactId>undertow-servlet</artifactId>
+				<version>${undertow.version}</version>
+			</dependency>
 			<dependency>
 				<groupId>javax.cache</groupId>
 				<artifactId>cache-api</artifactId>
@@ -707,11 +717,6 @@
 				<artifactId>tomcat-jsp-api</artifactId>
 				<version>${tomcat.version}</version>
 			</dependency>
-			<dependency>
-				<groupId>io.undertow</groupId>
-				<artifactId>undertow-servlet</artifactId>
-				<version>${undertow.version}</version>
-			</dependency>
 			<dependency>
 				<groupId>org.apache.velocity</groupId>
 				<artifactId>velocity</artifactId>

spring-boot-docs/src/main/asciidoc/cloud-deployment.adoc

@@ -158,8 +158,8 @@ for our starter REST application:
 
 Spring Boot makes `-D` arguments available as properties accessible from a Spring
 `Environment` instance. The `server.port` configuration property is fed to the embedded
-Tomcat or Jetty instance which then uses it when it starts up. The `$PORT` environment
-variable is assigned to us by the Heroku PaaS.
+Tomcat, Jetty or Undertow instance which then uses it when it starts up. The `$PORT`
+environment variable is assigned to us by the Heroku PaaS.
 
 Heroku by default will use Java 1.6. This is fine as long as your Maven or Gradle build
 is set to use the same version (Maven users can use the `java.version` property). If you

spring-boot-docs/src/main/asciidoc/howto.adoc

@@ -556,6 +556,61 @@ of ways. Or the nuclear option is to add your own `JettyEmbeddedServletContainer
 
 
 
+[[howto-use-undertow-instead-of-tomcat]]
+=== Use Undertow instead of Tomcat
+Using Undertow instead of Tomcat is very similar to <<howto-use-jetty-instead-of-tomcat,
+using Jetty instead of Tomcat>>. You need to exclude the Tomcat dependencies and include
+the Undertow starter instead.
+
+Example in Maven:
+
+[source,xml,indent=0,subs="verbatim,quotes,attributes"]
+----
+	<dependency>
+		<groupId>org.springframework.boot</groupId>
+		<artifactId>spring-boot-starter-web</artifactId>
+		<exclusions>
+			<exclusion>
+				<groupId>org.springframework.boot</groupId>
+				<artifactId>spring-boot-starter-tomcat</artifactId>
+			</exclusion>
+		</exclusions>
+	</dependency>
+	<dependency>
+		<groupId>org.springframework.boot</groupId>
+		<artifactId>spring-boot-starter-undertow</artifactId>
+	</dependency>
+----
+
+Example in Gradle:
+
+[source,groovy,indent=0,subs="verbatim,quotes,attributes"]
+----
+	configurations {
+		compile.exclude module: "spring-boot-starter-tomcat"
+	}
+
+	dependencies {
+		compile("org.springframework.boot:spring-boot-starter-web:{spring-boot-version}")
+		compile("org.springframework.boot:spring-boot-starter-undertow:{spring-boot-version}")
+		// ...
+	}
+----
+
+
+[[howto-configure-undertow]]
+=== Configure Undertow
+Generally you can follow the advice from
+_<<howto-discover-build-in-options-for-external-properties>>_ about
+`@ConfigurationProperties` (`ServerProperties` and `ServerProperties.Undertow are the
+main ones here), but also look at
+`EmbeddedServletContainerCustomizer`. Once you have access to the
+`UndertowEmbeddedServletContainerFactory` you can use an `UndertowBuilderCustomizer` to
+modify Undertow's configuration to meet your needs. Or the nuclear option is to add your
+own `UndertowEmbeddedServletContainerFactory`.
+
+
+
 [[howto-use-tomcat-8]]
 === Use Tomcat 8
 Tomcat 8 works with Spring Boot, but the default is to use Tomcat 7 (so we can support

spring-boot-docs/src/main/asciidoc/spring-boot-features.adoc

@@ -810,8 +810,8 @@ possible.
 [[boot-features-developing-web-applications]]
 == Developing web applications
 Spring Boot is well suited for web application development. You can easily create a
-self-contained HTTP server using embedded Tomcat or Jetty. Most web applications will
-use the `spring-boot-starter-web` module to get up and running quickly.
+self-contained HTTP server using embedded Tomcat, Jetty, or Undertow. Most web
+applications will use the `spring-boot-starter-web` module to get up and running quickly.
 
 If you haven't yet developed a Spring Boot web application you can follow the
 "Hello World!" example in the
@@ -1093,9 +1093,9 @@ asks for them to be scanned in its `Filter` registration).
 
 [[boot-features-embedded-container]]
 === Embedded servlet container support
-Spring Boot includes support for embedded Tomcat and Jetty servers. Most developers will
-simply use the appropriate '`Starter POM`' to obtain a fully configured instance. By
-default both Tomcat and Jetty will listen for HTTP requests on port `8080`.
+Spring Boot includes support for embedded Tomcat, Jetty, and Undertow servers. Most
+developers will simply use the appropriate '`Starter POM`' to obtain a fully configured
+instance. By default the embedded server will listen for HTTP requests on port `8080`.
 
 
 
@@ -1121,8 +1121,9 @@ interface.
 Under the hood Spring Boot uses a new type of `ApplicationContext` for embedded
 servlet container support.  The `EmbeddedWebApplicationContext` is a special
 type of `WebApplicationContext` that bootstraps itself by searching for a single
-`EmbeddedServletContainerFactory` bean. Usually a `TomcatEmbeddedServletContainerFactory`
-or `JettyEmbeddedServletContainerFactory` will have been auto-configured.
+`EmbeddedServletContainerFactory` bean. Usually a `TomcatEmbeddedServletContainerFactory`,
+`JettyEmbeddedServletContainerFactory`, or `UndertowEmbeddedServletContainerFactory` will
+have been auto-configured.
 
 NOTE: You usually won't need to be aware of these implementation classes. Most
 applications will be auto-configured and the appropriate `ApplicationContext` and
@@ -1176,8 +1177,8 @@ methods.
 [[boot-features-customizing-configurableembeddedservletcontainerfactory-directly]]
 ===== Customizing ConfigurableEmbeddedServletContainer directly
 If the above customization techniques are too limited, you can register the
-`TomcatEmbeddedServletContainerFactory` or `JettyEmbeddedServletContainerFactory` bean
-yourself.
+`TomcatEmbeddedServletContainerFactory`, `JettyEmbeddedServletContainerFactory` or
+`UndertowEmbeddedServletContainerFactory` bean yourself.
 
 [source,java,indent=0]
 ----
@@ -1208,6 +1209,8 @@ packaged as an executable archive), there are some limitations in the JSP suppor
 
 * Jetty does not currently work as an embedded container with JSPs.
 
+* Undertow does not support JSPs
+
 There is a {github-code}/spring-boot-samples/spring-boot-sample-web-jsp[JSP sample] so
 you can see how to set things up.
 

spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc

@@ -348,6 +348,9 @@ swap specific technical facets.
 
 |`spring-boot-starter-tomcat`
 |Import Spring Boot's default HTTP engine (Tomcat).
+
+|`spring-boot-starter-undertow`
+|Imports the Undertow HTTP engine (to be used as an alternative to Tomcat)
 |===
 
 TIP: For a list of additional community contributed starter POMs, see the

spring-boot-samples/spring-boot-sample-undertow-ssl/src/main/java/sample/undertow/SampleUndertowSslApplication.java

 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-samples/spring-boot-sample-undertow-ssl/src/main/java/sample/undertow/service/HelloWorldService.java

 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-samples/spring-boot-sample-undertow-ssl/src/main/java/sample/undertow/web/SampleController.java

 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-samples/spring-boot-sample-undertow-ssl/src/test/java/sample/undertow/SampleUndertowSslApplicationTests.java

@@ -39,7 +39,7 @@ import static org.junit.Assert.assertEquals;
 /**
  * Basic integration tests for demo application.
  *
- * @author Dave Syer
+ * @author Ivan Sopov
  */
 @RunWith(SpringJUnit4ClassRunner.class)
 @SpringApplicationConfiguration(classes = SampleUndertowSslApplication.class)

spring-boot-samples/spring-boot-sample-undertow/src/main/java/sample/undertow/SampleUndertowApplication.java

 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-samples/spring-boot-sample-undertow/src/main/java/sample/undertow/service/HelloWorldService.java

 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-samples/spring-boot-sample-undertow/src/main/java/sample/undertow/web/SampleController.java

 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-starters/spring-boot-starter-undertow/pom.xml

@@ -19,9 +19,23 @@
 		<main.basedir>${basedir}/../..</main.basedir>
 	</properties>
 	<dependencies>
+		<dependency>
+			<groupId>io.undertow</groupId>
+			<artifactId>undertow-core</artifactId>
+		</dependency>
 		<dependency>
 			<groupId>io.undertow</groupId>
 			<artifactId>undertow-servlet</artifactId>
+			<exclusions>
+				<exclusion>
+					<groupId>org.jboss.spec.javax.servlet</groupId>
+					<artifactId>jboss-servlet-api_3.1_spec</artifactId>
+				</exclusion>
+			</exclusions>
+		</dependency>
+		<dependency>
+			<groupId>javax.servlet</groupId>
+			<artifactId>javax.servlet-api</artifactId>
 		</dependency>
 	</dependencies>
 </project>

spring-boot/src/main/java/org/springframework/boot/context/embedded/undertow/UndertowBuilderCustomizer.java

+/*
+ * Copyright 2012-2014 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.context.embedded.undertow;
+
+import io.undertow.Undertow.Builder;
+
+/**
+ * Callback interface that can be used to customize an Undertow {@link Builder}.
+ *
+ * @author Andy Wilkinson
+ * @since 1.2.0
+ * @see UndertowEmbeddedServletContainerFactory
+ */
+public interface UndertowBuilderCustomizer {
+
+	/**
+	 * @param builder the {@code Builder} to customize
+	 */
+	void customize(Builder builder);
+
+}

spring-boot/src/main/java/org/springframework/boot/context/embedded/undertow/UndertowEmbeddedServletContainer.java

+/*
+ * Copyright 2012-2014 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 package org.springframework.boot.context.embedded.undertow;
 
 import io.undertow.Handlers;
@@ -14,16 +30,29 @@ import org.springframework.boot.context.embedded.EmbeddedServletContainerExcepti
 import org.springframework.util.StringUtils;
 
 /**
+ * {@link EmbeddedServletContainer} that can be used to control an embedded Undertow
+ * server. Typically this class should be created using
+ * {@link UndertowEmbeddedServletContainerFactory} and not directly.
+ *
  * @author Ivan Sopov
+ * @author Andy Wilkinson
+ * @since 1.2.0
+ * @see UndertowEmbeddedServletContainer
  */
 public class UndertowEmbeddedServletContainer implements EmbeddedServletContainer {
 
 	private final DeploymentManager manager;
+
 	private final Builder builder;
+
 	private final String contextPath;
+
 	private final int port;
+
 	private final boolean autoStart;
+
 	private Undertow undertow;
+
 	private boolean started = false;
 
 	public UndertowEmbeddedServletContainer(Builder builder, DeploymentManager manager,
@@ -40,38 +69,39 @@ public class UndertowEmbeddedServletContainer implements EmbeddedServletContaine
 		if (!this.autoStart) {
 			return;
 		}
-		if (undertow == null) {
+		if (this.undertow == null) {
 			try {
-				HttpHandler servletHandler = manager.start();
-				if (StringUtils.isEmpty(contextPath)) {
-					builder.setHandler(servletHandler);
+				HttpHandler servletHandler = this.manager.start();
+				if (StringUtils.isEmpty(this.contextPath)) {
+					this.builder.setHandler(servletHandler);
 				}
 				else {
-					PathHandler pathHandler = Handlers.path().addPrefixPath(contextPath,
-							servletHandler);
-					builder.setHandler(pathHandler);
+					PathHandler pathHandler = Handlers.path().addPrefixPath(
+							this.contextPath, servletHandler);
+					this.builder.setHandler(pathHandler);
 				}
-				undertow = builder.build();
+				this.undertow = this.builder.build();
 			}
 			catch (ServletException ex) {
 				throw new EmbeddedServletContainerException(
 						"Unable to start embdedded Undertow", ex);
 			}
 		}
-		undertow.start();
-		started = true;
+		this.undertow.start();
+		this.started = true;
 	}
 
 	@Override
 	public synchronized void stop() throws EmbeddedServletContainerException {
-		if (started) {
-			started = false;
-			undertow.stop();
+		if (this.started) {
+			this.started = false;
+			this.undertow.stop();
 		}
 	}
 
 	@Override
 	public int getPort() {
-		return port;
+		return this.port;
 	}
+
 }
\ No newline at end of file

spring-boot/src/main/java/org/springframework/boot/context/embedded/undertow/package-info.java

+/*
+ * Copyright 2012-2014 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * Support for Undertow {@link org.springframework.boot.context.embedded.EmbeddedServletContainer EmbeddedServletContainers}.
+ *
+ * @see org.springframework.boot.context.embedded.undertow.UndertowEmbeddedServletContainerFactory
+ */
+package org.springframework.boot.context.embedded.undertow;
+

spring-boot/src/test/java/org/springframework/boot/context/embedded/EmbeddedServletContainerMvcIntegrationTests.java

@@ -49,6 +49,7 @@ import static org.junit.Assert.assertThat;
  * {@link EmbeddedServletContainer}s running Spring MVC.
  *
  * @author Phillip Webb
+ * @author Ivan Sopov
  */
 public class EmbeddedServletContainerMvcIntegrationTests {
 
@@ -69,7 +70,7 @@ public class EmbeddedServletContainerMvcIntegrationTests {
 				TomcatConfig.class);
 		doTest(this.context, "/hello");
 	}
-	
+
 	@Test
 	public void jetty() throws Exception {
 		this.context = new AnnotationConfigEmbeddedWebApplicationContext(
@@ -83,9 +84,6 @@ public class EmbeddedServletContainerMvcIntegrationTests {
 				UndertowConfig.class);
 		doTest(this.context, "/hello");
 	}
-	
-
-	
 
 	@Test
 	public void advancedConfig() throws Exception {
@@ -128,7 +126,7 @@ public class EmbeddedServletContainerMvcIntegrationTests {
 			return new JettyEmbeddedServletContainerFactory(0);
 		}
 	}
-	
+
 	@Configuration
 	@Import(Config.class)
 	public static class UndertowConfig {

spring-boot/src/test/java/org/springframework/boot/context/embedded/undertow/UndertowEmbeddedServletContainerFactoryTests.java

+/*
+ * Copyright 2012-2014 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 package org.springframework.boot.context.embedded.undertow;
+
+import io.undertow.Undertow.Builder;
+
+import java.util.Arrays;
+
 import org.junit.Test;
-import org.springframework.boot.context.embedded.*;
+import org.mockito.InOrder;
+import org.springframework.boot.context.embedded.AbstractEmbeddedServletContainerFactory;
+import org.springframework.boot.context.embedded.AbstractEmbeddedServletContainerFactoryTests;
+import org.springframework.boot.context.embedded.ErrorPage;
+import org.springframework.boot.context.embedded.ExampleServlet;
+import org.springframework.boot.context.embedded.ServletRegistrationBean;
 import org.springframework.http.HttpStatus;
 
 import static org.hamcrest.Matchers.equalTo;
 import static org.junit.Assert.assertThat;
-
+import static org.mockito.Matchers.anyObject;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
 
 /**
- * Tests for {@link org.springframework.boot.context.embedded.undertow.UndertowEmbeddedServletContainerFactory} and
- * {@link org.springframework.boot.context.embedded.undertow.UndertowEmbeddedServletContainer}.
+ * Tests for {@link UndertowEmbeddedServletContainerFactory} and
+ * {@link UndertowEmbeddedServletContainer} .
  *
  * @author Ivan Sopov
+ * @author Andy Wilkinson
  */
-public class UndertowEmbeddedServletContainerFactoryTests extends AbstractEmbeddedServletContainerFactoryTests
-{
-
-    @Override
-    protected UndertowEmbeddedServletContainerFactory getFactory()
-    {
-        return new UndertowEmbeddedServletContainerFactory();
-    }
-
-    @Test
-    public void errorPage404() throws Exception {
-        AbstractEmbeddedServletContainerFactory factory = getFactory();
-        factory.addErrorPages(new ErrorPage(HttpStatus.NOT_FOUND, "/hello"));
-        this.container = factory.getEmbeddedServletContainer(new ServletRegistrationBean(new ExampleServlet(), "/hello"));
-        this.container.start();
-        assertThat(getResponse("http://localhost:8080/hello"), equalTo("Hello World"));
-        assertThat(getResponse("http://localhost:8080/not-found"), equalTo("Hello World"));
-    }
+public class UndertowEmbeddedServletContainerFactoryTests extends
+		AbstractEmbeddedServletContainerFactoryTests {
+
+	@Override
+	protected UndertowEmbeddedServletContainerFactory getFactory() {
+		return new UndertowEmbeddedServletContainerFactory(0);
+	}
+
+	@Test
+	public void errorPage404() throws Exception {
+		AbstractEmbeddedServletContainerFactory factory = getFactory();
+		factory.addErrorPages(new ErrorPage(HttpStatus.NOT_FOUND, "/hello"));
+		this.container = factory.getEmbeddedServletContainer(new ServletRegistrationBean(
+				new ExampleServlet(), "/hello"));
+		this.container.start();
+		assertThat(getResponse(getLocalUrl("/hello")), equalTo("Hello World"));
+		assertThat(getResponse(getLocalUrl("/not-found")), equalTo("Hello World"));
+	}
+
+	@Test
+	public void setNullUndertowBuilderCustomizersThrows() {
+		UndertowEmbeddedServletContainerFactory factory = getFactory();
+		this.thrown.expect(IllegalArgumentException.class);
+		this.thrown.expectMessage("undertowBuilderCustomizers must not be null");
+		factory.setUndertowBuilderCustomizers(null);
+	}
+
+	@Test
+	public void addNullContextCustomizersThrows() {
+		UndertowEmbeddedServletContainerFactory factory = getFactory();
+		this.thrown.expect(IllegalArgumentException.class);
+		this.thrown.expectMessage("undertowBuilderCustomizers must not be null");
+		factory.addUndertowBuilderCustomizers((UndertowBuilderCustomizer[]) null);
+	}
+
+	@Test
+	public void builderCustomizers() throws Exception {
+		UndertowEmbeddedServletContainerFactory factory = getFactory();
+		UndertowBuilderCustomizer[] customizers = new UndertowBuilderCustomizer[4];
+		for (int i = 0; i < customizers.length; i++) {
+			customizers[i] = mock(UndertowBuilderCustomizer.class);
+		}
+		factory.setUndertowBuilderCustomizers(Arrays.asList(customizers[0],
+				customizers[1]));
+		factory.addUndertowBuilderCustomizers(customizers[2], customizers[3]);
+		this.container = factory.getEmbeddedServletContainer();
+		InOrder ordered = inOrder((Object[]) customizers);
+		for (UndertowBuilderCustomizer customizer : customizers) {
+			ordered.verify(customizer).customize((Builder) anyObject());
+		}
+	}
 }