Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
18d99245
Commit
18d99245
authored
Jul 12, 2016
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch '1.3.x
parents
bf8a8167
c2db9fa3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
28 additions
and
2 deletions
+28
-2
SpringApplicationAdminMXBeanRegistrar.java
...ork/boot/admin/SpringApplicationAdminMXBeanRegistrar.java
+5
-2
SpringApplicationAdminMXBeanRegistrarTests.java
...oot/admin/SpringApplicationAdminMXBeanRegistrarTests.java
+23
-0
No files found.
spring-boot/src/main/java/org/springframework/boot/admin/SpringApplicationAdminMXBeanRegistrar.java
View file @
18d99245
/*
* Copyright 2012-201
5
the original author or authors.
* Copyright 2012-201
6
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
@@ -44,6 +44,7 @@ import org.springframework.util.Assert;
* {@link MBeanServer}.
*
* @author Stephane Nicoll
* @author Andy Wilkinson
* @since 1.3.0
*/
public
class
SpringApplicationAdminMXBeanRegistrar
...
...
@@ -80,7 +81,9 @@ public class SpringApplicationAdminMXBeanRegistrar
@Override
public
void
onApplicationEvent
(
ApplicationReadyEvent
event
)
{
this
.
ready
=
true
;
if
(
this
.
applicationContext
.
equals
(
event
.
getApplicationContext
()))
{
this
.
ready
=
true
;
}
}
@Override
...
...
spring-boot/src/test/java/org/springframework/boot/admin/SpringApplicationAdminMXBeanRegistrarTests.java
View file @
18d99245
...
...
@@ -30,18 +30,22 @@ import org.junit.Test;
import
org.junit.rules.ExpectedException
;
import
org.springframework.boot.SpringApplication
;
import
org.springframework.boot.context.event.ApplicationReadyEvent
;
import
org.springframework.context.ApplicationListener
;
import
org.springframework.context.ConfigurableApplicationContext
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.event.ContextRefreshedEvent
;
import
org.springframework.test.util.ReflectionTestUtils
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
mockito
.
Mockito
.
mock
;
/**
* Tests for {@link SpringApplicationAdminMXBeanRegistrar}.
*
* @author Stephane Nicoll
* @author Andy Wilkinson
*/
public
class
SpringApplicationAdminMXBeanRegistrarTests
{
...
...
@@ -87,6 +91,25 @@ public class SpringApplicationAdminMXBeanRegistrarTests {
assertThat
(
isApplicationReady
(
objectName
)).
isTrue
();
}
@Test
public
void
eventsFromOtherContextsAreIgnored
()
throws
MalformedObjectNameException
{
SpringApplicationAdminMXBeanRegistrar
registrar
=
new
SpringApplicationAdminMXBeanRegistrar
(
OBJECT_NAME
);
ConfigurableApplicationContext
context
=
mock
(
ConfigurableApplicationContext
.
class
);
registrar
.
setApplicationContext
(
context
);
registrar
.
onApplicationEvent
(
new
ApplicationReadyEvent
(
new
SpringApplication
(),
null
,
mock
(
ConfigurableApplicationContext
.
class
)));
assertThat
(
isApplicationReady
(
registrar
)).
isFalse
();
registrar
.
onApplicationEvent
(
new
ApplicationReadyEvent
(
new
SpringApplication
(),
null
,
context
));
assertThat
(
isApplicationReady
(
registrar
)).
isTrue
();
}
private
boolean
isApplicationReady
(
SpringApplicationAdminMXBeanRegistrar
registrar
)
{
return
(
Boolean
)
ReflectionTestUtils
.
getField
(
registrar
,
"ready"
);
}
@Test
public
void
environmentIsExposed
()
{
final
ObjectName
objectName
=
createObjectName
(
OBJECT_NAME
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment