Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
1a3f08d7
Commit
1a3f08d7
authored
Aug 02, 2018
by
artsiom
Committed by
Stephane Nicoll
Aug 06, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add global support for JMX unique names
See gh-13990
parent
c071f34a
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
17 additions
and
0 deletions
+17
-0
JmxAutoConfiguration.java
...ramework/boot/autoconfigure/jmx/JmxAutoConfiguration.java
+6
-0
additional-spring-configuration-metadata.json
...es/META-INF/additional-spring-configuration-metadata.json
+6
-0
JmxAutoConfigurationTests.java
...ork/boot/autoconfigure/jmx/JmxAutoConfigurationTests.java
+4
-0
appendix-application-properties.adoc
...cs/src/main/asciidoc/appendix-application-properties.adoc
+1
-0
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfiguration.java
View file @
1a3f08d7
...
...
@@ -49,6 +49,7 @@ import org.springframework.util.StringUtils;
*
* @author Christian Dupuis
* @author Madhura Bhave
* @author Artsiom Yudovin
*/
@Configuration
@ConditionalOnClass
({
MBeanExporter
.
class
})
...
...
@@ -93,6 +94,11 @@ public class JmxAutoConfiguration implements EnvironmentAware, BeanFactoryAware
if
(
StringUtils
.
hasLength
(
defaultDomain
))
{
namingStrategy
.
setDefaultDomain
(
defaultDomain
);
}
boolean
uniqueName
=
this
.
environment
.
getProperty
(
"spring.jmx.unique-names"
,
Boolean
.
class
,
false
);
namingStrategy
.
setEnsureUniqueRuntimeObjectNames
(
uniqueName
);
return
namingStrategy
;
}
...
...
spring-boot-project/spring-boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json
View file @
1a3f08d7
...
...
@@ -290,6 +290,12 @@
"description"
:
"MBeanServer bean name."
,
"defaultValue"
:
"mbeanServer"
},
{
"name"
:
"spring.jmx.unique-names"
,
"type"
:
"java.lang.Boolean"
,
"description"
:
"Whether to ensure that ObjectNames are modified in case of conflict."
,
"defaultValue"
:
false
},
{
"name"
:
"spring.jpa.open-in-view"
,
"defaultValue"
:
true
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfigurationTests.java
View file @
1a3f08d7
...
...
@@ -42,6 +42,7 @@ import static org.assertj.core.api.Assertions.assertThat;
* Tests for {@link JmxAutoConfiguration}.
*
* @author Christian Dupuis
* @author Artsiom Yudovin
*/
public
class
JmxAutoConfigurationTests
{
...
...
@@ -92,6 +93,7 @@ public class JmxAutoConfigurationTests {
MockEnvironment
env
=
new
MockEnvironment
();
env
.
setProperty
(
"spring.jmx.enabled"
,
"true"
);
env
.
setProperty
(
"spring.jmx.default-domain"
,
"my-test-domain"
);
env
.
setProperty
(
"spring.jmx.unique-names"
,
"true"
);
this
.
context
=
new
AnnotationConfigApplicationContext
();
this
.
context
.
setEnvironment
(
env
);
this
.
context
.
register
(
TestConfiguration
.
class
,
JmxAutoConfiguration
.
class
);
...
...
@@ -102,6 +104,8 @@ public class JmxAutoConfigurationTests {
.
getField
(
mBeanExporter
,
"namingStrategy"
);
assertThat
(
ReflectionTestUtils
.
getField
(
naming
,
"defaultDomain"
))
.
isEqualTo
(
"my-test-domain"
);
assertThat
(
ReflectionTestUtils
.
getField
(
naming
,
"ensureUniqueRuntimeObjectNames"
))
.
isEqualTo
(
true
);
}
@Test
...
...
spring-boot-project/spring-boot-docs/src/main/asciidoc/appendix-application-properties.adoc
View file @
1a3f08d7
...
...
@@ -100,6 +100,7 @@ content into your application. Rather, pick only the properties that you need.
spring.jmx.default-domain= # JMX domain name.
spring.jmx.enabled=true # Expose management beans to the JMX domain.
spring.jmx.server=mbeanServer # MBeanServer bean name.
spring.jmx.unique-names=false # Set if unique runtime object names should be ensured.
# Email ({sc-spring-boot-autoconfigure}/mail/MailProperties.{sc-ext}[MailProperties])
spring.mail.default-encoding=UTF-8 # Default MimeMessage encoding.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment