Commit 1e756db9 authored by Johnny Lim's avatar Johnny Lim Committed by Stephane Nicoll

Use Commons Logging for OnlyOnceLoggingDenyMeterFilter

Closes gh-14637
parent 9a4f655d
......@@ -23,8 +23,8 @@ import io.micrometer.core.instrument.Meter;
import io.micrometer.core.instrument.Meter.Id;
import io.micrometer.core.instrument.config.MeterFilter;
import io.micrometer.core.instrument.config.MeterFilterReply;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.util.Assert;
......@@ -38,8 +38,8 @@ import org.springframework.util.Assert;
*/
public final class OnlyOnceLoggingDenyMeterFilter implements MeterFilter {
private final Logger logger = LoggerFactory
.getLogger(OnlyOnceLoggingDenyMeterFilter.class);
private static final Log logger = LogFactory
.getLog(OnlyOnceLoggingDenyMeterFilter.class);
private final AtomicBoolean alreadyWarned = new AtomicBoolean(false);
......@@ -52,9 +52,8 @@ public final class OnlyOnceLoggingDenyMeterFilter implements MeterFilter {
@Override
public MeterFilterReply accept(Id id) {
if (this.logger.isWarnEnabled()
&& this.alreadyWarned.compareAndSet(false, true)) {
this.logger.warn(this.message.get());
if (logger.isWarnEnabled() && this.alreadyWarned.compareAndSet(false, true)) {
logger.warn(this.message.get());
}
return MeterFilterReply.DENY;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment