Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
21453b50
Commit
21453b50
authored
Jul 02, 2020
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Ignore scoped targets when finding matching beans
Fixes gh-22038
parent
81d6751b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
34 additions
and
3 deletions
+34
-3
OnBeanCondition.java
...amework/boot/autoconfigure/condition/OnBeanCondition.java
+9
-1
ConditionalOnSingleCandidateTests.java
...onfigure/condition/ConditionalOnSingleCandidateTests.java
+25
-2
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java
View file @
21453b50
...
@@ -24,12 +24,14 @@ import java.util.Collection;
...
@@ -24,12 +24,14 @@ import java.util.Collection;
import
java.util.Collections
;
import
java.util.Collections
;
import
java.util.HashMap
;
import
java.util.HashMap
;
import
java.util.HashSet
;
import
java.util.HashSet
;
import
java.util.Iterator
;
import
java.util.LinkedHashSet
;
import
java.util.LinkedHashSet
;
import
java.util.List
;
import
java.util.List
;
import
java.util.Locale
;
import
java.util.Locale
;
import
java.util.Map
;
import
java.util.Map
;
import
java.util.Set
;
import
java.util.Set
;
import
org.springframework.aop.scope.ScopedProxyUtils
;
import
org.springframework.beans.factory.BeanFactory
;
import
org.springframework.beans.factory.BeanFactory
;
import
org.springframework.beans.factory.HierarchicalBeanFactory
;
import
org.springframework.beans.factory.HierarchicalBeanFactory
;
import
org.springframework.beans.factory.ListableBeanFactory
;
import
org.springframework.beans.factory.ListableBeanFactory
;
...
@@ -166,7 +168,13 @@ class OnBeanCondition extends FilteringSpringBootCondition implements Configurat
...
@@ -166,7 +168,13 @@ class OnBeanCondition extends FilteringSpringBootCondition implements Configurat
for
(
String
type
:
spec
.
getTypes
())
{
for
(
String
type
:
spec
.
getTypes
())
{
Collection
<
String
>
typeMatches
=
getBeanNamesForType
(
classLoader
,
considerHierarchy
,
beanFactory
,
type
,
Collection
<
String
>
typeMatches
=
getBeanNamesForType
(
classLoader
,
considerHierarchy
,
beanFactory
,
type
,
parameterizedContainers
);
parameterizedContainers
);
typeMatches
.
removeAll
(
beansIgnoredByType
);
Iterator
<
String
>
iterator
=
typeMatches
.
iterator
();
while
(
iterator
.
hasNext
())
{
String
match
=
iterator
.
next
();
if
(
beansIgnoredByType
.
contains
(
match
)
||
ScopedProxyUtils
.
isScopedTarget
(
match
))
{
iterator
.
remove
();
}
}
if
(
typeMatches
.
isEmpty
())
{
if
(
typeMatches
.
isEmpty
())
{
result
.
recordUnmatchedType
(
type
);
result
.
recordUnmatchedType
(
type
);
}
}
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnSingleCandidateTests.java
View file @
21453b50
...
@@ -22,6 +22,8 @@ import org.springframework.boot.test.context.runner.ApplicationContextRunner;
...
@@ -22,6 +22,8 @@ import org.springframework.boot.test.context.runner.ApplicationContextRunner;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Primary
;
import
org.springframework.context.annotation.Primary
;
import
org.springframework.context.annotation.Scope
;
import
org.springframework.context.annotation.ScopedProxyMode
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
@@ -50,6 +52,16 @@ class ConditionalOnSingleCandidateTests {
...
@@ -50,6 +52,16 @@ class ConditionalOnSingleCandidateTests {
});
});
}
}
@Test
void
singleCandidateOneScopedProxyCandidate
()
{
this
.
contextRunner
.
withUserConfiguration
(
AlphaScopedProxyConfiguration
.
class
,
OnBeanSingleCandidateConfiguration
.
class
)
.
run
((
context
)
->
{
assertThat
(
context
).
hasBean
(
"consumer"
);
assertThat
(
context
.
getBean
(
"consumer"
).
toString
()).
isEqualTo
(
"alpha"
);
});
}
@Test
@Test
void
singleCandidateInAncestorsOneCandidateInCurrent
()
{
void
singleCandidateInAncestorsOneCandidateInCurrent
()
{
this
.
contextRunner
.
run
((
parent
)
->
this
.
contextRunner
this
.
contextRunner
.
run
((
parent
)
->
this
.
contextRunner
...
@@ -138,7 +150,7 @@ class ConditionalOnSingleCandidateTests {
...
@@ -138,7 +150,7 @@ class ConditionalOnSingleCandidateTests {
static
class
OnBeanSingleCandidateConfiguration
{
static
class
OnBeanSingleCandidateConfiguration
{
@Bean
@Bean
String
consumer
(
String
s
)
{
CharSequence
consumer
(
CharSequence
s
)
{
return
s
;
return
s
;
}
}
...
@@ -149,7 +161,7 @@ class ConditionalOnSingleCandidateTests {
...
@@ -149,7 +161,7 @@ class ConditionalOnSingleCandidateTests {
static
class
OnBeanSingleCandidateInAncestorsConfiguration
{
static
class
OnBeanSingleCandidateInAncestorsConfiguration
{
@Bean
@Bean
String
consumer
(
String
s
)
{
CharSequence
consumer
(
CharSequence
s
)
{
return
s
;
return
s
;
}
}
...
@@ -188,6 +200,17 @@ class ConditionalOnSingleCandidateTests {
...
@@ -188,6 +200,17 @@ class ConditionalOnSingleCandidateTests {
}
}
@Configuration
(
proxyBeanMethods
=
false
)
static
class
AlphaScopedProxyConfiguration
{
@Bean
@Scope
(
proxyMode
=
ScopedProxyMode
.
INTERFACES
)
String
alpha
()
{
return
"alpha"
;
}
}
@Configuration
(
proxyBeanMethods
=
false
)
@Configuration
(
proxyBeanMethods
=
false
)
static
class
BravoConfiguration
{
static
class
BravoConfiguration
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment