Commit 2236e959 authored by Stephane Nicoll's avatar Stephane Nicoll

Merge pull request #16018 from nosan

* pr/16018:
  Polish "Debug mode is not logging web and sql related loggers"
  Debug mode is not logging web and sql related loggers
parents 130ef102 978f8012
/* /*
* Copyright 2012-2018 the original author or authors. * Copyright 2012-2019 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
...@@ -320,12 +320,10 @@ public class LoggingApplicationListener implements GenericApplicationListener { ...@@ -320,12 +320,10 @@ public class LoggingApplicationListener implements GenericApplicationListener {
} }
protected void initializeLogLevel(LoggingSystem system, LogLevel level) { protected void initializeLogLevel(LoggingSystem system, LogLevel level) {
List<String> loggers = LOG_LEVEL_LOGGERS.get(level); LOG_LEVEL_LOGGERS.getOrDefault(level, Collections.emptyList()).stream()
if (loggers != null) { .flatMap((logger) -> DEFAULT_GROUP_LOGGERS
for (String logger : loggers) { .getOrDefault(logger, Collections.singletonList(logger)).stream())
system.setLogLevel(logger, level); .forEach((logger) -> system.setLogLevel(logger, level));
}
}
} }
protected void setLogLevels(LoggingSystem system, Environment environment) { protected void setLogLevels(LoggingSystem system, Environment environment) {
......
/* /*
* Copyright 2012-2018 the original author or authors. * Copyright 2012-2019 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
...@@ -262,6 +262,18 @@ public class LoggingApplicationListenerTests { ...@@ -262,6 +262,18 @@ public class LoggingApplicationListenerTests {
assertThat(this.outputCapture.toString()).doesNotContain("testattrace"); assertThat(this.outputCapture.toString()).doesNotContain("testattrace");
} }
@Test
public void parseDebugArgExpandGroups() {
TestPropertySourceUtils.addInlinedPropertiesToEnvironment(this.context, "debug");
this.initializer.initialize(this.context.getEnvironment(),
this.context.getClassLoader());
this.logFactory.getInstance("org.springframework.boot.actuate.endpoint.web")
.debug("testdebugwebgroup");
this.logFactory.getInstance("org.hibernate.SQL").debug("testdebugsqlgroup");
assertThat(this.outputCapture.toString()).contains("testdebugwebgroup");
assertThat(this.outputCapture.toString()).contains("testdebugsqlgroup");
}
@Test @Test
public void parseTraceArg() { public void parseTraceArg() {
TestPropertySourceUtils.addInlinedPropertiesToEnvironment(this.context, "trace"); TestPropertySourceUtils.addInlinedPropertiesToEnvironment(this.context, "trace");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment