Commit 223f2be7 authored by Madhura Bhave's avatar Madhura Bhave

Inject InfoContributors instead of exposing them on InfoEndpoint

Closes gh-13586
parent 2cdc93cf
...@@ -24,6 +24,7 @@ import java.util.List; ...@@ -24,6 +24,7 @@ import java.util.List;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import org.springframework.beans.BeansException; import org.springframework.beans.BeansException;
import org.springframework.beans.factory.ObjectProvider;
import org.springframework.beans.factory.config.BeanPostProcessor; import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.boot.actuate.autoconfigure.cloudfoundry.CloudFoundryWebEndpointDiscoverer; import org.springframework.boot.actuate.autoconfigure.cloudfoundry.CloudFoundryWebEndpointDiscoverer;
import org.springframework.boot.actuate.autoconfigure.cloudfoundry.servlet.CloudFoundryInfoEndpointWebExtension; import org.springframework.boot.actuate.autoconfigure.cloudfoundry.servlet.CloudFoundryInfoEndpointWebExtension;
...@@ -99,9 +100,8 @@ public class ReactiveCloudFoundryActuatorAutoConfiguration { ...@@ -99,9 +100,8 @@ public class ReactiveCloudFoundryActuatorAutoConfiguration {
@ConditionalOnExposedEndpoint @ConditionalOnExposedEndpoint
@ConditionalOnBean({ InfoEndpoint.class, GitProperties.class }) @ConditionalOnBean({ InfoEndpoint.class, GitProperties.class })
public CloudFoundryInfoEndpointWebExtension cloudFoundryInfoEndpointWebExtension( public CloudFoundryInfoEndpointWebExtension cloudFoundryInfoEndpointWebExtension(
InfoEndpoint infoEndpoint, GitProperties properties) { GitProperties properties, ObjectProvider<InfoContributor> infoContributors) {
List<InfoContributor> existingContributors = infoEndpoint.getInfoContributors(); List<InfoContributor> contributors = infoContributors.orderedStream()
List<InfoContributor> contributors = existingContributors.stream()
.map((infoContributor) -> { .map((infoContributor) -> {
if (infoContributor instanceof GitInfoContributor) { if (infoContributor instanceof GitInfoContributor) {
return new GitInfoContributor(properties, return new GitInfoContributor(properties,
......
...@@ -23,6 +23,7 @@ import java.util.Collections; ...@@ -23,6 +23,7 @@ import java.util.Collections;
import java.util.List; import java.util.List;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import org.springframework.beans.factory.ObjectProvider;
import org.springframework.boot.actuate.autoconfigure.cloudfoundry.CloudFoundryWebEndpointDiscoverer; import org.springframework.boot.actuate.autoconfigure.cloudfoundry.CloudFoundryWebEndpointDiscoverer;
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint; import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint;
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnExposedEndpoint; import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnExposedEndpoint;
...@@ -100,9 +101,8 @@ public class CloudFoundryActuatorAutoConfiguration { ...@@ -100,9 +101,8 @@ public class CloudFoundryActuatorAutoConfiguration {
@ConditionalOnExposedEndpoint @ConditionalOnExposedEndpoint
@ConditionalOnBean({ InfoEndpoint.class, GitProperties.class }) @ConditionalOnBean({ InfoEndpoint.class, GitProperties.class })
public CloudFoundryInfoEndpointWebExtension cloudFoundryInfoEndpointWebExtension( public CloudFoundryInfoEndpointWebExtension cloudFoundryInfoEndpointWebExtension(
InfoEndpoint infoEndpoint, GitProperties properties) { GitProperties properties, ObjectProvider<InfoContributor> infoContributors) {
List<InfoContributor> existingContributors = infoEndpoint.getInfoContributors(); List<InfoContributor> contributors = infoContributors.orderedStream()
List<InfoContributor> contributors = existingContributors.stream()
.map((infoContributor) -> { .map((infoContributor) -> {
if (infoContributor instanceof GitInfoContributor) { if (infoContributor instanceof GitInfoContributor) {
return new GitInfoContributor(properties, return new GitInfoContributor(properties,
......
...@@ -55,8 +55,4 @@ public class InfoEndpoint { ...@@ -55,8 +55,4 @@ public class InfoEndpoint {
return build.getDetails(); return build.getDetails();
} }
public List<InfoContributor> getInfoContributors() {
return this.infoContributors;
}
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment