Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
278b20d9
Commit
278b20d9
authored
Mar 15, 2019
by
Semyon Danilov
Committed by
Andy Wilkinson
Aug 30, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Upgrade to Flyway 6.0.1
See gh-17997
parent
1e2f8959
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
37 additions
and
86 deletions
+37
-86
FlywayAutoConfiguration.java
...rk/boot/autoconfigure/flyway/FlywayAutoConfiguration.java
+7
-14
FlywayAutoConfigurationTests.java
...ot/autoconfigure/flyway/FlywayAutoConfigurationTests.java
+26
-67
FlywayPropertiesTests.java
...work/boot/autoconfigure/flyway/FlywayPropertiesTests.java
+3
-4
pom.xml
spring-boot-project/spring-boot-dependencies/pom.xml
+1
-1
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration.java
View file @
278b20d9
...
...
@@ -30,7 +30,6 @@ import javax.sql.DataSource;
import
org.flywaydb.core.Flyway
;
import
org.flywaydb.core.api.MigrationVersion
;
import
org.flywaydb.core.api.callback.Callback
;
import
org.flywaydb.core.api.callback.FlywayCallback
;
import
org.flywaydb.core.api.configuration.FluentConfiguration
;
import
org.springframework.beans.factory.ObjectProvider
;
...
...
@@ -81,6 +80,7 @@ import org.springframework.util.StringUtils;
* @author Dominic Gunn
* @author Dan Zheng
* @author András Deák
* @author Semyon Danilov
* @since 1.1.0
*/
@SuppressWarnings
(
"deprecation"
)
...
...
@@ -113,7 +113,7 @@ public class FlywayAutoConfiguration {
ResourceLoader
resourceLoader
,
ObjectProvider
<
DataSource
>
dataSource
,
@FlywayDataSource
ObjectProvider
<
DataSource
>
flywayDataSource
,
ObjectProvider
<
FlywayConfigurationCustomizer
>
fluentConfigurationCustomizers
,
ObjectProvider
<
Callback
>
callbacks
,
ObjectProvider
<
FlywayCallback
>
flywayCallbacks
)
{
ObjectProvider
<
Callback
>
callbacks
)
{
FluentConfiguration
configuration
=
new
FluentConfiguration
(
resourceLoader
.
getClassLoader
());
DataSource
dataSourceToMigrate
=
configureDataSource
(
configuration
,
properties
,
dataSourceProperties
,
flywayDataSource
.
getIfAvailable
(),
dataSource
.
getIfAvailable
());
...
...
@@ -122,10 +122,8 @@ public class FlywayAutoConfiguration {
List
<
Callback
>
orderedCallbacks
=
callbacks
.
orderedStream
().
collect
(
Collectors
.
toList
());
configureCallbacks
(
configuration
,
orderedCallbacks
);
fluentConfigurationCustomizers
.
orderedStream
().
forEach
((
customizer
)
->
customizer
.
customize
(
configuration
));
Flyway
flyway
=
configuration
.
load
();
List
<
FlywayCallback
>
orderedFlywayCallbacks
=
flywayCallbacks
.
orderedStream
().
collect
(
Collectors
.
toList
());
configureFlywayCallbacks
(
flyway
,
orderedCallbacks
,
orderedFlywayCallbacks
);
return
flyway
;
configureFlywayCallbacks
(
configuration
,
orderedCallbacks
);
return
configuration
.
load
();
}
private
DataSource
configureDataSource
(
FluentConfiguration
configuration
,
FlywayProperties
properties
,
...
...
@@ -210,14 +208,9 @@ public class FlywayAutoConfiguration {
}
}
private
void
configureFlywayCallbacks
(
Flyway
flyway
,
List
<
Callback
>
callbacks
,
List
<
FlywayCallback
>
flywayCallbacks
)
{
if
(!
flywayCallbacks
.
isEmpty
())
{
if
(!
callbacks
.
isEmpty
())
{
throw
new
IllegalStateException
(
"Found a mixture of Callback and FlywayCallback beans."
+
" One type must be used exclusively."
);
}
flyway
.
setCallbacks
(
flywayCallbacks
.
toArray
(
new
FlywayCallback
[
0
]));
private
void
configureFlywayCallbacks
(
FluentConfiguration
flyway
,
List
<
Callback
>
callbacks
)
{
if
(!
callbacks
.
isEmpty
())
{
flyway
.
callbacks
(
callbacks
.
toArray
(
new
Callback
[
0
]));
}
}
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfigurationTests.java
View file @
278b20d9
This diff is collapsed.
Click to expand it.
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayPropertiesTests.java
View file @
278b20d9
...
...
@@ -96,9 +96,10 @@ class FlywayPropertiesTests {
ignoreProperties
(
properties
,
"url"
,
"user"
,
"password"
,
"enabled"
,
"checkLocation"
,
"createDataSource"
);
// High level object we can't set with properties
ignoreProperties
(
configuration
,
"classLoader"
,
"dataSource"
,
"resolvers"
,
"callbacks"
);
ignoreProperties
(
configuration
,
"classLoader"
,
"dataSource"
,
"resolvers"
,
"callbacks"
,
"javaMigrations"
);
// Properties we don't want to expose
ignoreProperties
(
configuration
,
"resolversAsClassNames"
,
"callbacksAsClassNames"
);
ignoreProperties
(
configuration
,
"resolversAsClassNames"
,
"callbacksAsClassNames"
,
"tablespace"
,
"oracleSqlplusWarn"
);
// Handled by the conversion service
ignoreProperties
(
configuration
,
"baselineVersionAsString"
,
"encodingAsString"
,
"locationsAsStrings"
,
"targetAsString"
);
...
...
@@ -107,8 +108,6 @@ class FlywayPropertiesTests {
ignoreProperties
(
properties
,
"initSqls"
);
// Handled as dryRunOutput
ignoreProperties
(
configuration
,
"dryRunOutputAsFile"
,
"dryRunOutputAsFileName"
);
// Deprecated
ignoreProperties
(
configuration
,
"errorHandlers"
,
"errorHandlersAsClassNames"
);
List
<
String
>
configurationKeys
=
new
ArrayList
<>(
configuration
.
keySet
());
Collections
.
sort
(
configurationKeys
);
List
<
String
>
propertiesKeys
=
new
ArrayList
<>(
properties
.
keySet
());
...
...
spring-boot-project/spring-boot-dependencies/pom.xml
View file @
278b20d9
...
...
@@ -60,7 +60,7 @@
<ehcache.version>
2.10.6
</ehcache.version>
<ehcache3.version>
3.8.0
</ehcache3.version>
<embedded-mongo.version>
2.2.0
</embedded-mongo.version>
<flyway.version>
5.2.4
</flyway.version>
<flyway.version>
6.0.1
</flyway.version>
<freemarker.version>
2.3.28
</freemarker.version>
<elasticsearch.version>
6.8.2
</elasticsearch.version>
<glassfish-el.version>
3.0.2
</glassfish-el.version>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment