Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
335f9590
Commit
335f9590
authored
Jul 10, 2019
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #17444 from dreis2211
* gh-17444: Use Assertions.contentOf() where possible Closes gh-17444
parents
69d77ee2
25586a2e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
18 deletions
+6
-18
LogFileWebEndpointAutoConfigurationTests.java
...ure/logging/LogFileWebEndpointAutoConfigurationTests.java
+2
-6
LogFileWebEndpointTests.java
...amework/boot/actuate/logging/LogFileWebEndpointTests.java
+4
-12
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/logging/LogFileWebEndpointAutoConfigurationTests.java
View file @
335f9590
...
@@ -18,8 +18,6 @@ package org.springframework.boot.actuate.autoconfigure.logging;
...
@@ -18,8 +18,6 @@ package org.springframework.boot.actuate.autoconfigure.logging;
import
java.io.File
;
import
java.io.File
;
import
java.io.IOException
;
import
java.io.IOException
;
import
java.io.InputStream
;
import
java.nio.charset.StandardCharsets
;
import
java.nio.file.Path
;
import
java.nio.file.Path
;
import
org.junit.jupiter.api.Test
;
import
org.junit.jupiter.api.Test
;
...
@@ -30,9 +28,9 @@ import org.springframework.boot.autoconfigure.AutoConfigurations;
...
@@ -30,9 +28,9 @@ import org.springframework.boot.autoconfigure.AutoConfigurations;
import
org.springframework.boot.test.context.runner.WebApplicationContextRunner
;
import
org.springframework.boot.test.context.runner.WebApplicationContextRunner
;
import
org.springframework.core.io.Resource
;
import
org.springframework.core.io.Resource
;
import
org.springframework.util.FileCopyUtils
;
import
org.springframework.util.FileCopyUtils
;
import
org.springframework.util.StreamUtils
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
contentOf
;
/**
/**
* Tests for {@link LogFileWebEndpointAutoConfiguration}.
* Tests for {@link LogFileWebEndpointAutoConfiguration}.
...
@@ -119,9 +117,7 @@ class LogFileWebEndpointAutoConfigurationTests {
...
@@ -119,9 +117,7 @@ class LogFileWebEndpointAutoConfigurationTests {
LogFileWebEndpoint
endpoint
=
context
.
getBean
(
LogFileWebEndpoint
.
class
);
LogFileWebEndpoint
endpoint
=
context
.
getBean
(
LogFileWebEndpoint
.
class
);
Resource
resource
=
endpoint
.
logFile
();
Resource
resource
=
endpoint
.
logFile
();
assertThat
(
resource
).
isNotNull
();
assertThat
(
resource
).
isNotNull
();
try
(
InputStream
input
=
resource
.
getInputStream
())
{
assertThat
(
contentOf
(
resource
.
getFile
())).
isEqualTo
(
"--TEST--"
);
assertThat
(
StreamUtils
.
copyToString
(
input
,
StandardCharsets
.
UTF_8
)).
isEqualTo
(
"--TEST--"
);
}
});
});
}
}
...
...
spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/logging/LogFileWebEndpointTests.java
View file @
335f9590
...
@@ -18,8 +18,6 @@ package org.springframework.boot.actuate.logging;
...
@@ -18,8 +18,6 @@ package org.springframework.boot.actuate.logging;
import
java.io.File
;
import
java.io.File
;
import
java.io.IOException
;
import
java.io.IOException
;
import
java.io.InputStream
;
import
java.nio.charset.StandardCharsets
;
import
java.nio.file.Files
;
import
java.nio.file.Files
;
import
java.nio.file.Path
;
import
java.nio.file.Path
;
...
@@ -30,9 +28,9 @@ import org.junit.jupiter.api.io.TempDir;
...
@@ -30,9 +28,9 @@ import org.junit.jupiter.api.io.TempDir;
import
org.springframework.core.io.Resource
;
import
org.springframework.core.io.Resource
;
import
org.springframework.mock.env.MockEnvironment
;
import
org.springframework.mock.env.MockEnvironment
;
import
org.springframework.util.FileCopyUtils
;
import
org.springframework.util.FileCopyUtils
;
import
org.springframework.util.StreamUtils
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
contentOf
;
/**
/**
* Tests for {@link LogFileWebEndpoint}.
* Tests for {@link LogFileWebEndpoint}.
...
@@ -71,7 +69,7 @@ class LogFileWebEndpointTests {
...
@@ -71,7 +69,7 @@ class LogFileWebEndpointTests {
this
.
environment
.
setProperty
(
"logging.file.name"
,
this
.
logFile
.
getAbsolutePath
());
this
.
environment
.
setProperty
(
"logging.file.name"
,
this
.
logFile
.
getAbsolutePath
());
Resource
resource
=
this
.
endpoint
.
logFile
();
Resource
resource
=
this
.
endpoint
.
logFile
();
assertThat
(
resource
).
isNotNull
();
assertThat
(
resource
).
isNotNull
();
assertThat
(
contentOf
(
resource
)).
isEqualTo
(
"--TEST--"
);
assertThat
(
contentOf
(
resource
.
getFile
()
)).
isEqualTo
(
"--TEST--"
);
}
}
@Test
@Test
...
@@ -80,7 +78,7 @@ class LogFileWebEndpointTests {
...
@@ -80,7 +78,7 @@ class LogFileWebEndpointTests {
this
.
environment
.
setProperty
(
"logging.file"
,
this
.
logFile
.
getAbsolutePath
());
this
.
environment
.
setProperty
(
"logging.file"
,
this
.
logFile
.
getAbsolutePath
());
Resource
resource
=
this
.
endpoint
.
logFile
();
Resource
resource
=
this
.
endpoint
.
logFile
();
assertThat
(
resource
).
isNotNull
();
assertThat
(
resource
).
isNotNull
();
assertThat
(
contentOf
(
resource
)).
isEqualTo
(
"--TEST--"
);
assertThat
(
contentOf
(
resource
.
getFile
()
)).
isEqualTo
(
"--TEST--"
);
}
}
@Test
@Test
...
@@ -88,13 +86,7 @@ class LogFileWebEndpointTests {
...
@@ -88,13 +86,7 @@ class LogFileWebEndpointTests {
LogFileWebEndpoint
endpoint
=
new
LogFileWebEndpoint
(
this
.
environment
,
this
.
logFile
);
LogFileWebEndpoint
endpoint
=
new
LogFileWebEndpoint
(
this
.
environment
,
this
.
logFile
);
Resource
resource
=
endpoint
.
logFile
();
Resource
resource
=
endpoint
.
logFile
();
assertThat
(
resource
).
isNotNull
();
assertThat
(
resource
).
isNotNull
();
assertThat
(
contentOf
(
resource
)).
isEqualTo
(
"--TEST--"
);
assertThat
(
contentOf
(
resource
.
getFile
())).
isEqualTo
(
"--TEST--"
);
}
private
String
contentOf
(
Resource
resource
)
throws
IOException
{
try
(
InputStream
input
=
resource
.
getInputStream
())
{
return
StreamUtils
.
copyToString
(
input
,
StandardCharsets
.
UTF_8
);
}
}
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment