Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
39aa27e1
Commit
39aa27e1
authored
Jun 10, 2021
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make DB init back off without DatabasePopulator
Fixes gh-26850
parent
2835085f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
27 additions
and
1 deletion
+27
-1
DataSourceInitializationConfiguration.java
...igure/sql/init/DataSourceInitializationConfiguration.java
+3
-0
R2dbcInitializationConfiguration.java
...oconfigure/sql/init/R2dbcInitializationConfiguration.java
+2
-1
SqlInitializationAutoConfigurationTests.java
...ure/sql/init/SqlInitializationAutoConfigurationTests.java
+22
-0
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/sql/init/DataSourceInitializationConfiguration.java
View file @
39aa27e1
...
...
@@ -18,6 +18,7 @@ package org.springframework.boot.autoconfigure.sql.init;
import
javax.sql.DataSource
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnClass
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnSingleCandidate
;
import
org.springframework.boot.jdbc.DataSourceBuilder
;
...
...
@@ -27,11 +28,13 @@ import org.springframework.boot.sql.init.DatabaseInitializationSettings;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.jdbc.datasource.SimpleDriverDataSource
;
import
org.springframework.jdbc.datasource.init.DatabasePopulator
;
import
org.springframework.util.StringUtils
;
@Configuration
(
proxyBeanMethods
=
false
)
@ConditionalOnMissingBean
(
AbstractScriptDatabaseInitializer
.
class
)
@ConditionalOnSingleCandidate
(
DataSource
.
class
)
@ConditionalOnClass
(
DatabasePopulator
.
class
)
class
DataSourceInitializationConfiguration
{
@Bean
...
...
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/sql/init/R2dbcInitializationConfiguration.java
View file @
39aa27e1
...
...
@@ -25,6 +25,7 @@ import org.springframework.boot.r2dbc.init.R2dbcScriptDatabaseInitializer;
import
org.springframework.boot.sql.init.DatabaseInitializationSettings
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.r2dbc.connection.init.DatabasePopulator
;
import
org.springframework.util.StringUtils
;
/**
...
...
@@ -34,7 +35,7 @@ import org.springframework.util.StringUtils;
* @author Andy Wilkinson
*/
@Configuration
(
proxyBeanMethods
=
false
)
@ConditionalOnClass
(
ConnectionFactory
.
class
)
@ConditionalOnClass
(
{
ConnectionFactory
.
class
,
DatabasePopulator
.
class
}
)
@ConditionalOnSingleCandidate
(
ConnectionFactory
.
class
)
class
R2dbcInitializationConfiguration
{
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/sql/init/SqlInitializationAutoConfigurationTests.java
View file @
39aa27e1
...
...
@@ -35,10 +35,12 @@ import org.springframework.boot.r2dbc.init.R2dbcScriptDatabaseInitializer;
import
org.springframework.boot.sql.init.AbstractScriptDatabaseInitializer
;
import
org.springframework.boot.sql.init.DatabaseInitializationSettings
;
import
org.springframework.boot.sql.init.dependency.DependsOnDatabaseInitialization
;
import
org.springframework.boot.test.context.FilteredClassLoader
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.core.io.Resource
;
import
org.springframework.jdbc.datasource.init.DatabasePopulator
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
...
@@ -141,6 +143,26 @@ public class SqlInitializationAutoConfigurationTests {
});
}
@Test
void
whenADataSourceIsAvailableAndSpringJdbcIsNotThenAutoConfigurationBacksOff
()
{
this
.
contextRunner
.
withConfiguration
(
AutoConfigurations
.
of
(
DataSourceAutoConfiguration
.
class
))
.
withClassLoader
(
new
FilteredClassLoader
(
DatabasePopulator
.
class
)).
run
((
context
)
->
{
assertThat
(
context
).
hasSingleBean
(
DataSource
.
class
);
assertThat
(
context
).
doesNotHaveBean
(
AbstractScriptDatabaseInitializer
.
class
);
});
}
@Test
void
whenAConnectionFactoryIsAvailableAndSpringR2dbcIsNotThenAutoConfigurationBacksOff
()
{
this
.
contextRunner
.
withConfiguration
(
AutoConfigurations
.
of
(
R2dbcAutoConfiguration
.
class
))
.
withClassLoader
(
new
FilteredClassLoader
(
org
.
springframework
.
r2dbc
.
connection
.
init
.
DatabasePopulator
.
class
))
.
run
((
context
)
->
{
assertThat
(
context
).
hasSingleBean
(
ConnectionFactory
.
class
);
assertThat
(
context
).
doesNotHaveBean
(
AbstractScriptDatabaseInitializer
.
class
);
});
}
@Configuration
(
proxyBeanMethods
=
false
)
static
class
DatabaseInitializerConfiguration
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment