Commit 445589a5 authored by Phillip Webb's avatar Phillip Webb

Polish RabbitMQ Changes

Fix the formatting which was messed up in commit ad1636fd. Also
simplify the RabbitProperties.setVirtualHost logic a little

See gh-1128
parent ad1636fd
...@@ -21,7 +21,7 @@ import org.springframework.util.StringUtils; ...@@ -21,7 +21,7 @@ import org.springframework.util.StringUtils;
/** /**
* Configuration properties for Rabbit. * Configuration properties for Rabbit.
* *
* @author Greg Turnquist * @author Greg Turnquist
* @author Dave Syer * @author Dave Syer
*/ */
...@@ -110,15 +110,11 @@ public class RabbitProperties { ...@@ -110,15 +110,11 @@ public class RabbitProperties {
} }
public void setVirtualHost(String virtualHost) { public void setVirtualHost(String virtualHost) {
if ("".equals(virtualHost) || virtualHost.equals("/")) { while (virtualHost.startsWith("/") && virtualHost.length() > 0) {
this.virtualHost = "/"; virtualHost = virtualHost.substring(1);
} else { }
// remove all trailing / this.virtualHost = ("".equals(virtualHost) ? "/" : virtualHost);
while (virtualHost.startsWith("/") && virtualHost.length() > 0) {
virtualHost = virtualHost.substring(1);
}
this.virtualHost = virtualHost;
}
} }
} }
...@@ -16,9 +16,6 @@ ...@@ -16,9 +16,6 @@
package org.springframework.boot.autoconfigure.amqp; package org.springframework.boot.autoconfigure.amqp;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.rules.ExpectedException; import org.junit.rules.ExpectedException;
...@@ -33,9 +30,12 @@ import org.springframework.context.annotation.AnnotationConfigApplicationContext ...@@ -33,9 +30,12 @@ import org.springframework.context.annotation.AnnotationConfigApplicationContext
import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Configuration;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
/** /**
* Tests for {@link RabbitAutoConfiguration}. * Tests for {@link RabbitAutoConfiguration}.
* *
* @author Greg Turnquist * @author Greg Turnquist
*/ */
public class RabbitAutoconfigurationTests { public class RabbitAutoconfigurationTests {
...@@ -74,7 +74,7 @@ public class RabbitAutoconfigurationTests { ...@@ -74,7 +74,7 @@ public class RabbitAutoconfigurationTests {
.getBean(CachingConnectionFactory.class); .getBean(CachingConnectionFactory.class);
assertEquals("remote-server", connectionFactory.getHost()); assertEquals("remote-server", connectionFactory.getHost());
assertEquals(9000, connectionFactory.getPort()); assertEquals(9000, connectionFactory.getPort());
assertEquals("vhost", connectionFactory.getVirtualHost()); assertEquals("vhost", connectionFactory.getVirtualHost());
} }
@Test @Test
......
...@@ -16,14 +16,14 @@ ...@@ -16,14 +16,14 @@
package org.springframework.boot.autoconfigure.amqp; package org.springframework.boot.autoconfigure.amqp;
import org.junit.Test;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull; import static org.junit.Assert.assertNull;
import org.junit.Test;
/** /**
* Tests for {@link RabbitProperties}. * Tests for {@link RabbitProperties}.
* *
* @author Dave Syer * @author Dave Syer
*/ */
public class RabbitPropertiesTests { public class RabbitPropertiesTests {
...@@ -50,28 +50,28 @@ public class RabbitPropertiesTests { ...@@ -50,28 +50,28 @@ public class RabbitPropertiesTests {
assertEquals(9999, this.properties.getPort()); assertEquals(9999, this.properties.getPort());
} }
@Test @Test
public void testDefaultVirtualHost() { public void testDefaultVirtualHost() {
this.properties.setVirtualHost("/"); this.properties.setVirtualHost("/");
assertEquals("/", this.properties.getVirtualHost()); assertEquals("/", this.properties.getVirtualHost());
} }
@Test @Test
public void testemptyVirtualHost() { public void testemptyVirtualHost() {
this.properties.setVirtualHost(""); this.properties.setVirtualHost("");
assertEquals("/", this.properties.getVirtualHost()); assertEquals("/", this.properties.getVirtualHost());
} }
@Test @Test
public void testCustomVirtualHost() { public void testCustomVirtualHost() {
this.properties.setVirtualHost("myvHost"); this.properties.setVirtualHost("myvHost");
assertEquals("myvHost", this.properties.getVirtualHost()); assertEquals("myvHost", this.properties.getVirtualHost());
} }
@Test @Test
public void testCustomFalsyVirtualHost() { public void testCustomFalsyVirtualHost() {
this.properties.setVirtualHost("/myvHost"); this.properties.setVirtualHost("/myvHost");
assertEquals("myvHost", this.properties.getVirtualHost()); assertEquals("myvHost", this.properties.getVirtualHost());
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment