Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
4597e7cc
Commit
4597e7cc
authored
Dec 14, 2018
by
Stephen Doxsee
Committed by
Madhura Bhave
Jan 02, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Order actuator security config after resource-server config
See gh-15472
parent
d1e1a82b
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
45 additions
and
2 deletions
+45
-2
pom.xml
...g-boot-project/spring-boot-actuator-autoconfigure/pom.xml
+10
-0
ReactiveManagementWebSecurityAutoConfiguration.java
...ctive/ReactiveManagementWebSecurityAutoConfiguration.java
+3
-1
ManagementWebSecurityAutoConfiguration.java
...urity/servlet/ManagementWebSecurityAutoConfiguration.java
+3
-1
ReactiveManagementWebSecurityAutoConfigurationTests.java
.../ReactiveManagementWebSecurityAutoConfigurationTests.java
+15
-0
ManagementWebSecurityAutoConfigurationTests.java
.../servlet/ManagementWebSecurityAutoConfigurationTests.java
+14
-0
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/pom.xml
View file @
4597e7cc
...
...
@@ -556,6 +556,16 @@
<artifactId>
spring-security-test
</artifactId>
<scope>
test
</scope>
</dependency>
<dependency>
<groupId>
org.springframework.security
</groupId>
<artifactId>
spring-security-oauth2-resource-server
</artifactId>
<scope>
test
</scope>
</dependency>
<dependency>
<groupId>
org.springframework.security
</groupId>
<artifactId>
spring-security-oauth2-jose
</artifactId>
<scope>
test
</scope>
</dependency>
<dependency>
<groupId>
org.yaml
</groupId>
<artifactId>
snakeyaml
</artifactId>
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/reactive/ReactiveManagementWebSecurityAutoConfiguration.java
View file @
4597e7cc
...
...
@@ -28,6 +28,7 @@ import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication
;
import
org.springframework.boot.autoconfigure.security.oauth2.client.reactive.ReactiveOAuth2ClientAutoConfiguration
;
import
org.springframework.boot.autoconfigure.security.oauth2.resource.reactive.ReactiveOAuth2ResourceServerAutoConfiguration
;
import
org.springframework.boot.autoconfigure.security.reactive.ReactiveSecurityAutoConfiguration
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
...
...
@@ -51,7 +52,8 @@ import org.springframework.security.web.server.WebFilterChainProxy;
@AutoConfigureBefore
(
ReactiveSecurityAutoConfiguration
.
class
)
@AutoConfigureAfter
({
HealthEndpointAutoConfiguration
.
class
,
InfoEndpointAutoConfiguration
.
class
,
WebEndpointAutoConfiguration
.
class
,
ReactiveOAuth2ClientAutoConfiguration
.
class
})
ReactiveOAuth2ClientAutoConfiguration
.
class
,
ReactiveOAuth2ResourceServerAutoConfiguration
.
class
})
public
class
ReactiveManagementWebSecurityAutoConfiguration
{
@Bean
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/ManagementWebSecurityAutoConfiguration.java
View file @
4597e7cc
...
...
@@ -26,6 +26,7 @@ import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication
;
import
org.springframework.boot.autoconfigure.security.oauth2.client.servlet.OAuth2ClientAutoConfiguration
;
import
org.springframework.boot.autoconfigure.security.oauth2.resource.servlet.OAuth2ResourceServerAutoConfiguration
;
import
org.springframework.boot.autoconfigure.security.servlet.SecurityAutoConfiguration
;
import
org.springframework.boot.autoconfigure.security.servlet.WebSecurityEnablerConfiguration
;
import
org.springframework.context.annotation.Configuration
;
...
...
@@ -47,7 +48,8 @@ import org.springframework.security.config.annotation.web.configuration.WebSecur
@AutoConfigureBefore
(
SecurityAutoConfiguration
.
class
)
@AutoConfigureAfter
({
HealthEndpointAutoConfiguration
.
class
,
InfoEndpointAutoConfiguration
.
class
,
WebEndpointAutoConfiguration
.
class
,
OAuth2ClientAutoConfiguration
.
class
})
OAuth2ClientAutoConfiguration
.
class
,
OAuth2ResourceServerAutoConfiguration
.
class
})
@Import
({
ManagementWebSecurityConfigurerAdapter
.
class
,
WebSecurityEnablerConfiguration
.
class
})
public
class
ManagementWebSecurityAutoConfiguration
{
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/reactive/ReactiveManagementWebSecurityAutoConfigurationTests.java
View file @
4597e7cc
...
...
@@ -32,6 +32,7 @@ import org.springframework.boot.actuate.autoconfigure.health.HealthEndpointAutoC
import
org.springframework.boot.actuate.autoconfigure.health.HealthIndicatorAutoConfiguration
;
import
org.springframework.boot.actuate.autoconfigure.info.InfoEndpointAutoConfiguration
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.autoconfigure.security.oauth2.resource.reactive.ReactiveOAuth2ResourceServerAutoConfiguration
;
import
org.springframework.boot.autoconfigure.security.reactive.ReactiveSecurityAutoConfiguration
;
import
org.springframework.boot.autoconfigure.security.reactive.ReactiveUserDetailsServiceAutoConfiguration
;
import
org.springframework.boot.test.context.assertj.AssertableReactiveWebApplicationContext
;
...
...
@@ -118,6 +119,20 @@ public class ReactiveManagementWebSecurityAutoConfigurationTests {
});
}
@Test
public
void
backsOffIfReactiveOAuth2ResourceServerAutoConfigurationSecurityIsAdded
()
{
this
.
contextRunner
.
withConfiguration
(
AutoConfigurations
.
of
(
ReactiveOAuth2ResourceServerAutoConfiguration
.
class
))
.
withPropertyValues
(
"spring.security.oauth2.resourceserver.jwt.jwk-set-uri=http://authserver"
)
.
run
((
context
)
->
{
assertThat
(
context
.
getBeanNamesForType
(
ReactiveManagementWebSecurityAutoConfiguration
.
class
))
.
isEmpty
();
});
}
@Test
public
void
backsOffWhenWebFilterChainProxyBeanPresent
()
{
this
.
contextRunner
.
withUserConfiguration
(
WebFilterChainProxyConfiguration
.
class
)
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/servlet/ManagementWebSecurityAutoConfigurationTests.java
View file @
4597e7cc
...
...
@@ -27,6 +27,7 @@ import org.springframework.boot.actuate.autoconfigure.health.HealthEndpointAutoC
import
org.springframework.boot.actuate.autoconfigure.health.HealthIndicatorAutoConfiguration
;
import
org.springframework.boot.actuate.autoconfigure.info.InfoEndpointAutoConfiguration
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.autoconfigure.security.oauth2.resource.servlet.OAuth2ResourceServerAutoConfiguration
;
import
org.springframework.boot.autoconfigure.security.servlet.SecurityAutoConfiguration
;
import
org.springframework.boot.test.context.assertj.AssertableWebApplicationContext
;
import
org.springframework.boot.test.context.runner.WebApplicationContextRunner
;
...
...
@@ -106,6 +107,19 @@ public class ManagementWebSecurityAutoConfigurationTests {
});
}
@Test
public
void
backOffIfOAuth2ResourceServerAutoConfigurationSecurityIsAdded
()
{
this
.
contextRunner
.
withConfiguration
(
AutoConfigurations
.
of
(
OAuth2ResourceServerAutoConfiguration
.
class
))
.
withPropertyValues
(
"spring.security.oauth2.resourceserver.jwt.jwk-set-uri=http://authserver"
)
.
run
((
context
)
->
{
assertThat
(
context
.
getBeanNamesForType
(
ManagementWebSecurityConfigurerAdapter
.
class
)).
isEmpty
();
});
}
private
HttpStatus
getResponseStatus
(
AssertableWebApplicationContext
context
,
String
path
)
throws
IOException
,
javax
.
servlet
.
ServletException
{
FilterChainProxy
filterChainProxy
=
context
.
getBean
(
FilterChainProxy
.
class
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment