Commit 4a738e3c authored by Johnny Lim's avatar Johnny Lim Committed by Stephane Nicoll

Polish

Closes gh-16094
parent d83a614b
...@@ -767,7 +767,7 @@ special classloader, then it is considered a "`production application`". If that ...@@ -767,7 +767,7 @@ special classloader, then it is considered a "`production application`". If that
apply to you (i.e. if you run your application from a container), consider excluding apply to you (i.e. if you run your application from a container), consider excluding
devtools or set the `-Dspring.devtools.restart.enabled=false` system property. devtools or set the `-Dspring.devtools.restart.enabled=false` system property.
TIP: Flagging the dependency as optional in Maven or using a custom`developmentOnly` TIP: Flagging the dependency as optional in Maven or using a custom `developmentOnly`
configuration in Gradle (as shown above) is a best practice that prevents devtools from configuration in Gradle (as shown above) is a best practice that prevents devtools from
being transitively applied to other modules that use your project. being transitively applied to other modules that use your project.
......
...@@ -471,7 +471,7 @@ public class LogbackLoggingSystemTests extends AbstractLoggingSystemTests { ...@@ -471,7 +471,7 @@ public class LogbackLoggingSystemTests extends AbstractLoggingSystemTests {
testTotalSizeCapProperty(String.valueOf(10 * 1024 * 1024), "10 MB"); testTotalSizeCapProperty(String.valueOf(10 * 1024 * 1024), "10 MB");
} }
private void testTotalSizeCapProperty(String sizeValue, String expectFileSize) { private void testTotalSizeCapProperty(String sizeValue, String expectedFileSize) {
MockEnvironment environment = new MockEnvironment(); MockEnvironment environment = new MockEnvironment();
environment.setProperty("logging.file.total-size-cap", sizeValue); environment.setProperty("logging.file.total-size-cap", sizeValue);
LoggingInitializationContext loggingInitializationContext = new LoggingInitializationContext( LoggingInitializationContext loggingInitializationContext = new LoggingInitializationContext(
...@@ -482,7 +482,7 @@ public class LogbackLoggingSystemTests extends AbstractLoggingSystemTests { ...@@ -482,7 +482,7 @@ public class LogbackLoggingSystemTests extends AbstractLoggingSystemTests {
this.logger.info("Hello world"); this.logger.info("Hello world");
assertThat(getLineWithText(file, "Hello world")).contains("INFO"); assertThat(getLineWithText(file, "Hello world")).contains("INFO");
assertThat(ReflectionTestUtils.getField(getRollingPolicy(), "totalSizeCap") assertThat(ReflectionTestUtils.getField(getRollingPolicy(), "totalSizeCap")
.toString()).isEqualTo(expectFileSize); .toString()).isEqualTo(expectedFileSize);
} }
@Test @Test
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment