Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
547fc30e
Commit
547fc30e
authored
Jan 27, 2020
by
Jorge Cordoba
Committed by
Stephane Nicoll
Feb 11, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix condition source in OnBeanCondition
See gh-19948
parent
d485708f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
3 deletions
+16
-3
OnBeanCondition.java
...amework/boot/autoconfigure/condition/OnBeanCondition.java
+4
-3
ConditionalOnMissingBeanTests.java
...utoconfigure/condition/ConditionalOnMissingBeanTests.java
+12
-0
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java
View file @
547fc30e
...
@@ -67,6 +67,7 @@ import org.springframework.util.StringUtils;
...
@@ -67,6 +67,7 @@ import org.springframework.util.StringUtils;
* @author Jakub Kubrynski
* @author Jakub Kubrynski
* @author Stephane Nicoll
* @author Stephane Nicoll
* @author Andy Wilkinson
* @author Andy Wilkinson
* @author Jorge Cordoba
* @see ConditionalOnBean
* @see ConditionalOnBean
* @see ConditionalOnMissingBean
* @see ConditionalOnMissingBean
* @see ConditionalOnSingleCandidate
* @see ConditionalOnSingleCandidate
...
@@ -387,7 +388,7 @@ class OnBeanCondition extends FilteringSpringBootCondition implements Configurat
...
@@ -387,7 +388,7 @@ class OnBeanCondition extends FilteringSpringBootCondition implements Configurat
private
final
ClassLoader
classLoader
;
private
final
ClassLoader
classLoader
;
private
final
Class
<?>
annotationType
;
private
final
Class
<?
extends
Annotation
>
annotationType
;
private
final
Set
<
String
>
names
;
private
final
Set
<
String
>
names
;
...
@@ -581,11 +582,11 @@ class OnBeanCondition extends FilteringSpringBootCondition implements Configurat
...
@@ -581,11 +582,11 @@ class OnBeanCondition extends FilteringSpringBootCondition implements Configurat
}
}
ConditionMessage
.
Builder
message
()
{
ConditionMessage
.
Builder
message
()
{
return
ConditionMessage
.
forCondition
(
ConditionalOnBean
.
class
,
this
);
return
ConditionMessage
.
forCondition
(
this
.
annotationType
,
this
);
}
}
ConditionMessage
.
Builder
message
(
ConditionMessage
message
)
{
ConditionMessage
.
Builder
message
(
ConditionMessage
message
)
{
return
message
.
andCondition
(
ConditionalOnBean
.
class
,
this
);
return
message
.
andCondition
(
this
.
annotationType
,
this
);
}
}
@Override
@Override
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnMissingBeanTests.java
View file @
547fc30e
...
@@ -21,6 +21,7 @@ import java.lang.annotation.ElementType;
...
@@ -21,6 +21,7 @@ import java.lang.annotation.ElementType;
import
java.lang.annotation.Retention
;
import
java.lang.annotation.Retention
;
import
java.lang.annotation.RetentionPolicy
;
import
java.lang.annotation.RetentionPolicy
;
import
java.lang.annotation.Target
;
import
java.lang.annotation.Target
;
import
java.util.Collection
;
import
java.util.Date
;
import
java.util.Date
;
import
java.util.function.Consumer
;
import
java.util.function.Consumer
;
...
@@ -57,6 +58,7 @@ import static org.assertj.core.api.Assertions.assertThat;
...
@@ -57,6 +58,7 @@ import static org.assertj.core.api.Assertions.assertThat;
* @author Phillip Webb
* @author Phillip Webb
* @author Jakub Kubrynski
* @author Jakub Kubrynski
* @author Andy Wilkinson
* @author Andy Wilkinson
* @author Jorge Cordoba
*/
*/
@SuppressWarnings
(
"resource"
)
@SuppressWarnings
(
"resource"
)
public
class
ConditionalOnMissingBeanTests
{
public
class
ConditionalOnMissingBeanTests
{
...
@@ -135,6 +137,16 @@ public class ConditionalOnMissingBeanTests {
...
@@ -135,6 +137,16 @@ public class ConditionalOnMissingBeanTests {
assertThat
(
context
.
getBean
(
"foo"
)).
isEqualTo
(
"foo"
);
assertThat
(
context
.
getBean
(
"foo"
)).
isEqualTo
(
"foo"
);
});
});
}
}
@Test
void
testOnMissingBeanConditionOutputShouldNotContainConditionalOnBeanClassInMessage
()
{
this
.
contextRunner
.
withUserConfiguration
(
ConditionalOnMissingBeanTests
.
OnBeanNameConfiguration
.
class
).
run
((
context
)
->
{
Collection
<
ConditionEvaluationReport
.
ConditionAndOutcomes
>
conditionAndOutcomes
=
ConditionEvaluationReport
.
get
(
context
.
getSourceApplicationContext
().
getBeanFactory
()).
getConditionAndOutcomesBySource
()
.
values
();
String
message
=
conditionAndOutcomes
.
iterator
().
next
().
iterator
().
next
().
getOutcome
().
getMessage
();
assertThat
(
message
).
doesNotContain
(
"@ConditionalOnBean (names: foo; SearchStrategy: all) did not find any beans"
);
});
}
@Test
@Test
void
testOnMissingBeanConditionWithFactoryBean
()
{
void
testOnMissingBeanConditionWithFactoryBean
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment