Commit 548ca630 authored by Stephane Nicoll's avatar Stephane Nicoll

Merge branch '2.4.x'

Closes gh-25364
parents 8ec14e28 526474f3
...@@ -198,6 +198,8 @@ public final class DataSourceBuilder<T extends DataSource> { ...@@ -198,6 +198,8 @@ public final class DataSourceBuilder<T extends DataSource> {
create(classLoader, "oracle.jdbc.datasource.OracleDataSource", OracleDataSourceSettings::new)); create(classLoader, "oracle.jdbc.datasource.OracleDataSource", OracleDataSourceSettings::new));
addIfAvailable(this.allDataSourceSettings, create(classLoader, "org.h2.jdbcx.JdbcDataSource", addIfAvailable(this.allDataSourceSettings, create(classLoader, "org.h2.jdbcx.JdbcDataSource",
(type) -> new DataSourceSettings(type, (aliases) -> aliases.addAliases("username", "user")))); (type) -> new DataSourceSettings(type, (aliases) -> aliases.addAliases("username", "user"))));
addIfAvailable(this.allDataSourceSettings, create(classLoader, "org.postgresql.ds.PGSimpleDataSource",
(type) -> new DataSourceSettings(type, (aliases) -> aliases.addAliases("username", "user"))));
} }
private static List<DataSourceSettings> resolveAvailableDataSourceSettings(ClassLoader classLoader) { private static List<DataSourceSettings> resolveAvailableDataSourceSettings(ClassLoader classLoader) {
......
...@@ -33,6 +33,7 @@ import org.h2.Driver; ...@@ -33,6 +33,7 @@ import org.h2.Driver;
import org.h2.jdbcx.JdbcDataSource; import org.h2.jdbcx.JdbcDataSource;
import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.postgresql.ds.PGSimpleDataSource;
import org.springframework.jdbc.datasource.SimpleDriverDataSource; import org.springframework.jdbc.datasource.SimpleDriverDataSource;
...@@ -129,6 +130,15 @@ class DataSourceBuilderTests { ...@@ -129,6 +130,15 @@ class DataSourceBuilderTests {
assertThat(h2DataSource.getUser()).isEqualTo("test"); assertThat(h2DataSource.getUser()).isEqualTo("test");
} }
@Test
void dataSourceCanBeCreatedWithPGDataSource() {
this.dataSource = DataSourceBuilder.create().url("jdbc:postgresql://localhost/test")
.type(PGSimpleDataSource.class).username("test").build();
assertThat(this.dataSource).isInstanceOf(PGSimpleDataSource.class);
PGSimpleDataSource pgDataSource = (PGSimpleDataSource) this.dataSource;
assertThat(pgDataSource.getUser()).isEqualTo("test");
}
@Test @Test
void dataSourceAliasesAreOnlyAppliedToRelevantDataSource() { void dataSourceAliasesAreOnlyAppliedToRelevantDataSource() {
this.dataSource = DataSourceBuilder.create().url("jdbc:h2:test").type(TestDataSource.class).username("test") this.dataSource = DataSourceBuilder.create().url("jdbc:h2:test").type(TestDataSource.class).username("test")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment