Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
55a5a26b
Commit
55a5a26b
authored
Mar 04, 2019
by
nicolas
Committed by
Stephane Nicoll
Apr 17, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Complete Jetty Access Log configuration properties support
See gh-16080
parent
a0b65a00
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
48 additions
and
7 deletions
+48
-7
ServerProperties.java
...ingframework/boot/autoconfigure/web/ServerProperties.java
+25
-0
JettyWebServerFactoryCustomizer.java
...nfigure/web/embedded/JettyWebServerFactoryCustomizer.java
+4
-0
ServerPropertiesTests.java
...amework/boot/autoconfigure/web/ServerPropertiesTests.java
+5
-0
JettyWebServerFactoryCustomizerTests.java
...re/web/embedded/JettyWebServerFactoryCustomizerTests.java
+14
-7
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java
View file @
55a5a26b
...
@@ -948,6 +948,16 @@ public class ServerProperties {
...
@@ -948,6 +948,16 @@ public class ServerProperties {
*/
*/
private
boolean
logLatency
;
private
boolean
logLatency
;
/**
* Set request paths that will not be logged.
*/
private
List
<
String
>
ignorePaths
;
/**
* true - IP address from header will be logged, false - IP address from the connection will be logged
*/
private
boolean
preferProxiedForAddress
=
false
;
public
boolean
isEnabled
()
{
public
boolean
isEnabled
()
{
return
this
.
enabled
;
return
this
.
enabled
;
}
}
...
@@ -1044,6 +1054,21 @@ public class ServerProperties {
...
@@ -1044,6 +1054,21 @@ public class ServerProperties {
this
.
logLatency
=
logLatency
;
this
.
logLatency
=
logLatency
;
}
}
public
List
<
String
>
getIgnorePaths
()
{
return
ignorePaths
;
}
public
void
setIgnorePaths
(
List
<
String
>
ignorePaths
)
{
this
.
ignorePaths
=
ignorePaths
;
}
public
boolean
getPreferProxiedForAddress
(){
return
preferProxiedForAddress
;
}
public
void
setPreferProxiedForAddress
(
boolean
preferProxiedForAddress
){
this
.
preferProxiedForAddress
=
preferProxiedForAddress
;
}
}
}
}
}
...
...
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/embedded/JettyWebServerFactoryCustomizer.java
View file @
55a5a26b
...
@@ -167,9 +167,13 @@ public class JettyWebServerFactoryCustomizer implements
...
@@ -167,9 +167,13 @@ public class JettyWebServerFactoryCustomizer implements
if
(
properties
.
getTimeZone
()
!=
null
)
{
if
(
properties
.
getTimeZone
()
!=
null
)
{
log
.
setLogTimeZone
(
properties
.
getTimeZone
().
getID
());
log
.
setLogTimeZone
(
properties
.
getTimeZone
().
getID
());
}
}
if
(
properties
.
getIgnorePaths
()
!=
null
)
{
log
.
setIgnorePaths
(
properties
.
getIgnorePaths
().
toArray
(
new
String
[
0
]));
}
log
.
setLogCookies
(
properties
.
isLogCookies
());
log
.
setLogCookies
(
properties
.
isLogCookies
());
log
.
setLogServer
(
properties
.
isLogServer
());
log
.
setLogServer
(
properties
.
isLogServer
());
log
.
setLogLatency
(
properties
.
isLogLatency
());
log
.
setLogLatency
(
properties
.
isLogLatency
());
log
.
setPreferProxiedForAddress
(
properties
.
getPreferProxiedForAddress
());
server
.
setRequestLog
(
log
);
server
.
setRequestLog
(
log
);
});
});
}
}
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java
View file @
55a5a26b
...
@@ -231,6 +231,8 @@ public class ServerPropertiesTests {
...
@@ -231,6 +231,8 @@ public class ServerPropertiesTests {
map
.
put
(
"server.jetty.accesslog.file-date-format"
,
"yyyymmdd"
);
map
.
put
(
"server.jetty.accesslog.file-date-format"
,
"yyyymmdd"
);
map
.
put
(
"server.jetty.accesslog.retention-period"
,
"4"
);
map
.
put
(
"server.jetty.accesslog.retention-period"
,
"4"
);
map
.
put
(
"server.jetty.accesslog.append"
,
"true"
);
map
.
put
(
"server.jetty.accesslog.append"
,
"true"
);
map
.
put
(
"server.jetty.accesslog.ignore-paths[0]"
,
"/a/path"
);
map
.
put
(
"server.jetty.accesslog.ignore-paths[1]"
,
"/b/path"
);
bind
(
map
);
bind
(
map
);
ServerProperties
.
Jetty
jetty
=
this
.
properties
.
getJetty
();
ServerProperties
.
Jetty
jetty
=
this
.
properties
.
getJetty
();
assertThat
(
jetty
.
getAccesslog
().
isEnabled
()).
isTrue
();
assertThat
(
jetty
.
getAccesslog
().
isEnabled
()).
isTrue
();
...
@@ -238,6 +240,9 @@ public class ServerPropertiesTests {
...
@@ -238,6 +240,9 @@ public class ServerPropertiesTests {
assertThat
(
jetty
.
getAccesslog
().
getFileDateFormat
()).
isEqualTo
(
"yyyymmdd"
);
assertThat
(
jetty
.
getAccesslog
().
getFileDateFormat
()).
isEqualTo
(
"yyyymmdd"
);
assertThat
(
jetty
.
getAccesslog
().
getRetentionPeriod
()).
isEqualTo
(
4
);
assertThat
(
jetty
.
getAccesslog
().
getRetentionPeriod
()).
isEqualTo
(
4
);
assertThat
(
jetty
.
getAccesslog
().
isAppend
()).
isTrue
();
assertThat
(
jetty
.
getAccesslog
().
isAppend
()).
isTrue
();
assertThat
(
jetty
.
getAccesslog
().
getIgnorePaths
().
size
()).
isEqualTo
(
2
);
assertThat
(
jetty
.
getAccesslog
().
getIgnorePaths
().
get
(
0
)).
isEqualTo
(
"/a/path"
);
assertThat
(
jetty
.
getAccesslog
().
getIgnorePaths
().
get
(
1
)).
isEqualTo
(
"/b/path"
);
}
}
@Test
@Test
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/embedded/JettyWebServerFactoryCustomizerTests.java
View file @
55a5a26b
...
@@ -16,13 +16,16 @@
...
@@ -16,13 +16,16 @@
package
org
.
springframework
.
boot
.
autoconfigure
.
web
.
embedded
;
package
org
.
springframework
.
boot
.
autoconfigure
.
web
.
embedded
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
mockito
.
Mockito
.
mock
;
import
static
org
.
mockito
.
Mockito
.
verify
;
import
java.io.File
;
import
java.io.File
;
import
java.io.IOException
;
import
java.io.IOException
;
import
java.util.ArrayList
;
import
java.util.ArrayList
;
import
java.util.List
;
import
java.util.List
;
import
java.util.Locale
;
import
java.util.Locale
;
import
java.util.TimeZone
;
import
java.util.TimeZone
;
import
org.eclipse.jetty.server.Connector
;
import
org.eclipse.jetty.server.Connector
;
import
org.eclipse.jetty.server.HttpConfiguration
;
import
org.eclipse.jetty.server.HttpConfiguration
;
import
org.eclipse.jetty.server.HttpConfiguration.ConnectionFactory
;
import
org.eclipse.jetty.server.HttpConfiguration.ConnectionFactory
;
...
@@ -30,7 +33,6 @@ import org.eclipse.jetty.server.NCSARequestLog;
...
@@ -30,7 +33,6 @@ import org.eclipse.jetty.server.NCSARequestLog;
import
org.eclipse.jetty.server.RequestLog
;
import
org.eclipse.jetty.server.RequestLog
;
import
org.junit.Before
;
import
org.junit.Before
;
import
org.junit.Test
;
import
org.junit.Test
;
import
org.springframework.boot.autoconfigure.web.ServerProperties
;
import
org.springframework.boot.autoconfigure.web.ServerProperties
;
import
org.springframework.boot.context.properties.bind.Bindable
;
import
org.springframework.boot.context.properties.bind.Bindable
;
import
org.springframework.boot.context.properties.bind.Binder
;
import
org.springframework.boot.context.properties.bind.Binder
;
...
@@ -41,10 +43,6 @@ import org.springframework.boot.web.embedded.jetty.JettyWebServer;
...
@@ -41,10 +43,6 @@ import org.springframework.boot.web.embedded.jetty.JettyWebServer;
import
org.springframework.mock.env.MockEnvironment
;
import
org.springframework.mock.env.MockEnvironment
;
import
org.springframework.test.context.support.TestPropertySourceUtils
;
import
org.springframework.test.context.support.TestPropertySourceUtils
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
mockito
.
Mockito
.
mock
;
import
static
org
.
mockito
.
Mockito
.
verify
;
/**
/**
* Tests for {@link JettyWebServerFactoryCustomizer}.
* Tests for {@link JettyWebServerFactoryCustomizer}.
*
*
...
@@ -101,7 +99,10 @@ public class JettyWebServerFactoryCustomizerTests {
...
@@ -101,7 +99,10 @@ public class JettyWebServerFactoryCustomizerTests {
"server.jetty.accesslog.time-zone="
+
timezone
,
"server.jetty.accesslog.time-zone="
+
timezone
,
"server.jetty.accesslog.log-cookies=true"
,
"server.jetty.accesslog.log-cookies=true"
,
"server.jetty.accesslog.log-server=true"
,
"server.jetty.accesslog.log-server=true"
,
"server.jetty.accesslog.log-latency=true"
);
"server.jetty.accesslog.log-latency=true"
,
"server.jetty.accesslog.prefer-proxied-for-address=true"
,
"server.jetty.accesslog.ignore-paths[0]=/a/path"
,
"server.jetty.accesslog.ignore-paths[1]=/b/path"
);
JettyWebServer
server
=
customizeAndGetServer
();
JettyWebServer
server
=
customizeAndGetServer
();
NCSARequestLog
requestLog
=
getNCSARequestLog
(
server
);
NCSARequestLog
requestLog
=
getNCSARequestLog
(
server
);
assertThat
(
requestLog
.
getFilename
()).
isEqualTo
(
logFile
.
getAbsolutePath
());
assertThat
(
requestLog
.
getFilename
()).
isEqualTo
(
logFile
.
getAbsolutePath
());
...
@@ -115,6 +116,10 @@ public class JettyWebServerFactoryCustomizerTests {
...
@@ -115,6 +116,10 @@ public class JettyWebServerFactoryCustomizerTests {
assertThat
(
requestLog
.
getLogCookies
()).
isTrue
();
assertThat
(
requestLog
.
getLogCookies
()).
isTrue
();
assertThat
(
requestLog
.
getLogServer
()).
isTrue
();
assertThat
(
requestLog
.
getLogServer
()).
isTrue
();
assertThat
(
requestLog
.
getLogLatency
()).
isTrue
();
assertThat
(
requestLog
.
getLogLatency
()).
isTrue
();
assertThat
(
requestLog
.
getPreferProxiedForAddress
()).
isTrue
();
assertThat
(
requestLog
.
getIgnorePaths
().
length
).
isEqualTo
(
2
);
assertThat
(
requestLog
.
getIgnorePaths
()[
0
]).
isEqualTo
(
"/a/path"
);
assertThat
(
requestLog
.
getIgnorePaths
()[
1
]).
isEqualTo
(
"/b/path"
);
}
}
@Test
@Test
...
@@ -128,6 +133,8 @@ public class JettyWebServerFactoryCustomizerTests {
...
@@ -128,6 +133,8 @@ public class JettyWebServerFactoryCustomizerTests {
assertThat
(
requestLog
.
getLogCookies
()).
isFalse
();
assertThat
(
requestLog
.
getLogCookies
()).
isFalse
();
assertThat
(
requestLog
.
getLogServer
()).
isFalse
();
assertThat
(
requestLog
.
getLogServer
()).
isFalse
();
assertThat
(
requestLog
.
getLogLatency
()).
isFalse
();
assertThat
(
requestLog
.
getLogLatency
()).
isFalse
();
assertThat
(
requestLog
.
getIgnorePaths
().
length
).
isZero
();
assertThat
(
requestLog
.
getPreferProxiedForAddress
()).
isFalse
();
}
}
private
NCSARequestLog
getNCSARequestLog
(
JettyWebServer
server
)
{
private
NCSARequestLog
getNCSARequestLog
(
JettyWebServer
server
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment