Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
57442f5b
Commit
57442f5b
authored
Dec 19, 2014
by
Phillip Webb
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve formatting of Tomcat port(s) logging
Align Tomcat logging with the recent Jetty and Undertow updates.
parent
d857323f
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
18 additions
and
27 deletions
+18
-27
TomcatEmbeddedServletContainer.java
...ntext/embedded/tomcat/TomcatEmbeddedServletContainer.java
+18
-27
No files found.
spring-boot/src/main/java/org/springframework/boot/context/embedded/tomcat/TomcatEmbeddedServletContainer.java
View file @
57442f5b
...
...
@@ -44,7 +44,8 @@ import org.springframework.util.Assert;
*/
public
class
TomcatEmbeddedServletContainer
implements
EmbeddedServletContainer
{
private
final
Log
logger
=
LogFactory
.
getLog
(
TomcatEmbeddedServletContainer
.
class
);
private
static
final
Log
logger
=
LogFactory
.
getLog
(
TomcatEmbeddedServletContainer
.
class
);
private
static
AtomicInteger
containerCounter
=
new
AtomicInteger
(-
1
);
...
...
@@ -75,8 +76,8 @@ public class TomcatEmbeddedServletContainer implements EmbeddedServletContainer
}
private
synchronized
void
initialize
()
throws
EmbeddedServletContainerException
{
this
.
logger
.
info
(
"Tomcat initialized with port(s): "
+
get
ConfiguredPortsDescription
(
));
TomcatEmbeddedServletContainer
.
logger
.
info
(
"Tomcat initialized with port(s): "
+
get
PortsDescription
(
false
));
try
{
addInstanceIdToEngineName
();
...
...
@@ -99,15 +100,6 @@ public class TomcatEmbeddedServletContainer implements EmbeddedServletContainer
}
}
private
String
getConfiguredPortsDescription
()
{
StringBuilder
ports
=
new
StringBuilder
();
for
(
Connector
connector
:
this
.
tomcat
.
getService
().
findConnectors
())
{
ports
.
append
(
ports
.
length
()
==
0
?
""
:
" "
);
ports
.
append
(
connector
.
getPort
()
+
"/"
+
connector
.
getScheme
());
}
return
ports
.
toString
();
}
private
void
addInstanceIdToEngineName
()
{
int
instanceId
=
containerCounter
.
incrementAndGet
();
if
(
instanceId
>
0
)
{
...
...
@@ -157,15 +149,13 @@ public class TomcatEmbeddedServletContainer implements EmbeddedServletContainer
if
(
connector
!=
null
&&
this
.
autoStart
)
{
startConnector
(
connector
);
}
// Ensure process isn't left running if it actually failed to start
if
(
connectorsHaveFailedToStart
())
{
stopSilently
();
throw
new
IllegalStateException
(
"Tomcat connector in failed state"
);
}
this
.
logger
.
info
(
"Tomcat started on port(s): "
+
getActualPortsDescription
(
));
TomcatEmbeddedServletContainer
.
logger
.
info
(
"Tomcat started on port(s): "
+
getPortsDescription
(
true
));
}
private
boolean
connectorsHaveFailedToStart
()
{
...
...
@@ -206,7 +196,7 @@ public class TomcatEmbeddedServletContainer implements EmbeddedServletContainer
connector
.
getProtocolHandler
().
stop
();
}
catch
(
Exception
ex
)
{
this
.
logger
.
error
(
"Cannot pause connector: "
,
ex
);
TomcatEmbeddedServletContainer
.
logger
.
error
(
"Cannot pause connector: "
,
ex
);
}
}
...
...
@@ -219,7 +209,7 @@ public class TomcatEmbeddedServletContainer implements EmbeddedServletContainer
}
}
catch
(
Exception
ex
)
{
this
.
logger
.
error
(
"Cannot start connector: "
,
ex
);
TomcatEmbeddedServletContainer
.
logger
.
error
(
"Cannot start connector: "
,
ex
);
throw
new
EmbeddedServletContainerException
(
"Unable to start embedded Tomcat connectors"
,
ex
);
}
...
...
@@ -229,15 +219,6 @@ public class TomcatEmbeddedServletContainer implements EmbeddedServletContainer
return
this
.
serviceConnectors
;
}
private
String
getActualPortsDescription
()
{
StringBuilder
ports
=
new
StringBuilder
();
for
(
Connector
connector
:
this
.
tomcat
.
getService
().
findConnectors
())
{
ports
.
append
(
ports
.
length
()
==
0
?
""
:
" "
);
ports
.
append
(
connector
.
getLocalPort
()
+
"/"
+
connector
.
getScheme
());
}
return
ports
.
toString
();
}
@Override
public
synchronized
void
stop
()
throws
EmbeddedServletContainerException
{
try
{
...
...
@@ -258,6 +239,16 @@ public class TomcatEmbeddedServletContainer implements EmbeddedServletContainer
}
}
private
String
getPortsDescription
(
boolean
localPort
)
{
StringBuilder
ports
=
new
StringBuilder
();
for
(
Connector
connector
:
this
.
tomcat
.
getService
().
findConnectors
())
{
ports
.
append
(
ports
.
length
()
==
0
?
""
:
" "
);
int
port
=
(
localPort
?
connector
.
getLocalPort
()
:
connector
.
getPort
());
ports
.
append
(
port
+
" ("
+
connector
.
getScheme
()
+
")"
);
}
return
ports
.
toString
();
}
@Override
public
int
getPort
()
{
Connector
connector
=
this
.
tomcat
.
getConnector
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment