Commit 5dea4c5a authored by Andy Wilkinson's avatar Andy Wilkinson

Wait for server port to be written in a more robust manner

Previously, we just waited for the file to exist before trying to read
the port from it. This left a window where the file existed but its
contents had not be written which could result in a
NumberFormatException.

This commit now waits for the file to have a length that is greater
than zero.

See gh-7379
parent 5857010d
...@@ -139,7 +139,7 @@ public class DevToolsIntegrationTests { ...@@ -139,7 +139,7 @@ public class DevToolsIntegrationTests {
private int awaitServerPort() throws Exception { private int awaitServerPort() throws Exception {
long end = System.currentTimeMillis() + 20000; long end = System.currentTimeMillis() + 20000;
while (!this.serverPortFile.exists()) { while (this.serverPortFile.length() == 0) {
if (System.currentTimeMillis() > end) { if (System.currentTimeMillis() > end) {
throw new IllegalStateException( throw new IllegalStateException(
"server.port file was not written within 20 seconds"); "server.port file was not written within 20 seconds");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment