Commit 6a7f75a0 authored by Andy Wilkinson's avatar Andy Wilkinson

Merge pull request #11466 from Lukas Eder

* gh-11466:
  Detect jOOQ SQLDialect through jOOQ's JDBCUtils
parents 2b8bfcdb 44cd3352
...@@ -16,17 +16,13 @@ ...@@ -16,17 +16,13 @@
package org.springframework.boot.autoconfigure.jooq; package org.springframework.boot.autoconfigure.jooq;
import java.util.Collections;
import java.util.EnumMap;
import java.util.Map;
import javax.sql.DataSource; import javax.sql.DataSource;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.jooq.SQLDialect; import org.jooq.SQLDialect;
import org.jooq.tools.jdbc.JDBCUtils;
import org.springframework.boot.jdbc.DatabaseDriver;
import org.springframework.jdbc.support.JdbcUtils; import org.springframework.jdbc.support.JdbcUtils;
import org.springframework.jdbc.support.MetaDataAccessException; import org.springframework.jdbc.support.MetaDataAccessException;
...@@ -34,25 +30,12 @@ import org.springframework.jdbc.support.MetaDataAccessException; ...@@ -34,25 +30,12 @@ import org.springframework.jdbc.support.MetaDataAccessException;
* Utility to lookup well known {@link SQLDialect SQLDialects} from a {@link DataSource}. * Utility to lookup well known {@link SQLDialect SQLDialects} from a {@link DataSource}.
* *
* @author Michael Simons * @author Michael Simons
* @author Lukas Eder
*/ */
final class SqlDialectLookup { final class SqlDialectLookup {
private static final Log logger = LogFactory.getLog(SqlDialectLookup.class); private static final Log logger = LogFactory.getLog(SqlDialectLookup.class);
private static final Map<DatabaseDriver, SQLDialect> LOOKUP;
static {
Map<DatabaseDriver, SQLDialect> map = new EnumMap<>(DatabaseDriver.class);
map.put(DatabaseDriver.DERBY, SQLDialect.DERBY);
map.put(DatabaseDriver.H2, SQLDialect.H2);
map.put(DatabaseDriver.HSQLDB, SQLDialect.HSQLDB);
map.put(DatabaseDriver.MARIADB, SQLDialect.MARIADB);
map.put(DatabaseDriver.MYSQL, SQLDialect.MYSQL);
map.put(DatabaseDriver.POSTGRESQL, SQLDialect.POSTGRES);
map.put(DatabaseDriver.SQLITE, SQLDialect.SQLITE);
LOOKUP = Collections.unmodifiableMap(map);
}
private SqlDialectLookup() { private SqlDialectLookup() {
} }
...@@ -67,8 +50,7 @@ final class SqlDialectLookup { ...@@ -67,8 +50,7 @@ final class SqlDialectLookup {
} }
try { try {
String url = JdbcUtils.extractDatabaseMetaData(dataSource, "getURL"); String url = JdbcUtils.extractDatabaseMetaData(dataSource, "getURL");
DatabaseDriver driver = DatabaseDriver.fromJdbcUrl(url); SQLDialect sqlDialect = JDBCUtils.dialect(url);
SQLDialect sqlDialect = LOOKUP.get(driver);
if (sqlDialect != null) { if (sqlDialect != null) {
return sqlDialect; return sqlDialect;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment