Commit 6d23ce2a authored by Phillip Webb's avatar Phillip Webb

Polish

parent 7709352c
...@@ -66,20 +66,16 @@ public abstract class ResourceUtils { ...@@ -66,20 +66,16 @@ public abstract class ResourceUtils {
* @return a list of URLs * @return a list of URLs
*/ */
public static List<String> getUrls(String path, ClassLoader classLoader) { public static List<String> getUrls(String path, ClassLoader classLoader) {
if (classLoader == null) { if (classLoader == null) {
classLoader = ClassUtils.getDefaultClassLoader(); classLoader = ClassUtils.getDefaultClassLoader();
} }
path = StringUtils.cleanPath(path); path = StringUtils.cleanPath(path);
try { try {
return getUrlsFromWildcardPath(path, classLoader); return getUrlsFromWildcardPath(path, classLoader);
} }
catch (Exception ex) { catch (Exception ex) {
throw new IllegalArgumentException( throw new IllegalArgumentException(
"Cannot create URL from path [" + path + "]", ex); "Cannot create URL from path [" + path + "]", ex);
} }
} }
...@@ -88,7 +84,6 @@ public abstract class ResourceUtils { ...@@ -88,7 +84,6 @@ public abstract class ResourceUtils {
if (path.contains(":")) { if (path.contains(":")) {
return getUrlsFromPrefixedWildcardPath(path, classLoader); return getUrlsFromPrefixedWildcardPath(path, classLoader);
} }
Set<String> result = new LinkedHashSet<String>(); Set<String> result = new LinkedHashSet<String>();
try { try {
result.addAll(getUrls(FILE_URL_PREFIX + path, classLoader)); result.addAll(getUrls(FILE_URL_PREFIX + path, classLoader));
...@@ -96,7 +91,6 @@ public abstract class ResourceUtils { ...@@ -96,7 +91,6 @@ public abstract class ResourceUtils {
catch (IllegalArgumentException ex) { catch (IllegalArgumentException ex) {
// ignore // ignore
} }
path = stripLeadingSlashes(path); path = stripLeadingSlashes(path);
result.addAll(getUrls(ALL_CLASSPATH_URL_PREFIX + path, classLoader)); result.addAll(getUrls(ALL_CLASSPATH_URL_PREFIX + path, classLoader));
return new ArrayList<String>(result); return new ArrayList<String>(result);
......
...@@ -77,11 +77,17 @@ public class ClassPathFileSystemWatcherTests { ...@@ -77,11 +77,17 @@ public class ClassPathFileSystemWatcherTests {
context.getEnvironment().getPropertySources().addLast(propertySource); context.getEnvironment().getPropertySources().addLast(propertySource);
context.register(Config.class); context.register(Config.class);
context.refresh(); context.refresh();
Thread.sleep(100); Thread.sleep(200);
File classFile = new File(folder, "Example.class"); File classFile = new File(folder, "Example.class");
FileCopyUtils.copy("file".getBytes(), classFile); FileCopyUtils.copy("file".getBytes(), classFile);
Thread.sleep(1100); Thread.sleep(1000);
List<ClassPathChangedEvent> events = context.getBean(Listener.class).getEvents(); List<ClassPathChangedEvent> events = context.getBean(Listener.class).getEvents();
for (int i = 0; i < 20; i++) {
if (!events.isEmpty()) {
break;
}
Thread.sleep(500);
}
assertThat(events.size()).isEqualTo(1); assertThat(events.size()).isEqualTo(1);
assertThat(events.get(0).getChangeSet().iterator().next().getFiles().iterator() assertThat(events.get(0).getChangeSet().iterator().next().getFiles().iterator()
.next().getFile()).isEqualTo(classFile); .next().getFile()).isEqualTo(classFile);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment