Commit 78996b12 authored by Phillip Webb's avatar Phillip Webb

Merge pull request #18342 from Scott-YuYan

* pr/18342:
  Polish "Simplify code"
  Simplify code

Closes gh-18342
parents a0957d9b a13666d6
...@@ -143,8 +143,8 @@ class BootArchiveSupport { ...@@ -143,8 +143,8 @@ class BootArchiveSupport {
} }
private boolean isZip(InputStream inputStream) throws IOException { private boolean isZip(InputStream inputStream) throws IOException {
for (int i = 0; i < ZIP_FILE_HEADER.length; i++) { for (byte headerByte : ZIP_FILE_HEADER) {
if (inputStream.read() != ZIP_FILE_HEADER[i]) { if (inputStream.read() != headerByte) {
return false; return false;
} }
} }
......
...@@ -68,7 +68,6 @@ import org.mockito.InOrder; ...@@ -68,7 +68,6 @@ import org.mockito.InOrder;
import org.springframework.boot.testsupport.system.CapturedOutput; import org.springframework.boot.testsupport.system.CapturedOutput;
import org.springframework.boot.web.server.PortInUseException; import org.springframework.boot.web.server.PortInUseException;
import org.springframework.boot.web.server.WebServerException; import org.springframework.boot.web.server.WebServerException;
import org.springframework.boot.web.servlet.ServletContextInitializer;
import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactory; import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactory;
import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactoryTests; import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactoryTests;
import org.springframework.core.io.ByteArrayResource; import org.springframework.core.io.ByteArrayResource;
...@@ -544,14 +543,7 @@ class TomcatServletWebServerFactoryTests extends AbstractServletWebServerFactory ...@@ -544,14 +543,7 @@ class TomcatServletWebServerFactoryTests extends AbstractServletWebServerFactory
@Test @Test
void registerJspServletWithDefaultLoadOnStartup() { void registerJspServletWithDefaultLoadOnStartup() {
TomcatServletWebServerFactory factory = new TomcatServletWebServerFactory(0); TomcatServletWebServerFactory factory = new TomcatServletWebServerFactory(0);
factory.addInitializers(new ServletContextInitializer() { factory.addInitializers((context) -> context.addServlet("manually-registered-jsp-servlet", JspServlet.class));
@Override
public void onStartup(ServletContext servletContext) throws ServletException {
servletContext.addServlet("manually-registered-jsp-servlet", JspServlet.class);
}
});
this.webServer = factory.getWebServer(); this.webServer = factory.getWebServer();
this.webServer.start(); this.webServer.start();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment