Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
7a705087
Commit
7a705087
authored
May 21, 2021
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid eager initialization when configuring Data repository metrics
Fixes gh-26630
parent
3a28aeeb
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
48 additions
and
5 deletions
+48
-5
MetricsRepositoryMethodInvocationListenerBeanPostProcessor.java
...sRepositoryMethodInvocationListenerBeanPostProcessor.java
+26
-2
RepositoryMetricsAutoConfiguration.java
...gure/metrics/data/RepositoryMetricsAutoConfiguration.java
+3
-2
MetricsRepositoryMethodInvocationListenerBeanPostProcessorTests.java
...sitoryMethodInvocationListenerBeanPostProcessorTests.java
+1
-1
RepositoryMetricsAutoConfigurationTests.java
...metrics/data/RepositoryMetricsAutoConfigurationTests.java
+18
-0
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/data/MetricsRepositoryMethodInvocationListenerBeanPostProcessor.java
View file @
7a705087
...
...
@@ -16,6 +16,8 @@
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
.
metrics
.
data
;
import
java.util.function.Supplier
;
import
org.springframework.beans.BeansException
;
import
org.springframework.beans.factory.config.BeanPostProcessor
;
import
org.springframework.boot.actuate.metrics.data.MetricsRepositoryMethodInvocationListener
;
...
...
@@ -33,8 +35,9 @@ class MetricsRepositoryMethodInvocationListenerBeanPostProcessor implements Bean
private
final
RepositoryFactoryCustomizer
customizer
;
MetricsRepositoryMethodInvocationListenerBeanPostProcessor
(
MetricsRepositoryMethodInvocationListener
listener
)
{
this
.
customizer
=
(
repositoryFactory
)
->
repositoryFactory
.
addInvocationListener
(
listener
);
MetricsRepositoryMethodInvocationListenerBeanPostProcessor
(
Supplier
<
MetricsRepositoryMethodInvocationListener
>
listener
)
{
this
.
customizer
=
new
MetricsRepositoryFactoryCustomizer
(
listener
);
}
@Override
...
...
@@ -45,4 +48,25 @@ class MetricsRepositoryMethodInvocationListenerBeanPostProcessor implements Bean
return
bean
;
}
private
static
final
class
MetricsRepositoryFactoryCustomizer
implements
RepositoryFactoryCustomizer
{
private
final
Supplier
<
MetricsRepositoryMethodInvocationListener
>
listenerSupplier
;
private
volatile
MetricsRepositoryMethodInvocationListener
listener
;
private
MetricsRepositoryFactoryCustomizer
(
Supplier
<
MetricsRepositoryMethodInvocationListener
>
listenerSupplier
)
{
this
.
listenerSupplier
=
listenerSupplier
;
}
@Override
public
void
customize
(
RepositoryFactorySupport
repositoryFactory
)
{
if
(
this
.
listener
==
null
)
{
this
.
listener
=
this
.
listenerSupplier
.
get
();
}
repositoryFactory
.
addInvocationListener
(
this
.
listener
);
}
}
}
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/data/RepositoryMetricsAutoConfiguration.java
View file @
7a705087
...
...
@@ -18,6 +18,7 @@ package org.springframework.boot.actuate.autoconfigure.metrics.data;
import
io.micrometer.core.instrument.MeterRegistry
;
import
org.springframework.beans.factory.ObjectProvider
;
import
org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration
;
import
org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration
;
import
org.springframework.boot.actuate.autoconfigure.metrics.MetricsProperties
;
...
...
@@ -72,9 +73,9 @@ public class RepositoryMetricsAutoConfiguration {
@Bean
public
static
MetricsRepositoryMethodInvocationListenerBeanPostProcessor
metricsRepositoryMethodInvocationListenerBeanPostProcessor
(
MetricsRepositoryMethodInvocationListener
metricsRepositoryMethodInvocationListener
)
{
ObjectProvider
<
MetricsRepositoryMethodInvocationListener
>
metricsRepositoryMethodInvocationListener
)
{
return
new
MetricsRepositoryMethodInvocationListenerBeanPostProcessor
(
metricsRepositoryMethodInvocationListener
);
metricsRepositoryMethodInvocationListener
:
:
getObject
);
}
}
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/data/MetricsRepositoryMethodInvocationListenerBeanPostProcessorTests.java
View file @
7a705087
...
...
@@ -38,7 +38,7 @@ class MetricsRepositoryMethodInvocationListenerBeanPostProcessorTests {
private
MetricsRepositoryMethodInvocationListener
listener
=
mock
(
MetricsRepositoryMethodInvocationListener
.
class
);
private
MetricsRepositoryMethodInvocationListenerBeanPostProcessor
postProcessor
=
new
MetricsRepositoryMethodInvocationListenerBeanPostProcessor
(
this
.
listener
);
()
->
this
.
listener
);
@Test
@SuppressWarnings
(
"rawtypes"
)
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/data/RepositoryMetricsAutoConfigurationTests.java
View file @
7a705087
...
...
@@ -24,6 +24,7 @@ import io.micrometer.core.instrument.Meter;
import
io.micrometer.core.instrument.MeterRegistry
;
import
io.micrometer.core.instrument.Tag
;
import
io.micrometer.core.instrument.Timer
;
import
io.micrometer.core.instrument.binder.MeterBinder
;
import
io.micrometer.core.instrument.distribution.HistogramSnapshot
;
import
org.junit.jupiter.api.Test
;
...
...
@@ -125,6 +126,13 @@ class RepositoryMetricsAutoConfigurationTests {
});
}
@Test
void
doesNotTriggerEarlyInitializationThatPreventsMeterBindersFromBindingMeters
()
{
this
.
contextRunner
.
withUserConfiguration
(
MeterBinderConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
.
getBean
(
MeterRegistry
.
class
).
find
(
"binder.test"
).
counter
())
.
isNotNull
());
}
private
MeterRegistry
getInitializedMeterRegistry
(
AssertableApplicationContext
context
,
Class
<?>
repositoryInterface
)
{
MetricsRepositoryMethodInvocationListener
listener
=
context
...
...
@@ -158,6 +166,16 @@ class RepositoryMetricsAutoConfigurationTests {
}
@Configuration
(
proxyBeanMethods
=
false
)
static
class
MeterBinderConfiguration
{
@Bean
MeterBinder
meterBinder
()
{
return
(
registry
)
->
registry
.
counter
(
"binder.test"
);
}
}
@Configuration
(
proxyBeanMethods
=
false
)
static
class
MetricsRepositoryMethodInvocationListenerConfiguration
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment