Commit 7b947183 authored by Stephane Nicoll's avatar Stephane Nicoll

Polish "Improve DefaultCookieSerializer auto-configuration"

Closes gh-16513
parent 5e025411
/* /*
* Copyright 2012-2018 the original author or authors. * Copyright 2012-2019 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
...@@ -90,18 +90,10 @@ public class SessionAutoConfiguration { ...@@ -90,18 +90,10 @@ public class SessionAutoConfiguration {
SessionRepositoryFilterConfiguration.class }) SessionRepositoryFilterConfiguration.class })
static class ServletSessionConfiguration { static class ServletSessionConfiguration {
private final SpringSessionRememberMeServices springSessionRememberMeServices;
ServletSessionConfiguration(
ObjectProvider<SpringSessionRememberMeServices> springSessionRememberMeServices) {
this.springSessionRememberMeServices = springSessionRememberMeServices
.getIfAvailable();
}
@Bean @Bean
@Conditional(DefaultCookieSerializerCondition.class) @Conditional(DefaultCookieSerializerCondition.class)
public DefaultCookieSerializer cookieSerializer( public DefaultCookieSerializer cookieSerializer(ServerProperties serverProperties,
ServerProperties serverProperties) { ObjectProvider<SpringSessionRememberMeServices> springSessionRememberMeServices) {
Cookie cookie = serverProperties.getServlet().getSession().getCookie(); Cookie cookie = serverProperties.getServlet().getSession().getCookie();
DefaultCookieSerializer cookieSerializer = new DefaultCookieSerializer(); DefaultCookieSerializer cookieSerializer = new DefaultCookieSerializer();
PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull(); PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull();
...@@ -112,10 +104,9 @@ public class SessionAutoConfiguration { ...@@ -112,10 +104,9 @@ public class SessionAutoConfiguration {
map.from(cookie::getSecure).to(cookieSerializer::setUseSecureCookie); map.from(cookie::getSecure).to(cookieSerializer::setUseSecureCookie);
map.from(cookie::getMaxAge).to((maxAge) -> cookieSerializer map.from(cookie::getMaxAge).to((maxAge) -> cookieSerializer
.setCookieMaxAge((int) maxAge.getSeconds())); .setCookieMaxAge((int) maxAge.getSeconds()));
if (this.springSessionRememberMeServices != null) { springSessionRememberMeServices.ifAvailable((
cookieSerializer.setRememberMeRequestAttribute( rememberMeServices) -> cookieSerializer.setRememberMeRequestAttribute(
SpringSessionRememberMeServices.REMEMBER_ME_LOGIN_ATTR); SpringSessionRememberMeServices.REMEMBER_ME_LOGIN_ATTR));
}
return cookieSerializer; return cookieSerializer;
} }
......
/* /*
* Copyright 2012-2018 the original author or authors. * Copyright 2012-2019 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment