Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
7bac7370
Commit
7bac7370
authored
Oct 27, 2014
by
Dave Syer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use request attribute if available for error message
Fixes gh-1762, gh-1731
parent
e8b59b9e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
1 deletion
+13
-1
DefaultErrorAttributes.java
...mework/boot/autoconfigure/web/DefaultErrorAttributes.java
+2
-1
DefaultErrorAttributesTests.java
...k/boot/autoconfigure/web/DefaultErrorAttributesTests.java
+11
-0
No files found.
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/DefaultErrorAttributes.java
View file @
7bac7370
...
@@ -75,6 +75,7 @@ public class DefaultErrorAttributes implements ErrorAttributes, HandlerException
...
@@ -75,6 +75,7 @@ public class DefaultErrorAttributes implements ErrorAttributes, HandlerException
private
void
storeErrorAttributes
(
HttpServletRequest
request
,
Exception
ex
)
{
private
void
storeErrorAttributes
(
HttpServletRequest
request
,
Exception
ex
)
{
request
.
setAttribute
(
ERROR_ATTRIBUTE
,
ex
);
request
.
setAttribute
(
ERROR_ATTRIBUTE
,
ex
);
}
}
@Override
@Override
...
@@ -120,7 +121,7 @@ public class DefaultErrorAttributes implements ErrorAttributes, HandlerException
...
@@ -120,7 +121,7 @@ public class DefaultErrorAttributes implements ErrorAttributes, HandlerException
addStackTrace
(
errorAttributes
,
error
);
addStackTrace
(
errorAttributes
,
error
);
}
}
}
}
else
{
if
(
error
==
null
||
errorAttributes
.
get
(
"message"
)==
null
)
{
Object
message
=
getAttribute
(
requestAttributes
,
Object
message
=
getAttribute
(
requestAttributes
,
"javax.servlet.error.message"
);
"javax.servlet.error.message"
);
errorAttributes
.
put
(
"message"
,
message
==
null
?
"No message available"
errorAttributes
.
put
(
"message"
,
message
==
null
?
"No message available"
...
...
spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/DefaultErrorAttributesTests.java
View file @
7bac7370
...
@@ -118,6 +118,17 @@ public class DefaultErrorAttributesTests {
...
@@ -118,6 +118,17 @@ public class DefaultErrorAttributesTests {
assertThat
(
attributes
.
get
(
"message"
),
equalTo
((
Object
)
"Test"
));
assertThat
(
attributes
.
get
(
"message"
),
equalTo
((
Object
)
"Test"
));
}
}
@Test
public
void
nullMessage
()
throws
Exception
{
this
.
request
.
setAttribute
(
"javax.servlet.error.exception"
,
new
RuntimeException
());
this
.
request
.
setAttribute
(
"javax.servlet.error.message"
,
"Test"
);
Map
<
String
,
Object
>
attributes
=
this
.
errorAttributes
.
getErrorAttributes
(
this
.
requestAttributes
,
false
);
assertThat
(
attributes
.
get
(
"exception"
),
equalTo
((
Object
)
RuntimeException
.
class
.
getName
()));
assertThat
(
attributes
.
get
(
"message"
),
equalTo
((
Object
)
"Test"
));
}
@Test
@Test
public
void
unwrapServletException
()
throws
Exception
{
public
void
unwrapServletException
()
throws
Exception
{
RuntimeException
ex
=
new
RuntimeException
(
"Test"
);
RuntimeException
ex
=
new
RuntimeException
(
"Test"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment