Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
7c36c003
Commit
7c36c003
authored
Mar 28, 2018
by
Stephane Nicoll
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix default HierarchicalNameMapper implementation for Graphite
Closes gh-12557
parent
958f3d5b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
19 additions
and
2 deletions
+19
-2
GraphiteMetricsExportAutoConfiguration.java
...port/graphite/GraphiteMetricsExportAutoConfiguration.java
+3
-2
GraphiteMetricsExportAutoConfigurationTests.java
...graphite/GraphiteMetricsExportAutoConfigurationTests.java
+16
-0
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/graphite/GraphiteMetricsExportAutoConfiguration.java
View file @
7c36c003
...
...
@@ -19,6 +19,7 @@ package org.springframework.boot.actuate.autoconfigure.metrics.export.graphite;
import
io.micrometer.core.instrument.Clock
;
import
io.micrometer.core.instrument.util.HierarchicalNameMapper
;
import
io.micrometer.graphite.GraphiteConfig
;
import
io.micrometer.graphite.GraphiteHierarchicalNameMapper
;
import
io.micrometer.graphite.GraphiteMeterRegistry
;
import
org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration
;
...
...
@@ -66,8 +67,8 @@ public class GraphiteMetricsExportAutoConfiguration {
@Bean
@ConditionalOnMissingBean
public
HierarchicalNameMapper
hierarchicalNameMapper
()
{
return
HierarchicalNameMapper
.
DEFAULT
;
public
HierarchicalNameMapper
hierarchicalNameMapper
(
GraphiteConfig
graphiteConfig
)
{
return
new
GraphiteHierarchicalNameMapper
(
graphiteConfig
.
tagsAsPrefix
())
;
}
}
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/graphite/GraphiteMetricsExportAutoConfigurationTests.java
View file @
7c36c003
...
...
@@ -19,6 +19,7 @@ package org.springframework.boot.actuate.autoconfigure.metrics.export.graphite;
import
java.util.Map
;
import
io.micrometer.core.instrument.Clock
;
import
io.micrometer.core.instrument.Tags
;
import
io.micrometer.graphite.GraphiteConfig
;
import
io.micrometer.graphite.GraphiteMeterRegistry
;
import
org.junit.Test
;
...
...
@@ -39,6 +40,7 @@ import static org.mockito.Mockito.verify;
* Tests for {@link GraphiteMetricsExportAutoConfiguration}.
*
* @author Andy Wilkinson
* @author Stephane Nicoll
*/
public
class
GraphiteMetricsExportAutoConfigurationTests
{
...
...
@@ -52,6 +54,20 @@ public class GraphiteMetricsExportAutoConfigurationTests {
.
doesNotHaveBean
(
GraphiteMeterRegistry
.
class
));
}
@Test
public
void
autoConfiguresUseTagsAsPrefix
()
{
this
.
contextRunner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
.
withPropertyValues
(
"management.metrics.export.graphite.tags-as-prefix=app"
)
.
run
((
context
)
->
{
assertThat
(
context
).
hasSingleBean
(
GraphiteMeterRegistry
.
class
);
GraphiteMeterRegistry
registry
=
context
.
getBean
(
GraphiteMeterRegistry
.
class
);
registry
.
counter
(
"test.count"
,
Tags
.
of
(
"app"
,
"myapp"
));
assertThat
(
registry
.
getDropwizardRegistry
().
getMeters
())
.
containsOnlyKeys
(
"myapp.testCount"
);
});
}
@Test
public
void
autoConfiguresItsConfigAndMeterRegistry
()
{
this
.
contextRunner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment