Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
8426e3c2
Commit
8426e3c2
authored
Jul 10, 2018
by
Stephane Nicoll
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch '2.0.x'
parents
6fdc5d0e
dd2b0eb7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
8 deletions
+5
-8
TraceableHttpServletRequest.java
...ctuate/web/trace/servlet/TraceableHttpServletRequest.java
+2
-5
TraceableHttpServletRequestTests.java
...e/web/trace/servlet/TraceableHttpServletRequestTests.java
+3
-3
No files found.
spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/web/trace/servlet/TraceableHttpServletRequest.java
View file @
8426e3c2
...
@@ -60,17 +60,14 @@ final class TraceableHttpServletRequest implements TraceableRequest {
...
@@ -60,17 +60,14 @@ final class TraceableHttpServletRequest implements TraceableRequest {
return
new
URI
(
urlBuffer
.
toString
());
return
new
URI
(
urlBuffer
.
toString
());
}
}
catch
(
URISyntaxException
ex
)
{
catch
(
URISyntaxException
ex
)
{
String
encoded
=
UriUtils
.
encode
(
queryString
,
StandardCharsets
.
UTF_8
);
String
encoded
=
UriUtils
.
encode
Query
(
queryString
,
StandardCharsets
.
UTF_8
);
StringBuffer
urlBuffer
=
appendQueryString
(
encoded
);
StringBuffer
urlBuffer
=
appendQueryString
(
encoded
);
return
URI
.
create
(
urlBuffer
.
toString
());
return
URI
.
create
(
urlBuffer
.
toString
());
}
}
}
}
private
StringBuffer
appendQueryString
(
String
queryString
)
{
private
StringBuffer
appendQueryString
(
String
queryString
)
{
StringBuffer
urlBuffer
=
this
.
request
.
getRequestURL
();
return
this
.
request
.
getRequestURL
().
append
(
"?"
).
append
(
queryString
);
urlBuffer
.
append
(
"?"
);
urlBuffer
.
append
(
queryString
);
return
urlBuffer
;
}
}
@Override
@Override
...
...
spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/web/trace/servlet/TraceableHttpServletRequestTests.java
View file @
8426e3c2
...
@@ -50,13 +50,13 @@ public class TraceableHttpServletRequestTests {
...
@@ -50,13 +50,13 @@ public class TraceableHttpServletRequestTests {
@Test
@Test
public
void
getUriWithSpecialCharactersInQueryStringShouldEncode
()
{
public
void
getUriWithSpecialCharactersInQueryStringShouldEncode
()
{
this
.
request
.
setQueryString
(
"a=${b}"
);
this
.
request
.
setQueryString
(
"a=${b}"
);
validate
(
"http://localhost/script?a
%3D%24
%7Bb%7D"
);
validate
(
"http://localhost/script?a
=$
%7Bb%7D"
);
}
}
@Test
@Test
public
void
getUriWithSpecialCharactersEncodedShouldNotDoubleEncode
()
{
public
void
getUriWithSpecialCharactersEncodedShouldNotDoubleEncode
()
{
this
.
request
.
setQueryString
(
"a
%3D%24
%7Bb%7D"
);
this
.
request
.
setQueryString
(
"a
=$
%7Bb%7D"
);
validate
(
"http://localhost/script?a
%3D%24
%7Bb%7D"
);
validate
(
"http://localhost/script?a
=$
%7Bb%7D"
);
}
}
private
void
validate
(
String
expectedUri
)
{
private
void
validate
(
String
expectedUri
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment