Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
8755b4a5
Commit
8755b4a5
authored
Feb 26, 2018
by
Stephane Nicoll
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #12203 from dreis2211:polish-tomcat-tests
* pr/12203: Polish argument capturing in two Tomcat tests
parents
c3ae02a4
cbabf541
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
30 deletions
+10
-30
TomcatReactiveWebServerFactoryTests.java
.../embedded/tomcat/TomcatReactiveWebServerFactoryTests.java
+5
-15
TomcatServletWebServerFactoryTests.java
...b/embedded/tomcat/TomcatServletWebServerFactoryTests.java
+5
-15
No files found.
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/tomcat/TomcatReactiveWebServerFactoryTests.java
View file @
8755b4a5
...
...
@@ -24,16 +24,14 @@ import org.apache.catalina.LifecycleListener;
import
org.apache.catalina.connector.Connector
;
import
org.apache.catalina.core.AprLifecycleListener
;
import
org.junit.Test
;
import
org.mockito.ArgumentCaptor
;
import
org.mockito.InOrder
;
import
org.mockito.invocation.InvocationOnMock
;
import
org.mockito.stubbing.Answer
;
import
org.springframework.boot.web.reactive.server.AbstractReactiveWebServerFactoryTests
;
import
org.springframework.http.server.reactive.HttpHandler
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
mockito
.
ArgumentMatchers
.
any
;
import
static
org
.
mockito
.
BDDMockito
.
willAnswer
;
import
static
org
.
mockito
.
Mockito
.
inOrder
;
import
static
org
.
mockito
.
Mockito
.
mock
;
import
static
org
.
mockito
.
Mockito
.
verify
;
...
...
@@ -69,22 +67,14 @@ public class TomcatReactiveWebServerFactoryTests
}
@Test
public
void
contextIsAddedToHostBeforeCustomizersAreCalled
()
throws
Exception
{
public
void
contextIsAddedToHostBeforeCustomizersAreCalled
()
{
TomcatReactiveWebServerFactory
factory
=
getFactory
();
TomcatContextCustomizer
customizer
=
mock
(
TomcatContextCustomizer
.
class
);
willAnswer
(
new
Answer
<
Void
>()
{
@Override
public
Void
answer
(
InvocationOnMock
invocation
)
throws
Throwable
{
assertThat
(((
Context
)
invocation
.
getArguments
()[
0
]).
getParent
())
.
isNotNull
();
return
null
;
}
}).
given
(
customizer
).
customize
(
any
(
Context
.
class
));
factory
.
addContextCustomizers
(
customizer
);
this
.
webServer
=
factory
.
getWebServer
(
mock
(
HttpHandler
.
class
));
verify
(
customizer
).
customize
(
any
(
Context
.
class
));
ArgumentCaptor
<
Context
>
contextCaptor
=
ArgumentCaptor
.
forClass
(
Context
.
class
);
verify
(
customizer
).
customize
(
contextCaptor
.
capture
());
assertThat
(
contextCaptor
.
getValue
().
getParent
()).
isNotNull
();
}
@Test
...
...
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/tomcat/TomcatServletWebServerFactoryTests.java
View file @
8755b4a5
...
...
@@ -49,9 +49,8 @@ import org.apache.tomcat.JarScanFilter;
import
org.junit.After
;
import
org.junit.Rule
;
import
org.junit.Test
;
import
org.mockito.ArgumentCaptor
;
import
org.mockito.InOrder
;
import
org.mockito.invocation.InvocationOnMock
;
import
org.mockito.stubbing.Answer
;
import
org.springframework.boot.testsupport.rule.OutputCapture
;
import
org.springframework.boot.web.server.WebServerException
;
...
...
@@ -63,7 +62,6 @@ import static org.assertj.core.api.Assertions.assertThat;
import
static
org
.
junit
.
Assert
.
fail
;
import
static
org
.
mockito
.
ArgumentMatchers
.
any
;
import
static
org
.
mockito
.
BDDMockito
.
given
;
import
static
org
.
mockito
.
BDDMockito
.
willAnswer
;
import
static
org
.
mockito
.
Mockito
.
inOrder
;
import
static
org
.
mockito
.
Mockito
.
mock
;
import
static
org
.
mockito
.
Mockito
.
verify
;
...
...
@@ -147,22 +145,14 @@ public class TomcatServletWebServerFactoryTests
}
@Test
public
void
contextIsAddedToHostBeforeCustomizersAreCalled
()
throws
Exception
{
public
void
contextIsAddedToHostBeforeCustomizersAreCalled
()
{
TomcatServletWebServerFactory
factory
=
getFactory
();
TomcatContextCustomizer
customizer
=
mock
(
TomcatContextCustomizer
.
class
);
willAnswer
(
new
Answer
<
Void
>()
{
@Override
public
Void
answer
(
InvocationOnMock
invocation
)
throws
Throwable
{
assertThat
(((
Context
)
invocation
.
getArguments
()[
0
]).
getParent
())
.
isNotNull
();
return
null
;
}
}).
given
(
customizer
).
customize
(
any
(
Context
.
class
));
factory
.
addContextCustomizers
(
customizer
);
this
.
webServer
=
factory
.
getWebServer
();
verify
(
customizer
).
customize
(
any
(
Context
.
class
));
ArgumentCaptor
<
Context
>
contextCaptor
=
ArgumentCaptor
.
forClass
(
Context
.
class
);
verify
(
customizer
).
customize
(
contextCaptor
.
capture
());
assertThat
(
contextCaptor
.
getValue
().
getParent
()).
isNotNull
();
}
@Test
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment