Commit 91f4541a authored by Andy Wilkinson's avatar Andy Wilkinson

Merge branch '2.2.x' into 2.3.x

See gh-24052
parents 2ffb81f0 006d4bc3
...@@ -148,7 +148,9 @@ class SslConnectorCustomizer implements TomcatConnectorCustomizer { ...@@ -148,7 +148,9 @@ class SslConnectorCustomizer implements TomcatConnectorCustomizer {
throw new WebServerException("Could not load trust store: " + ex.getMessage(), ex); throw new WebServerException("Could not load trust store: " + ex.getMessage(), ex);
} }
} }
protocol.setTruststorePass(ssl.getTrustStorePassword()); if (ssl.getTrustStorePassword() != null) {
protocol.setTruststorePass(ssl.getTrustStorePassword());
}
if (ssl.getTrustStoreType() != null) { if (ssl.getTrustStoreType() != null) {
protocol.setTruststoreType(ssl.getTrustStoreType()); protocol.setTruststoreType(ssl.getTrustStoreType());
} }
......
...@@ -206,6 +206,17 @@ class SslConnectorCustomizerTests { ...@@ -206,6 +206,17 @@ class SslConnectorCustomizerTests {
assertThat(protocol.getKeyPass()).isEqualTo("password"); assertThat(protocol.getKeyPass()).isEqualTo("password");
} }
@Test
void trustStorePasswordIsNotSetWhenNull() {
Http11NioProtocol protocol = (Http11NioProtocol) this.tomcat.getConnector().getProtocolHandler();
protocol.setTruststorePass("password");
Ssl ssl = new Ssl();
ssl.setKeyStore("src/test/resources/test.jks");
ssl.setTrustStore("src/test/resources/test.jks");
new SslConnectorCustomizer(ssl, null).customize(this.tomcat.getConnector());
assertThat(protocol.getTruststorePass()).isEqualTo("password");
}
private KeyStore loadStore() throws KeyStoreException, IOException, NoSuchAlgorithmException, CertificateException { private KeyStore loadStore() throws KeyStoreException, IOException, NoSuchAlgorithmException, CertificateException {
KeyStore keyStore = KeyStore.getInstance("JKS"); KeyStore keyStore = KeyStore.getInstance("JKS");
Resource resource = new ClassPathResource("test.jks"); Resource resource = new ClassPathResource("test.jks");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment