Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
96b1a854
Commit
96b1a854
authored
Jul 06, 2017
by
Madhura Bhave
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Decorate KeyManager for Undertow only when an alias is configured
Fixes gh-9351
parent
a064a52f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
2 deletions
+18
-2
UndertowEmbeddedServletContainerFactory.java
...ded/undertow/UndertowEmbeddedServletContainerFactory.java
+6
-2
UndertowEmbeddedServletContainerFactoryTests.java
...ndertow/UndertowEmbeddedServletContainerFactoryTests.java
+12
-0
No files found.
spring-boot/src/main/java/org/springframework/boot/context/embedded/undertow/UndertowEmbeddedServletContainerFactory.java
View file @
96b1a854
...
...
@@ -316,8 +316,12 @@ public class UndertowEmbeddedServletContainerFactory
keyPassword
=
ssl
.
getKeyStorePassword
().
toCharArray
();
}
keyManagerFactory
.
init
(
keyStore
,
keyPassword
);
return
getConfigurableAliasKeyManagers
(
ssl
,
keyManagerFactory
.
getKeyManagers
());
if
(
ssl
.
getKeyAlias
()
!=
null
)
{
return
getConfigurableAliasKeyManagers
(
ssl
,
keyManagerFactory
.
getKeyManagers
());
}
return
keyManagerFactory
.
getKeyManagers
();
}
catch
(
Exception
ex
)
{
throw
new
IllegalStateException
(
ex
);
...
...
spring-boot/src/test/java/org/springframework/boot/context/embedded/undertow/UndertowEmbeddedServletContainerFactoryTests.java
View file @
96b1a854
...
...
@@ -28,6 +28,7 @@ import java.util.Map;
import
java.util.Set
;
import
java.util.concurrent.atomic.AtomicReference
;
import
javax.net.ssl.KeyManager
;
import
javax.net.ssl.SSLHandshakeException
;
import
io.undertow.Undertow.Builder
;
...
...
@@ -43,6 +44,7 @@ import org.springframework.boot.context.embedded.AbstractEmbeddedServletContaine
import
org.springframework.boot.context.embedded.ExampleServlet
;
import
org.springframework.boot.context.embedded.MimeMappings.Mapping
;
import
org.springframework.boot.context.embedded.PortInUseException
;
import
org.springframework.boot.context.embedded.Ssl
;
import
org.springframework.boot.web.servlet.ErrorPage
;
import
org.springframework.boot.web.servlet.ServletRegistrationBean
;
import
org.springframework.http.HttpStatus
;
...
...
@@ -250,6 +252,16 @@ public class UndertowEmbeddedServletContainerFactoryTests
new
String
[]
{
"TLS_RSA_WITH_AES_128_CBC_SHA256"
});
}
@Test
public
void
getKeyManagersWhenAliasIsNullShouldNotDecorate
()
throws
Exception
{
UndertowEmbeddedServletContainerFactory
factory
=
getFactory
();
Ssl
ssl
=
getSsl
(
null
,
"password"
,
"src/test/resources/test.jks"
);
factory
.
setSsl
(
ssl
);
KeyManager
[]
keyManagers
=
ReflectionTestUtils
.
invokeMethod
(
factory
,
"getKeyManagers"
);
Class
<?>
name
=
Class
.
forName
(
"org.springframework.boot.context.embedded.undertow.UndertowEmbeddedServletContainerFactory$ConfigurableAliasKeyManager"
);
assertThat
(
keyManagers
[
0
]).
isNotInstanceOf
(
name
);
}
@Override
protected
JspServlet
getJspServlet
()
{
return
null
;
// Undertow does not support JSPs
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment