Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
98cf35d4
Commit
98cf35d4
authored
Feb 28, 2017
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Polish "Ignore spock.lang annotations when creating test context cache key"
See gh-8252
parent
8f18df8a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
29 additions
and
9 deletions
+29
-9
ImportsContextCustomizer.java
...framework/boot/test/context/ImportsContextCustomizer.java
+3
-3
ImportsContextCustomizerTests.java
...work/boot/test/context/ImportsContextCustomizerTests.java
+26
-6
No files found.
spring-boot-test/src/main/java/org/springframework/boot/test/context/ImportsContextCustomizer.java
View file @
98cf35d4
/*
* Copyright 2012-201
6
the original author or authors.
* Copyright 2012-201
7
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
@@ -324,8 +324,8 @@ class ImportsContextCustomizer implements ContextCustomizer {
@Override
public
boolean
isIgnored
(
Annotation
annotation
)
{
return
annotation
.
annotationType
().
getName
().
startsWith
(
"org.spockframework."
)
||
annotation
.
annotationType
().
getName
().
startsWith
(
"spock."
);
return
annotation
.
annotationType
().
getName
().
startsWith
(
"org.spockframework."
)
||
annotation
.
annotationType
().
getName
().
startsWith
(
"spock."
);
}
}
...
...
spring-boot-test/src/test/java/org/springframework/boot/test/context/ImportsContextCustomizerTests.java
View file @
98cf35d4
/*
* Copyright 2012-201
6
the original author or authors.
* Copyright 2012-201
7
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
@@ -19,6 +19,8 @@ package org.springframework.boot.test.context;
import
kotlin.Metadata
;
import
org.junit.Test
;
import
org.spockframework.runtime.model.SpecMetadata
;
import
spock.lang.Issue
;
import
spock.lang.Stepwise
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
...
@@ -37,10 +39,18 @@ public class ImportsContextCustomizerTests {
}
@Test
public
void
customizersForTestClassesWithDifferentSpockMetadataAreEqual
()
{
assertThat
(
new
ImportsContextCustomizer
(
FirstSpockAnnotatedTestClass
.
class
))
public
void
customizersForTestClassesWithDifferentSpockFrameworkAnnotationsAreEqual
()
{
assertThat
(
new
ImportsContextCustomizer
(
FirstSpockFrameworkAnnotatedTestClass
.
class
))
.
isEqualTo
(
new
ImportsContextCustomizer
(
SecondSpockFrameworkAnnotatedTestClass
.
class
));
}
@Test
public
void
customizersForTestClassesWithDifferentSpockLangAnnotationsAreEqual
()
{
assertThat
(
new
ImportsContextCustomizer
(
FirstSpockLangAnnotatedTestClass
.
class
))
.
isEqualTo
(
new
ImportsContextCustomizer
(
SecondSpockAnnotatedTestClass
.
class
));
SecondSpock
Lang
AnnotatedTestClass
.
class
));
}
@Metadata
(
d2
=
"foo"
)
...
...
@@ -54,12 +64,22 @@ public class ImportsContextCustomizerTests {
}
@SpecMetadata
(
filename
=
"foo"
,
line
=
10
)
static
class
FirstSpockAnnotatedTestClass
{
static
class
FirstSpock
Framework
AnnotatedTestClass
{
}
@SpecMetadata
(
filename
=
"bar"
,
line
=
10
)
static
class
SecondSpockAnnotatedTestClass
{
static
class
SecondSpockFrameworkAnnotatedTestClass
{
}
@Stepwise
static
class
FirstSpockLangAnnotatedTestClass
{
}
@Issue
(
"1234"
)
static
class
SecondSpockLangAnnotatedTestClass
{
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment