Commit 9d4671ac authored by Stephane Nicoll's avatar Stephane Nicoll

Merge pull request #17785 from SaberMaycry

* pr/17785:
  Polish "Simplify if statements"
  Simplify if statements

Closes gh-17785
parents 3efead4b 1c8f7278
...@@ -165,7 +165,7 @@ public class ConfigurationMetadata { ...@@ -165,7 +165,7 @@ public class ConfigurationMetadata {
if (o1 == o2) { if (o1 == o2) {
return true; return true;
} }
return o1 != null && o2 != null && o1.equals(o2); return o1 != null && o1.equals(o2);
} }
public static String nestedPrefix(String prefix, String name) { public static String nestedPrefix(String prefix, String name) {
......
...@@ -106,17 +106,14 @@ public class LaunchScriptConfiguration implements Serializable { ...@@ -106,17 +106,14 @@ public class LaunchScriptConfiguration implements Serializable {
return false; return false;
} }
if (this.script == null) { if (this.script == null) {
if (other.script != null) { return other.script == null;
return false;
}
} }
else if (!this.script.equals(other.script)) { else if (!this.script.equals(other.script)) {
return false; return false;
} }
else if (!equalContents(this.script, other.script)) { else {
return false; return equalContents(this.script, other.script);
} }
return true;
} }
private boolean equalContents(File one, File two) { private boolean equalContents(File one, File two) {
...@@ -132,7 +129,7 @@ public class LaunchScriptConfiguration implements Serializable { ...@@ -132,7 +129,7 @@ public class LaunchScriptConfiguration implements Serializable {
public int hashCode() { public int hashCode() {
final int prime = 31; final int prime = 31;
int result = 1; int result = 1;
result = prime * result + ((this.properties == null) ? 0 : this.properties.hashCode()); result = prime * result + this.properties.hashCode();
result = prime * result + ((this.script == null) ? 0 : this.script.hashCode()); result = prime * result + ((this.script == null) ? 0 : this.script.hashCode());
return result; return result;
} }
......
...@@ -52,10 +52,7 @@ public class PropertiesMergingResourceTransformer implements ResourceTransformer ...@@ -52,10 +52,7 @@ public class PropertiesMergingResourceTransformer implements ResourceTransformer
@Override @Override
public boolean canTransformResource(String resource) { public boolean canTransformResource(String resource) {
if (this.resource != null && this.resource.equalsIgnoreCase(resource)) { return this.resource != null && this.resource.equalsIgnoreCase(resource);
return true;
}
return false;
} }
@Override @Override
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment