Merge pull request #12432 from igor-suhorukov:master

* pr/12432:
  Polish "Reorder modifiers to comply with the JLS"
  Reorder modifiers to comply with the JLS

spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/context/properties/ConfigurationPropertiesReportEndpointProxyTests.java

@@ -91,7 +91,7 @@ public class ConfigurationPropertiesReportEndpointProxyTests {
 
 	}
 
-	public static abstract class AbstractExecutor implements Executor {
+	public abstract static class AbstractExecutor implements Executor {
 
 	}
 

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/cache/AbstractCacheAutoConfigurationTests.java

@@ -147,7 +147,7 @@ abstract class AbstractCacheAutoConfigurationTests {
 
 	}
 
-	static abstract class CacheManagerTestCustomizer<T extends CacheManager>
+	abstract static class CacheManagerTestCustomizer<T extends CacheManager>
 			implements CacheManagerCustomizer<T> {
 
 		T cacheManager;

spring-boot-project/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/SilentExitExceptionHandlerTests.java

 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -76,7 +76,7 @@ public class SilentExitExceptionHandlerTests {
 
 	}
 
-	private static abstract class TestThread extends Thread {
+	private abstract static class TestThread extends Thread {
 
 		private Throwable thrown;
 

spring-boot-project/spring-boot-parent/src/checkstyle/checkstyle.xml

@@ -129,6 +129,8 @@
 
 		<!-- Modifiers -->
 		<module name="com.puppycrawl.tools.checkstyle.checks.modifier.RedundantModifierCheck" />
+		<module name="com.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheck"/>
+
 
 		<!-- Regexp -->
  		<module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/context/AbstractSpringBootTestEmbeddedReactiveWebEnvironmentTests.java

 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -88,7 +88,7 @@ public abstract class AbstractSpringBootTestEmbeddedReactiveWebEnvironmentTests
 		assertThat(this.value).isEqualTo(123);
 	}
 
-	protected static abstract class AbstractConfig {
+	protected abstract static class AbstractConfig {
 
 		@Value("${server.port:8080}")
 		private int port = 8080;

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/context/AbstractSpringBootTestWebServerWebEnvironmentTests.java

 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -92,7 +92,7 @@ public abstract class AbstractSpringBootTestWebServerWebEnvironmentTests {
 				WebApplicationContextUtils.getWebApplicationContext(this.servletContext));
 	}
 
-	protected static abstract class AbstractConfig {
+	protected abstract static class AbstractConfig {
 
 		@Value("${server.port:8080}")
 		private int port = 8080;

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/json/GsonTesterTests.java

 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -65,7 +65,7 @@ public class GsonTesterTests extends AbstractJsonMarshalTesterTests {
 		return new GsonTester<>(resourceLoadClass, type, new GsonBuilder().create());
 	}
 
-	static abstract class InitFieldsBaseClass {
+	abstract static class InitFieldsBaseClass {
 
 		public GsonTester<ExampleObject> base;
 

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/json/JacksonTesterTests.java

 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -64,7 +64,7 @@ public class JacksonTesterTests extends AbstractJsonMarshalTesterTests {
 		return new JacksonTester<>(resourceLoadClass, type, new ObjectMapper());
 	}
 
-	static abstract class InitFieldsBaseClass {
+	abstract static class InitFieldsBaseClass {
 
 		public JacksonTester<ExampleObject> base;
 

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/json/JsonbTesterTests.java

 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -66,7 +66,7 @@ public class JsonbTesterTests extends AbstractJsonMarshalTesterTests {
 		return new JsonbTester<>(resourceLoadClass, type, JsonbBuilder.create());
 	}
 
-	static abstract class InitFieldsBaseClass {
+	abstract static class InitFieldsBaseClass {
 
 		public JsonbTester<ExampleObject> base;
 

spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/Verify.java

 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -167,7 +167,7 @@ public final class Verify {
 
 	}
 
-	private static abstract class AbstractArchiveVerification {
+	private abstract static class AbstractArchiveVerification {
 
 		private final File file;
 

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/util/LambdaSafe.java

@@ -100,7 +100,7 @@ public final class LambdaSafe {
 	/**
 	 * Abstract base class for lambda safe callbacks.
 	 */
-	private static abstract class LambdaSafeCallback<C, A, SELF extends LambdaSafeCallback<C, A, SELF>> {
+	private abstract static class LambdaSafeCallback<C, A, SELF extends LambdaSafeCallback<C, A, SELF>> {
 
 		private final Class<C> callbackType;
 

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/SpringApplicationTests.java

@@ -1357,7 +1357,7 @@ public class SpringApplicationTests {
 
 	}
 
-	static abstract class AbstractTestRunner implements ApplicationContextAware, Ordered {
+	abstract static class AbstractTestRunner implements ApplicationContextAware, Ordered {
 
 		private final String[] expectedBefore;
 

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/jackson/JsonComponentModuleTests.java

 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -110,7 +110,7 @@ public class JsonComponentModuleTests {
 	@JsonComponent
 	static class ComponentWithInnerAbstractClass {
 
-		private static abstract class AbstractSerializer
+		private abstract static class AbstractSerializer
 				extends NameAndAgeJsonComponent.Serializer {
 
 		}